All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: xyjxie@linux.vnet.ibm.com
Cc: famz@redhat.com, alex.williamson@redhat.com, aik@ozlabs.ru,
	zhong@linux.vnet.ibm.com, qemu-devel@nongnu.org,
	kvm@vger.kernel.org, gwshan@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2] vfio: Add support for mmapping sub-page MMIO BARs
Date: Thu, 11 Aug 2016 04:09:15 -0700 (PDT)	[thread overview]
Message-ID: <20160811110913.482797.38333@ex-std-node742.prod.rhcloud.com> (raw)
In-Reply-To: <1470913557-4355-1-git-send-email-xyjxie@linux.vnet.ibm.com>

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 1470913557-4355-1-git-send-email-xyjxie@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v2] vfio: Add support for mmapping sub-page MMIO BARs
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1470913557-4355-1-git-send-email-xyjxie@linux.vnet.ibm.com -> patchew/1470913557-4355-1-git-send-email-xyjxie@linux.vnet.ibm.com
Switched to a new branch 'test'
36f327d vfio: Add support for mmapping sub-page MMIO BARs

=== OUTPUT BEGIN ===
Checking PATCH 1/1: vfio: Add support for mmapping sub-page MMIO BARs...
ERROR: code indent should never use tabs
#87: FILE: hw/vfio/pci.c:1101:
+^I}$

total: 1 errors, 0 warnings, 97 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

  reply	other threads:[~2016-08-11 11:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 11:05 [Qemu-devel] [PATCH v2] vfio: Add support for mmapping sub-page MMIO BARs Yongji Xie
2016-08-11 11:09 ` no-reply [this message]
2016-09-05 10:25 ` Yongji Xie
2016-09-13 22:55 ` Alex Williamson
2016-09-14  5:04   ` Yongji Xie
2016-09-30 16:05   ` Paolo Bonzini
2016-10-04  6:57     ` Yongji Xie
2016-09-07  0:48 [Qemu-devel] [PATCH] hmp: Improve 'info mtree' with optional parm for mapinfo Thorsten Kohfeldt
2016-09-15  9:52 ` Paolo Bonzini
2016-09-20  0:16   ` Thorsten Kohfeldt
2016-09-20  0:51     ` Laszlo Ersek
2016-09-22 19:43       ` [Qemu-devel] [PATCH v2] vfio: Add support for mmapping sub-page MMIO BARs Thorsten Kohfeldt
2016-09-30  4:00 Thorsten Kohfeldt
2016-09-30 15:07 ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160811110913.482797.38333@ex-std-node742.prod.rhcloud.com \
    --to=no-reply@patchew.org \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=famz@redhat.com \
    --cc=gwshan@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=xyjxie@linux.vnet.ibm.com \
    --cc=zhong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.