From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466AbcHKRk5 (ORCPT ); Thu, 11 Aug 2016 13:40:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:46116 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288AbcHKRkz (ORCPT ); Thu, 11 Aug 2016 13:40:55 -0400 Date: Thu, 11 Aug 2016 14:40:35 -0300 From: Arnaldo Carvalho de Melo To: Ravi Bangoria Cc: Anton Blanchard , linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, bsingharora@gmail.com, naveen.n.rao@linux.vnet.ibm.com, ananth@in.ibm.com, mhiramat@kernel.org, wangnan0@huawei.com, namhyung@kernel.org, Hemant Kumar Subject: Re: [PATCH 2/2] perf ppc64le: Fix probe location when using DWARF Message-ID: <20160811174035.GH27651@kernel.org> References: <1470723805-5081-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1470723805-5081-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20160811095457.415aa94e@kryten> <57ABFF88.8030905@linux.vnet.ibm.com> <20160811115026.GA27651@kernel.org> <57AC7BE3.7060808@linux.vnet.ibm.com> <20160811144900.GD27651@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160811144900.GD27651@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Aug 11, 2016 at 11:49:00AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Aug 11, 2016 at 06:51:39PM +0530, Ravi Bangoria escreveu: > > On Thursday 11 August 2016 05:20 PM, Arnaldo Carvalho de Melo wrote: > > > Can you please provide a better explanation? I had to look at the patch > > > to understand what it was fixing, and then the patch adds LIBELF_SUPPORT > > > ifdefs while the patch description, talks about DWARF. > > Yes. Explanation could have been better. Apologies for that. > > arch__post_process_probe_trace_events() calls get_target_map() to prepare > > symbol table. get_target_map() is defined inside util/probe-event.c. > > probe-event.c will only get included in perf binary if CONFIG_LIBELF is set. > > Hence arch__post_process_probe_trace_events() needs to be defined inside > > #ifdef HAVE_LIBELF_SUPPORT to solve compilation error. > > Please let me know if any doubts. > Thanks, that is better, will add this there. But the patch his mangled, you use: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 Please read Documentation/email-clients.txt, there are ways to fix the sending of patches. I fixed it up this time, there were two instances like: [acme@jouet linux]$ patch -p1 < /wb/1.patch patching file tools/perf/arch/powerpc/util/sym-handling.c patch: **** malformed patch at line 33: @@ -118,5 +119,6 @@ void arch__post_process_probe_trace_events(struct it breaks down long lines ;-\ [acme@jouet linux]$ - Arnaldo