From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mammedov Subject: Re: [PATCH v2 0/8] nvdimm: hotplug support Date: Fri, 12 Aug 2016 17:13:49 +0200 Message-ID: <20160812171349.1456a2f5@nial.brq.redhat.com> References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> <20160812083512.GA10583@stefanha-x1.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Xiao Guangrong , pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Stefan Hajnoczi Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54876 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbcHLPNy (ORCPT ); Fri, 12 Aug 2016 11:13:54 -0400 In-Reply-To: <20160812083512.GA10583@stefanha-x1.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 12 Aug 2016 09:35:12 +0100 Stefan Hajnoczi wrote: > On Fri, Aug 12, 2016 at 02:54:02PM +0800, Xiao Guangrong wrote: > > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > > rx queue siz) on pci branch of Michael's git tree and can be found at: > > https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2 > > > > Changelog in v2: > > Fixed signed integer overflow pointed out by Stefan Hajnoczi > > > > This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug, > > for example, a new nvdimm device can be plugged as follows: > > object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3 > > device_add nvdimm,id=nvdimm3,memdev=mem3 > > > > and unplug it as follows: > > device_del nvdimm3 > > object_del mem3 > > > > Xiao Guangrong (8): > > acpi nvdimm: fix wrong buffer size returned by DSM method > > nvdimm acpi: prebuild nvdimm devices for available slots > > nvdimm acpi: introduce _FIT > > nvdimm acpi: implement Read FIT function > > pc-dimm: introduce prepare_unplug() callback > > pc: memhp: do not export nvdimm's memory via _CRS > > pc: acpi: memhp: nvdimm hotplug support > > nvdimm docs: add nvdimm Read FIT function > > > > docs/specs/acpi_mem_hotplug.txt | 4 +- > > docs/specs/acpi_nvdimm.txt | 38 +++++++- > > hw/acpi/ich9.c | 3 + > > hw/acpi/memory_hotplug.c | 21 +++-- > > hw/acpi/nvdimm.c | 195 +++++++++++++++++++++++++++++++++++---- > > hw/acpi/piix4.c | 3 + > > hw/i386/acpi-build.c | 28 +++++- > > hw/mem/nvdimm.c | 12 ++- > > hw/mem/pc-dimm.c | 5 + > > include/hw/acpi/memory_hotplug.h | 1 + > > include/hw/acpi/pc-hotplug.h | 1 + > > include/hw/mem/nvdimm.h | 6 +- > > include/hw/mem/pc-dimm.h | 1 + > > 13 files changed, 278 insertions(+), 40 deletions(-) > > > > -- > > 1.8.3.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Reviewed-by: Stefan Hajnoczi I'd like to review it but I need to read NVDIMM/ACPI specs first to make sensible comments. However it will take some time and I'm on vacation starting next week and I'll be back in a month. So please don't apply this series until I'm back and have a chance to review it. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYE9m-00075H-Mb for qemu-devel@nongnu.org; Fri, 12 Aug 2016 11:14:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYE9i-00060U-AX for qemu-devel@nongnu.org; Fri, 12 Aug 2016 11:13:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYE9i-00060D-17 for qemu-devel@nongnu.org; Fri, 12 Aug 2016 11:13:54 -0400 Date: Fri, 12 Aug 2016 17:13:49 +0200 From: Igor Mammedov Message-ID: <20160812171349.1456a2f5@nial.brq.redhat.com> In-Reply-To: <20160812083512.GA10583@stefanha-x1.localdomain> References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> <20160812083512.GA10583@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Xiao Guangrong , pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On Fri, 12 Aug 2016 09:35:12 +0100 Stefan Hajnoczi wrote: > On Fri, Aug 12, 2016 at 02:54:02PM +0800, Xiao Guangrong wrote: > > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > > rx queue siz) on pci branch of Michael's git tree and can be found at: > > https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2 > > > > Changelog in v2: > > Fixed signed integer overflow pointed out by Stefan Hajnoczi > > > > This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug, > > for example, a new nvdimm device can be plugged as follows: > > object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3 > > device_add nvdimm,id=nvdimm3,memdev=mem3 > > > > and unplug it as follows: > > device_del nvdimm3 > > object_del mem3 > > > > Xiao Guangrong (8): > > acpi nvdimm: fix wrong buffer size returned by DSM method > > nvdimm acpi: prebuild nvdimm devices for available slots > > nvdimm acpi: introduce _FIT > > nvdimm acpi: implement Read FIT function > > pc-dimm: introduce prepare_unplug() callback > > pc: memhp: do not export nvdimm's memory via _CRS > > pc: acpi: memhp: nvdimm hotplug support > > nvdimm docs: add nvdimm Read FIT function > > > > docs/specs/acpi_mem_hotplug.txt | 4 +- > > docs/specs/acpi_nvdimm.txt | 38 +++++++- > > hw/acpi/ich9.c | 3 + > > hw/acpi/memory_hotplug.c | 21 +++-- > > hw/acpi/nvdimm.c | 195 +++++++++++++++++++++++++++++++++++---- > > hw/acpi/piix4.c | 3 + > > hw/i386/acpi-build.c | 28 +++++- > > hw/mem/nvdimm.c | 12 ++- > > hw/mem/pc-dimm.c | 5 + > > include/hw/acpi/memory_hotplug.h | 1 + > > include/hw/acpi/pc-hotplug.h | 1 + > > include/hw/mem/nvdimm.h | 6 +- > > include/hw/mem/pc-dimm.h | 1 + > > 13 files changed, 278 insertions(+), 40 deletions(-) > > > > -- > > 1.8.3.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Reviewed-by: Stefan Hajnoczi I'd like to review it but I need to read NVDIMM/ACPI specs first to make sensible comments. However it will take some time and I'm on vacation starting next week and I'll be back in a month. So please don't apply this series until I'm back and have a chance to review it.