[PATCH 1/2] clk: fixed-factor: Remove export symbol on setup function

[PATCH 1/2] clk: fixed-factor: Remove export symbol on setup function

[Stephen Boyd]

This function is marked __init, so it can't possibly need to be
exported to modules. Remove the marking.

Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/clk/clk-fixed-factor.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
index 070d0d75da97..a5d402de5584 100644
--- a/drivers/clk/clk-fixed-factor.c
+++ b/drivers/clk/clk-fixed-factor.c
@@ -196,7 +196,6 @@ void __init of_fixed_factor_clk_setup(struct device_node *node)
 {
 	_of_fixed_factor_clk_setup(node);
 }
-EXPORT_SYMBOL_GPL(of_fixed_factor_clk_setup);
 CLK_OF_DECLARE(fixed_factor_clk, "fixed-factor-clock",
 		of_fixed_factor_clk_setup);
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function

[Stephen Boyd]

This function is only called by builtin code, but we always
exported it and had marked it as __init before commit
e4eda8e0654c (clk: remove exported function from __init section,
2013-01-06) removed that marking. Given that it isn't used by
modules, lets unexport it and add back __init.

Cc: Denis Efremov <yefremov.denis@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/clk/clk-fixed-rate.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
index c735272ed706..b5c46b3f8764 100644
--- a/drivers/clk/clk-fixed-rate.c
+++ b/drivers/clk/clk-fixed-rate.c
@@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node)
 /**
  * of_fixed_clk_setup() - Setup function for simple fixed rate clock
  */
-void of_fixed_clk_setup(struct device_node *node)
+void __init of_fixed_clk_setup(struct device_node *node)
 {
 	_of_fixed_clk_setup(node);
 }
-EXPORT_SYMBOL_GPL(of_fixed_clk_setup);
 CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup);
 
 static int of_fixed_clk_remove(struct platform_device *pdev)
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 1/2] clk: fixed-factor: Remove export symbol on setup function

[Stephen Boyd]

On 08/12, Stephen Boyd wrote:
> This function is marked __init, so it can't possibly need to be
> exported to modules. Remove the marking.
> 
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function

[Stephen Boyd]

On 08/12, Stephen Boyd wrote:
> This function is only called by builtin code, but we always
> exported it and had marked it as __init before commit
> e4eda8e0654c (clk: remove exported function from __init section,
> 2013-01-06) removed that marking. Given that it isn't used by
> modules, lets unexport it and add back __init.
> 
> Cc: Denis Efremov <yefremov.denis@gmail.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function

[Geert Uytterhoeven]

Hi Stephen,

On Sat, Aug 13, 2016 at 3:50 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> This function is only called by builtin code, but we always
> exported it and had marked it as __init before commit
> e4eda8e0654c (clk: remove exported function from __init section,
> 2013-01-06) removed that marking. Given that it isn't used by
> modules, lets unexport it and add back __init.
>
> Cc: Denis Efremov <yefremov.denis@gmail.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>  drivers/clk/clk-fixed-rate.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
> index c735272ed706..b5c46b3f8764 100644
> --- a/drivers/clk/clk-fixed-rate.c
> +++ b/drivers/clk/clk-fixed-rate.c
> @@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node)
>  /**
>   * of_fixed_clk_setup() - Setup function for simple fixed rate clock
>   */
> -void of_fixed_clk_setup(struct device_node *node)
> +void __init of_fixed_clk_setup(struct device_node *node)
>  {
>         _of_fixed_clk_setup(node);
>  }
> -EXPORT_SYMBOL_GPL(of_fixed_clk_setup);
>  CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup);

This function is needed to instantiate clocks from DT overlays,
which I'm using with out-of-tree "clk: add generic driver for fixed rate clock".

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function

[Stephen Boyd]

On 08/16, Geert Uytterhoeven wrote:
> Hi Stephen,
> 
> On Sat, Aug 13, 2016 at 3:50 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > This function is only called by builtin code, but we always
> > exported it and had marked it as __init before commit
> > e4eda8e0654c (clk: remove exported function from __init section,
> > 2013-01-06) removed that marking. Given that it isn't used by
> > modules, lets unexport it and add back __init.
> >
> > Cc: Denis Efremov <yefremov.denis@gmail.com>
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> >  drivers/clk/clk-fixed-rate.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
> > index c735272ed706..b5c46b3f8764 100644
> > --- a/drivers/clk/clk-fixed-rate.c
> > +++ b/drivers/clk/clk-fixed-rate.c
> > @@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node)
> >  /**
> >   * of_fixed_clk_setup() - Setup function for simple fixed rate clock
> >   */
> > -void of_fixed_clk_setup(struct device_node *node)
> > +void __init of_fixed_clk_setup(struct device_node *node)
> >  {
> >         _of_fixed_clk_setup(node);
> >  }
> > -EXPORT_SYMBOL_GPL(of_fixed_clk_setup);
> >  CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup);
> 
> This function is needed to instantiate clocks from DT overlays,
> which I'm using with out-of-tree "clk: add generic driver for fixed rate clock".
> 

I think Ricardo's latest series should make that work for you
with platform device drivers?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function

[Geert Uytterhoeven]

Hi Stephen,

On Tue, Aug 16, 2016 at 7:31 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 08/16, Geert Uytterhoeven wrote:
>> On Sat, Aug 13, 2016 at 3:50 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> > This function is only called by builtin code, but we always
>> > exported it and had marked it as __init before commit
>> > e4eda8e0654c (clk: remove exported function from __init section,
>> > 2013-01-06) removed that marking. Given that it isn't used by
>> > modules, lets unexport it and add back __init.
>> >
>> > Cc: Denis Efremov <yefremov.denis@gmail.com>
>> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> > ---
>> >  drivers/clk/clk-fixed-rate.c | 3 +--
>> >  1 file changed, 1 insertion(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
>> > index c735272ed706..b5c46b3f8764 100644
>> > --- a/drivers/clk/clk-fixed-rate.c
>> > +++ b/drivers/clk/clk-fixed-rate.c
>> > @@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node)
>> >  /**
>> >   * of_fixed_clk_setup() - Setup function for simple fixed rate clock
>> >   */
>> > -void of_fixed_clk_setup(struct device_node *node)
>> > +void __init of_fixed_clk_setup(struct device_node *node)
>> >  {
>> >         _of_fixed_clk_setup(node);
>> >  }
>> > -EXPORT_SYMBOL_GPL(of_fixed_clk_setup);
>> >  CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup);
>>
>> This function is needed to instantiate clocks from DT overlays,
>> which I'm using with out-of-tree "clk: add generic driver for fixed rate clock".
>
> I think Ricardo's latest series should make that work for you
> with platform device drivers?

Thanks, I had missed that series.
Ah, that one calls _of_fixed_clk_setup() instead, which should still work.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds