From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50511 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752495AbcHNPFh (ORCPT ); Sun, 14 Aug 2016 11:05:37 -0400 Date: Sun, 14 Aug 2016 17:05:41 +0200 From: Greg KH To: =?iso-8859-1?Q?Bj=F8rn?= Mork Cc: "Charles (Chas) Williams" , stable@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH 3.14.y 3/9] cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind Message-ID: <20160814150541.GA20560@kroah.com> References: <1468875203-10816-1-git-send-email-ciwillia@brocade.com> <1468875203-10816-3-git-send-email-ciwillia@brocade.com> <20160814144329.GB27230@kroah.com> <87bn0vflmg.fsf@miraculix.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87bn0vflmg.fsf@miraculix.mork.no> Sender: stable-owner@vger.kernel.org List-ID: On Sun, Aug 14, 2016 at 04:52:55PM +0200, Bj�rn Mork wrote: > Greg KH writes: > > On Mon, Jul 18, 2016 at 04:53:17PM -0400, Charles (Chas) Williams wrote: > >> From: Bj�rn Mork > >> > >> commit 4d06dd537f95683aba3651098ae288b7cbff8274 upstream. > >> > >> usbnet_link_change will call schedule_work and should be > >> avoided if bind is failing. Otherwise we will end up with > >> scheduled work referring to a netdev which has gone away. > >> > >> Instead of making the call conditional, we can just defer > >> it to usbnet_probe, using the driver_info flag made for > >> this purpose. > >> > >> CVE-2016-3951 > >> > >> Fixes: 8a34b0ae8778 ("usbnet: cdc_ncm: apply usbnet_link_change") > >> Reported-by: Andrey Konovalov > >> Suggested-by: Linus Torvalds > >> Signed-off-by: Bj�rn Mork > >> Signed-off-by: David S. Miller > >> [ciwillia@brocade.com: backported to 3.14: adjusted context] > >> Signed-off-by: Charles (Chas) Williams > >> --- > >> drivers/net/usb/cdc_ncm.c | 20 +++++--------------- > >> 1 file changed, 5 insertions(+), 15 deletions(-) > > > > Another patch that isn't in 4.4-stable, why not? > > Probably because I was sloppy when first posting it, and forgot to ask > David to queue it for stable. I see that this has later been requested > by Chas Williams: > https://www.mail-archive.com/netdev@vger.kernel.org/msg120134.html > > Yes, it should go into 4.4-stable. Thanks for letting me know, now queued up. greg k-h