From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752778AbcHOGne (ORCPT ); Mon, 15 Aug 2016 02:43:34 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33060 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752595AbcHOGnc (ORCPT ); Mon, 15 Aug 2016 02:43:32 -0400 Date: Mon, 15 Aug 2016 08:43:28 +0200 From: Daniel Vetter To: Jamie Lentin Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/udl: Ensure channel is selected before using the device. Message-ID: <20160815064328.GZ6232@phenom.ffwll.local> Mail-Followup-To: Jamie Lentin , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1471198775-13610-1-git-send-email-jm@lentin.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471198775-13610-1-git-send-email-jm@lentin.co.uk> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 14, 2016 at 07:19:35PM +0100, Jamie Lentin wrote: > Lift configuration command from udlfb. If this command is not sent, > then the device never outputs a signal, it's status LED is continually > flashing and occasional "udlfb: wait for urb interrupted" messages are > produced. > > Tested with a Rextron VCUD-60 attached to a Thinkpad X201s on Linux 4.7.0 > > Signed-off-by: Jamie Lentin > --- > This ended up in udl_connector_init() since the name suggests it has > something to do with configuring which output to use, although a quick > search through other displaylink drivers didn't shed any light on what > the bytes in set_def_chn actually mean. > > I'm not sure which displaylink chipset the VCUD-60 has, but it's USB ID > is 17e9:0136 if that helps. The vendor descriptor is all 00. > > Cheers, Connector init feels like the wrong place. I'd either put it into udl_driver_load (if it's really just one-time init work). Or into udl_encoder_commit if we need to set this every time we do a modeset, e.g. also after resume. -Daniel > --- > drivers/gpu/drm/udl/udl_connector.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c > index 4709b54..2ee8b38 100644 > --- a/drivers/gpu/drm/udl/udl_connector.c > +++ b/drivers/gpu/drm/udl/udl_connector.c > @@ -16,6 +16,8 @@ > #include > #include "udl_drv.h" > > +#define NR_USB_REQUEST_CHANNEL 0x12 > + > /* dummy connector to just get EDID, > all UDL appear to have a DVI-D */ > > @@ -54,6 +56,26 @@ error: > return NULL; > } > > +/* > + * This is necessary before we can communicate with the display controller. > + */ > +static int udl_select_std_channel(struct udl_device *udl) > +{ > + int ret; > + u8 set_def_chn[] = {0x57, 0xCD, 0xDC, 0xA7, > + 0x1C, 0x88, 0x5E, 0x15, > + 0x60, 0xFE, 0xC6, 0x97, > + 0x16, 0x3D, 0x47, 0xF2}; > + > + ret = usb_control_msg(udl->udev, > + usb_sndctrlpipe(udl->udev, 0), > + NR_USB_REQUEST_CHANNEL, > + (USB_DIR_OUT | USB_TYPE_VENDOR), 0, 0, > + set_def_chn, sizeof(set_def_chn), > + USB_CTRL_SET_TIMEOUT); > + return ret < 0 ? ret : 0; > +} > + > static int udl_get_modes(struct drm_connector *connector) > { > struct udl_device *udl = connector->dev->dev_private; > @@ -139,6 +161,7 @@ static const struct drm_connector_funcs udl_connector_funcs = { > int udl_connector_init(struct drm_device *dev, struct drm_encoder *encoder) > { > struct drm_connector *connector; > + int ret; > > connector = kzalloc(sizeof(struct drm_connector), GFP_KERNEL); > if (!connector) > @@ -147,6 +170,10 @@ int udl_connector_init(struct drm_device *dev, struct drm_encoder *encoder) > drm_connector_init(dev, connector, &udl_connector_funcs, DRM_MODE_CONNECTOR_DVII); > drm_connector_helper_add(connector, &udl_connector_helper_funcs); > > + ret = udl_select_std_channel(connector->dev->dev_private); > + if (ret) > + DRM_ERROR("Selecting channel failed err %x\n", ret); > + > drm_connector_register(connector); > drm_mode_connector_attach_encoder(connector, encoder); > > -- > 2.8.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/udl: Ensure channel is selected before using the device. Date: Mon, 15 Aug 2016 08:43:28 +0200 Message-ID: <20160815064328.GZ6232@phenom.ffwll.local> References: <1471198775-13610-1-git-send-email-jm@lentin.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B0C06E37D for ; Mon, 15 Aug 2016 06:43:32 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id i138so9461543wmf.3 for ; Sun, 14 Aug 2016 23:43:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1471198775-13610-1-git-send-email-jm@lentin.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jamie Lentin Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBBdWcgMTQsIDIwMTYgYXQgMDc6MTk6MzVQTSArMDEwMCwgSmFtaWUgTGVudGluIHdy b3RlOgo+IExpZnQgY29uZmlndXJhdGlvbiBjb21tYW5kIGZyb20gdWRsZmIuIElmIHRoaXMgY29t bWFuZCBpcyBub3Qgc2VudCwKPiB0aGVuIHRoZSBkZXZpY2UgbmV2ZXIgb3V0cHV0cyBhIHNpZ25h bCwgaXQncyBzdGF0dXMgTEVEIGlzIGNvbnRpbnVhbGx5Cj4gZmxhc2hpbmcgYW5kIG9jY2FzaW9u YWwgInVkbGZiOiB3YWl0IGZvciB1cmIgaW50ZXJydXB0ZWQiIG1lc3NhZ2VzIGFyZQo+IHByb2R1 Y2VkLgo+IAo+IFRlc3RlZCB3aXRoIGEgUmV4dHJvbiBWQ1VELTYwIGF0dGFjaGVkIHRvIGEgVGhp bmtwYWQgWDIwMXMgb24gTGludXggNC43LjAKPiAKPiBTaWduZWQtb2ZmLWJ5OiBKYW1pZSBMZW50 aW4gPGptQGxlbnRpbi5jby51az4KPiAtLS0KPiBUaGlzIGVuZGVkIHVwIGluIHVkbF9jb25uZWN0 b3JfaW5pdCgpIHNpbmNlIHRoZSBuYW1lIHN1Z2dlc3RzIGl0IGhhcwo+IHNvbWV0aGluZyB0byBk byB3aXRoIGNvbmZpZ3VyaW5nIHdoaWNoIG91dHB1dCB0byB1c2UsIGFsdGhvdWdoIGEgcXVpY2sK PiBzZWFyY2ggdGhyb3VnaCBvdGhlciBkaXNwbGF5bGluayBkcml2ZXJzIGRpZG4ndCBzaGVkIGFu eSBsaWdodCBvbiB3aGF0Cj4gdGhlIGJ5dGVzIGluIHNldF9kZWZfY2huIGFjdHVhbGx5IG1lYW4u Cj4gCj4gSSdtIG5vdCBzdXJlIHdoaWNoIGRpc3BsYXlsaW5rIGNoaXBzZXQgdGhlIFZDVUQtNjAg aGFzLCBidXQgaXQncyBVU0IgSUQKPiBpcyAxN2U5OjAxMzYgaWYgdGhhdCBoZWxwcy4gVGhlIHZl bmRvciBkZXNjcmlwdG9yIGlzIGFsbCAwMC4KPiAKPiBDaGVlcnMsCgpDb25uZWN0b3IgaW5pdCBm ZWVscyBsaWtlIHRoZSB3cm9uZyBwbGFjZS4gSSdkIGVpdGhlciBwdXQgaXQgaW50bwp1ZGxfZHJp dmVyX2xvYWQgKGlmIGl0J3MgcmVhbGx5IGp1c3Qgb25lLXRpbWUgaW5pdCB3b3JrKS4gT3IgaW50 bwp1ZGxfZW5jb2Rlcl9jb21taXQgaWYgd2UgbmVlZCB0byBzZXQgdGhpcyBldmVyeSB0aW1lIHdl IGRvIGEgbW9kZXNldCwgZS5nLgphbHNvIGFmdGVyIHJlc3VtZS4KLURhbmllbAoKPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL3VkbC91ZGxfY29ubmVjdG9yLmMgfCAyNyArKysrKysrKysrKysrKysr KysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKykKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3VkbC91ZGxfY29ubmVjdG9yLmMgYi9kcml2ZXJzL2dw dS9kcm0vdWRsL3VkbF9jb25uZWN0b3IuYwo+IGluZGV4IDQ3MDliNTQuLjJlZThiMzggMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3VkbC91ZGxfY29ubmVjdG9yLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vdWRsL3VkbF9jb25uZWN0b3IuYwo+IEBAIC0xNiw2ICsxNiw4IEBACj4gICNp bmNsdWRlIDxkcm0vZHJtX2NydGNfaGVscGVyLmg+Cj4gICNpbmNsdWRlICJ1ZGxfZHJ2LmgiCj4g IAo+ICsjZGVmaW5lIE5SX1VTQl9SRVFVRVNUX0NIQU5ORUwgMHgxMgo+ICsKPiAgLyogZHVtbXkg Y29ubmVjdG9yIHRvIGp1c3QgZ2V0IEVESUQsCj4gICAgIGFsbCBVREwgYXBwZWFyIHRvIGhhdmUg YSBEVkktRCAqLwo+ICAKPiBAQCAtNTQsNiArNTYsMjYgQEAgZXJyb3I6Cj4gIAlyZXR1cm4gTlVM TDsKPiAgfQo+ICAKPiArLyoKPiArICogVGhpcyBpcyBuZWNlc3NhcnkgYmVmb3JlIHdlIGNhbiBj b21tdW5pY2F0ZSB3aXRoIHRoZSBkaXNwbGF5IGNvbnRyb2xsZXIuCj4gKyAqLwo+ICtzdGF0aWMg aW50IHVkbF9zZWxlY3Rfc3RkX2NoYW5uZWwoc3RydWN0IHVkbF9kZXZpY2UgKnVkbCkKPiArewo+ ICsJaW50IHJldDsKPiArCXU4IHNldF9kZWZfY2huW10gPSB7MHg1NywgMHhDRCwgMHhEQywgMHhB NywKPiArCQkJICAgIDB4MUMsIDB4ODgsIDB4NUUsIDB4MTUsCj4gKwkJCSAgICAweDYwLCAweEZF LCAweEM2LCAweDk3LAo+ICsJCQkgICAgMHgxNiwgMHgzRCwgMHg0NywgMHhGMn07Cj4gKwo+ICsJ cmV0ID0gdXNiX2NvbnRyb2xfbXNnKHVkbC0+dWRldiwKPiArCQkJICAgICAgdXNiX3NuZGN0cmxw aXBlKHVkbC0+dWRldiwgMCksCj4gKwkJCSAgICAgIE5SX1VTQl9SRVFVRVNUX0NIQU5ORUwsCj4g KwkJCSAgICAgIChVU0JfRElSX09VVCB8IFVTQl9UWVBFX1ZFTkRPUiksIDAsIDAsCj4gKwkJCSAg ICAgIHNldF9kZWZfY2huLCBzaXplb2Yoc2V0X2RlZl9jaG4pLAo+ICsJCQkgICAgICBVU0JfQ1RS TF9TRVRfVElNRU9VVCk7Cj4gKwlyZXR1cm4gcmV0IDwgMCA/IHJldCA6IDA7Cj4gK30KPiArCj4g IHN0YXRpYyBpbnQgdWRsX2dldF9tb2RlcyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9y KQo+ICB7Cj4gIAlzdHJ1Y3QgdWRsX2RldmljZSAqdWRsID0gY29ubmVjdG9yLT5kZXYtPmRldl9w cml2YXRlOwo+IEBAIC0xMzksNiArMTYxLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY29u bmVjdG9yX2Z1bmNzIHVkbF9jb25uZWN0b3JfZnVuY3MgPSB7Cj4gIGludCB1ZGxfY29ubmVjdG9y X2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVy KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ICsJaW50IHJldDsK PiAgCj4gIAljb25uZWN0b3IgPSBremFsbG9jKHNpemVvZihzdHJ1Y3QgZHJtX2Nvbm5lY3Rvciks IEdGUF9LRVJORUwpOwo+ICAJaWYgKCFjb25uZWN0b3IpCj4gQEAgLTE0Nyw2ICsxNzAsMTAgQEAg aW50IHVkbF9jb25uZWN0b3JfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJt X2VuY29kZXIgKmVuY29kZXIpCj4gIAlkcm1fY29ubmVjdG9yX2luaXQoZGV2LCBjb25uZWN0b3Is ICZ1ZGxfY29ubmVjdG9yX2Z1bmNzLCBEUk1fTU9ERV9DT05ORUNUT1JfRFZJSSk7Cj4gIAlkcm1f Y29ubmVjdG9yX2hlbHBlcl9hZGQoY29ubmVjdG9yLCAmdWRsX2Nvbm5lY3Rvcl9oZWxwZXJfZnVu Y3MpOwo+ICAKPiArCXJldCA9IHVkbF9zZWxlY3Rfc3RkX2NoYW5uZWwoY29ubmVjdG9yLT5kZXYt PmRldl9wcml2YXRlKTsKPiArCWlmIChyZXQpCj4gKwkJRFJNX0VSUk9SKCJTZWxlY3RpbmcgY2hh bm5lbCBmYWlsZWQgZXJyICV4XG4iLCByZXQpOwo+ICsKPiAgCWRybV9jb25uZWN0b3JfcmVnaXN0 ZXIoY29ubmVjdG9yKTsKPiAgCWRybV9tb2RlX2Nvbm5lY3Rvcl9hdHRhY2hfZW5jb2Rlcihjb25u ZWN0b3IsIGVuY29kZXIpOwo+ICAKPiAtLSAKPiAyLjguMQo+IAo+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+ IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29m dHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=