From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-renesas-soc-owner@vger.kernel.org>
Received: from kirsty.vergenet.net ([202.4.237.240]:47646 "EHLO
	kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752337AbcHOIQh (ORCPT
	<rfc822;linux-renesas-soc@vger.kernel.org>);
	Mon, 15 Aug 2016 04:16:37 -0400
Date: Mon, 15 Aug 2016 10:16:29 +0200
From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] arm64: dts: renesas: salvator-x: Enable DU
Message-ID: <20160815081628.GG26098@verge.net.au>
References: <1470745752-23738-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
 <CAMuHMdXKVocK4pCF8h6h53263AzFfO9wdmN7wigH5xvLUpTA-g@mail.gmail.com>
 <2249176.5GrCTAfsB5@avalon>
 <2577119.hrVhsDZusv@avalon>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2577119.hrVhsDZusv@avalon>
Sender: linux-renesas-soc-owner@vger.kernel.org
List-ID: <linux-renesas-soc.vger.kernel.org>

On Fri, Aug 12, 2016 at 12:20:51PM +0300, Laurent Pinchart wrote:
> Hi Geert,
> 
> On Thursday 11 Aug 2016 18:37:03 Laurent Pinchart wrote:
> > On Thursday 11 Aug 2016 11:17:17 Geert Uytterhoeven wrote:
> > > On Tue, Aug 9, 2016 at 2:29 PM, Laurent Pinchart wrote:
> > > > Only the VGA output is supported for now.
> > > > 
> > > > Signed-off-by: Laurent Pinchart
> > > > <laurent.pinchart+renesas@ideasonboard.com>
> > > 
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > 
> > > One question below, though...
> > > 
> > > > --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > > > +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > > > @@ -135,6 +135,50 @@
> > > > 
> > > > +&du {
> > > > +       status = "okay";
> > > 
> > > Don't you need pinctrl properties? Or are you relying on initial settings?
> > > 
> > > GPSR initial settings for DU depend on MD[4:1] i.e. SW10[5:8].
> > > The defaults on my board are not 0000, so all DU pins are GPIOs?
> > > IPSR initial settings don't seem to be documented.
> > 
> > pinctrl configuration is needed, but isn't available yet in the sh-pfc
> > driver. I guess I'll just have to bite the bullet and add it :-)
> 
> I've just posted "[PATCH] pinctrl: sh-pfc: r8a7795: Add DU support" and 
> "[PATCH] arm64: dts: renesas: salvator-x: Configure pins for the DU RGB 
> output". As the latter depends on the former which will be merged through a 
> different tree, I propose merging this series already, and delaying "[PATCH] 
> arm64: dts: renesas: salvator-x: Configure pins for the DU RGB output" to the 
> next kernel version.
> 
> Simon, is that fine with you ? If so, could you please pick this series up ?

Yes, I have done so and plan to push it later today.