All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Phil Reid <preid@electromag.com.au>
Cc: dbaryshkov@gmail.com, dwmw2@infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 4/4] power: sbs-battery: Use gpio_desc and sleeping calls for battery detect
Date: Mon, 15 Aug 2016 23:08:51 +0200	[thread overview]
Message-ID: <20160815210850.hd7p6blg7rbuzd7d@earth> (raw)
In-Reply-To: <1469414580-14121-5-git-send-email-preid@electromag.com.au>

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

Hi Phil,

On Mon, Jul 25, 2016 at 10:43:00AM +0800, Phil Reid wrote:
> Switch to using new gpio_desc interface and devm gpio get calls to
> automatically manage gpio resource. Use gpiod_get_value which handles
> active high / low calls.
> 
> If gpio_detect is set then force loading of the driver as it is
> reasonable to assume that the battery may not be present.
> 
> Update the is_present flag immediately in the IRQ.

I queued PATCH 1-3. Please send a new revision for PATCH 4 (this
one) with the following changes: 

 * add the correct gpiod include: <include/linux/gpio/consumer.h>
 * rebase on power-supply's next branch
 * remove battery_detect and battery_detect_present from the
   struct sbs_platform_data and always use the gpiod API. It's
   data can also come from platform data, see
   Documentation/gpio/board.txt and Documentation/gpio/consumer.txt

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-08-15 21:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25  2:42 [PATCH v2 0/4] power: sbs-battery fixup gpio detect irq handling Phil Reid
2016-07-25  2:42 ` [PATCH v2 1/4] power: sbs-battery: Use devm_kzalloc to alloc data Phil Reid
2016-07-25  2:42 ` [PATCH v2 2/4] power: sbs-battery: Request threaded irq and fix dev callback cookie Phil Reid
2016-07-25  2:42 ` [PATCH v2 3/4] power: sbs-battery: Use devm_power_supply_register Phil Reid
2016-07-25  2:43 ` [PATCH v2 4/4] power: sbs-battery: Use gpio_desc and sleeping calls for battery detect Phil Reid
2016-07-30 23:37   ` kbuild test robot
2016-07-31  0:14   ` kbuild test robot
2016-07-31  1:28   ` kbuild test robot
2016-08-15 21:08   ` Sebastian Reichel [this message]
2016-08-16  9:35     ` Phil Reid
2016-08-16 10:26       ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160815210850.hd7p6blg7rbuzd7d@earth \
    --to=sre@kernel.org \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=preid@electromag.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.