From: Tejun Heo <tj@kernel.org>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Chris Diamand" <chris@diamand.org>,
"Stefan Assmann" <sassmann@kpanic.de>,
"Richard Pospesel" <pospeselr@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Takashi Iwai" <tiwai@suse.de>,
patches@opensource.wolfsonmicro.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Input: touchscreen: mc13783_ts: Remove deprecated create_singletheread_workqueue
Date: Mon, 15 Aug 2016 18:53:59 -0400 [thread overview]
Message-ID: <20160815225359.GD3672@mtj.duckdns.org> (raw)
In-Reply-To: <0fec13b74998216009d338fad3e143a3488e0b4a.1471151622.git.bhaktipriya96@gmail.com>
On Sun, Aug 14, 2016 at 10:55:30AM +0530, Bhaktipriya Shridhar wrote:
> The workqueue "workqueue" has a single workitem(&priv->work) and hence
> doesn't require ordering. Also, it is not being used on a memory reclaim
> path. Hence, the singlethreaded workqueue has been replaced with the use
> of system_wq.
>
> System workqueues have been able to handle high level of concurrency
> for a long time now and hence it's not required to have a singlethreaded
> workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
> created with create_singlethread_workqueue(), system_wq allows multiple
> work items to overlap executions even on the same CPU; however, a
> per-cpu workqueue doesn't have any CPU locality or global ordering
> guarantee unless the target CPU is explicitly specified and thus the
> increase of local concurrency shouldn't make any difference.
>
> Workitem is sync cancelled in mc13783_ts_remove() to ensure that there
> are no workitems pending when the driver is disconnected.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2016-08-15 22:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-14 5:19 [PATCH 0/3] Remove usages of deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-08-14 5:23 ` [PATCH 1/3] Input: psmouse: Remove deprecated create_singletheread_workqueue Bhaktipriya Shridhar
2016-08-15 22:53 ` Tejun Heo
2016-08-23 20:51 ` Dmitry Torokhov
2016-08-14 5:25 ` [PATCH 2/3] Input: touchscreen: mc13783_ts: " Bhaktipriya Shridhar
2016-08-15 22:53 ` Tejun Heo [this message]
2016-08-23 20:53 ` Dmitry Torokhov
2016-08-14 5:26 ` [PATCH 3/3] Input: wm97xx: " Bhaktipriya Shridhar
2016-08-15 8:53 ` Charles Keepax
2016-08-15 22:53 ` Tejun Heo
2016-08-23 21:01 ` Dmitry Torokhov
2016-08-23 21:02 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815225359.GD3672@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=bhaktipriya96@gmail.com \
--cc=chris@diamand.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=lars@metafoo.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=pospeselr@gmail.com \
--cc=sassmann@kpanic.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.