On Sun, Aug 14, 2016 at 06:17:24PM +0200, Christoph Hellwig wrote: >Snipping the long contest: > >I think there are three observations here: > > (1) removing the mark_page_accessed (which is the only significant > change in the parent commit) hurts the > aim7/1BRD_48G-xfs-disk_rr-3000-performance/ivb44 test. > I'd still rather stick to the filemap version and let the > VM people sort it out. How do the numbers for this test > look for XFS vs say ext4 and btrfs? Here is a basic comparison of the 3 filesystems based on 99091700 (" Merge tag 'nfs-for-4.8-2' of git://git.linux-nfs.org/projects/trondmy/linux-nfs"). % compare -a -g 99091700659f4df965e138b38b4fa26a29b7eade -d fs xfs ext4 btrfs xfs ext4 btrfs testcase/testparams/testbox ---------------- -------------------------- -------------------------- --------------------------- %stddev change %stddev change %stddev \ | \ | \ 193335 -27% 141400 -100% 8 GEO-MEAN aim7.jobs-per-min 267649 ± 3% -51% 130085 aim7/1BRD_48G-disk_cp-3000-performance/ivb44 485217 ± 3% 402% 2434088 ± 3% 350% 2184471 ± 4% aim7/1BRD_48G-disk_rd-9000-performance/ivb44 360286 -64% 130351 aim7/1BRD_48G-disk_rr-3000-performance/ivb44 338114 -78% 73280 aim7/1BRD_48G-disk_rw-3000-performance/ivb44 60130 ± 5% 361% 277035 aim7/1BRD_48G-disk_src-3000-performance/ivb44 403144 -68% 127584 aim7/1BRD_48G-disk_wrt-3000-performance/ivb44 26327 -60% 10571 aim7/1BRD_48G-sync_disk_rw-600-performance/ivb44 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 2652 -96% 118 -82% 468 GEO-MEAN fsmark.files_per_sec 393 ± 4% -6% 368 ± 3% 10% 433 ± 5% fsmark/1x-1t-1BRD_48G-4M-40G-NoSync-performance/ivb44 200 -4% 191 -7% 185 ± 6% fsmark/1x-1t-1BRD_48G-4M-40G-fsyncBeforeClose-performance/ivb44 1583 ± 3% -29% 1130 -31% 1088 fsmark/1x-64t-1BRD_48G-4M-40G-fsyncBeforeClose-performance/ivb44 21363 59% 33958 fsmark/8-1SSD-16-9B-48G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 11033 -17% 9117 fsmark/8-1SSD-4-8K-24G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 11833 12% 13234 fsmark/8-1SSD-4-9B-16G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 2381976 -100% 6598 -96% 100973 GEO-MEAN fsmark.app_overhead 564520 ± 7% 21% 681192 ± 3% 63% 919364 ± 3% fsmark/1x-64t-1BRD_48G-4M-40G-NoSync-performance/ivb44 860074 ± 5% 112% 1820590 ± 14% 47% 1262443 ± 3% fsmark/1x-64t-1BRD_48G-4M-40G-fsyncBeforeClose-performance/ivb44 12232633 -18% 10085199 fsmark/8-1SSD-16-9B-48G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 3143334 -11% 2784178 fsmark/8-1SSD-4-8K-24G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 4107347 -21% 3248210 fsmark/8-1SSD-4-9B-16G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 Thanks, Fengguang --- Some less important numbers. xfs ext4 btrfs ---------------- -------------------------- -------------------------- 1314 222% 4225 -100% 2 GEO-MEAN aim7.time.system_time 1491 ± 6% 302% 6004 aim7/1BRD_48G-disk_cp-3000-performance/ivb44 4786 ± 3% -89% 502 ± 7% -87% 632 ± 7% aim7/1BRD_48G-disk_rd-9000-performance/ivb44 756 689% 5971 aim7/1BRD_48G-disk_rr-3000-performance/ivb44 891 1146% 11108 aim7/1BRD_48G-disk_rw-3000-performance/ivb44 940 ± 5% 70% 1598 aim7/1BRD_48G-disk_src-3000-performance/ivb44 599 925% 6148 aim7/1BRD_48G-disk_wrt-3000-performance/ivb44 2496 390% 12225 aim7/1BRD_48G-sync_disk_rw-600-performance/ivb44 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 154597 185% 440025 GEO-MEAN aim7.time.minor_page_faults 156203 144% 381038 aim7/1BRD_48G-disk_cp-3000-performance/ivb44 155952 132% 362294 ± 3% aim7/1BRD_48G-disk_rr-3000-performance/ivb44 157550 266% 577044 aim7/1BRD_48G-disk_rw-3000-performance/ivb44 153880 152% 387212 aim7/1BRD_48G-disk_wrt-3000-performance/ivb44 149531 ± 5% 258% 534809 ± 4% aim7/1BRD_48G-sync_disk_rw-600-performance/ivb44 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 86.94 37% 119.10 -98% 1.59 GEO-MEAN aim7.time.elapsed_time 67.56 ± 3% 105% 138.61 aim7/1BRD_48G-disk_cp-3000-performance/ivb44 112.15 ± 3% -80% 22.93 ± 3% -77% 25.48 ± 4% aim7/1BRD_48G-disk_rd-9000-performance/ivb44 50.19 176% 138.32 aim7/1BRD_48G-disk_rr-3000-performance/ivb44 53.46 360% 245.91 aim7/1BRD_48G-disk_rw-3000-performance/ivb44 300.63 ± 5% -78% 65.30 aim7/1BRD_48G-disk_src-3000-performance/ivb44 44.88 215% 141.35 aim7/1BRD_48G-disk_wrt-3000-performance/ivb44 136.82 149% 340.59 aim7/1BRD_48G-sync_disk_rw-600-performance/ivb44 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 22.55 27% 28.54 GEO-MEAN aim7.time.user_time 18.74 46% 27.27 aim7/1BRD_48G-disk_cp-3000-performance/ivb44 28.71 28% 36.88 aim7/1BRD_48G-disk_rr-3000-performance/ivb44 29.59 38% 40.74 aim7/1BRD_48G-disk_rw-3000-performance/ivb44 41.42 ± 4% -50% 20.90 aim7/1BRD_48G-disk_src-3000-performance/ivb44 10.93 61% 17.61 aim7/1BRD_48G-disk_wrt-3000-performance/ivb44 18.26 96% 35.85 aim7/1BRD_48G-sync_disk_rw-600-performance/ivb44 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 1171009 -44% 660859 -100% 4 GEO-MEAN aim7.time.voluntary_context_switches 325355 -7% 303228 aim7/1BRD_48G-disk_cp-3000-performance/ivb44 58321 ± 8% -48% 30407 -44% 32487 ± 3% aim7/1BRD_48G-disk_rd-9000-performance/ivb44 437880 -37% 275709 aim7/1BRD_48G-disk_rr-3000-performance/ivb44 395047 31% 518201 aim7/1BRD_48G-disk_rw-3000-performance/ivb44 31067301 -93% 2034955 ± 5% aim7/1BRD_48G-disk_src-3000-performance/ivb44 506749 -38% 315597 aim7/1BRD_48G-disk_wrt-3000-performance/ivb44 58429810 11% 65070475 aim7/1BRD_48G-sync_disk_rw-600-performance/ivb44 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 41445 658% 314065 -100% 4 GEO-MEAN aim7.time.involuntary_context_switches 21627 ± 5% 3118% 695989 aim7/1BRD_48G-disk_cp-3000-performance/ivb44 594383 ± 5% -96% 25928 ± 7% -94% 38082 ± 11% aim7/1BRD_48G-disk_rd-9000-performance/ivb44 12980 5128% 678629 aim7/1BRD_48G-disk_rr-3000-performance/ivb44 14729 10572% 1571856 aim7/1BRD_48G-disk_rw-3000-performance/ivb44 5894 ± 3% 249% 20595 ± 8% aim7/1BRD_48G-disk_src-3000-performance/ivb44 8950 7842% 710852 aim7/1BRD_48G-disk_wrt-3000-performance/ivb44 1620035 -34% 1069492 aim7/1BRD_48G-sync_disk_rw-600-performance/ivb44 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 132117 -100% 216 -99% 990 GEO-MEAN fsmark.time.involuntary_context_switches 14651 -99% 86 ± 3% -99% 120 ± 9% fsmark/1x-1t-1BRD_48G-4M-40G-fsyncBeforeClose-performance/ivb44 553 413% 2840 ± 3% 8078% 45278 ± 31% fsmark/1x-64t-1BRD_48G-4M-40G-NoSync-performance/ivb44 19895 ± 3% -33% 13242 487% 116776 ± 3% fsmark/1x-64t-1BRD_48G-4M-40G-fsyncBeforeClose-performance/ivb44 6206551 -99% 31906 fsmark/8-1SSD-16-9B-48G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 1992225 -100% 1236 ± 5% fsmark/8-1SSD-4-8K-24G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 2664982 -100% 1202 ± 10% fsmark/8-1SSD-4-9B-16G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 1755485 -100% 3248 -93% 120902 GEO-MEAN fsmark.time.voluntary_context_switches 542900 -98% 10270 -98% 10291 fsmark/1x-1t-1BRD_48G-4M-40G-fsyncBeforeClose-performance/ivb44 36634 ± 6% -17% 30317 3893% 1462650 ± 9% fsmark/1x-64t-1BRD_48G-4M-40G-NoSync-performance/ivb44 162300 ± 15% -55% 72808 89% 306208 fsmark/1x-64t-1BRD_48G-4M-40G-fsyncBeforeClose-performance/ivb44 58499255 -11% 51789210 fsmark/8-1SSD-16-9B-48G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 10792062 168% 28969245 fsmark/8-1SSD-4-8K-24G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 14361647 63% 23390858 fsmark/8-1SSD-4-9B-16G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 391 -98% 7 -88% 47 GEO-MEAN fsmark.time.elapsed_time 591 -37% 371 fsmark/8-1SSD-16-9B-48G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 285 21% 345 fsmark/8-1SSD-4-8K-24G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 354 -11% 317 fsmark/8-1SSD-4-9B-16G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 294.98 -88% 36.23 -51% 145.31 GEO-MEAN fsmark.time.system_time 45.16 ± 5% 157% 116.15 820% 415.73 ± 7% fsmark/1x-64t-1BRD_48G-4M-40G-NoSync-performance/ivb44 262.79 ± 4% 29% 338.49 21% 316.76 ± 4% fsmark/1x-64t-1BRD_48G-4M-40G-fsyncBeforeClose-performance/ivb44 1419.35 12% 1587.76 fsmark/8-1SSD-16-9B-48G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 320.95 124% 719.99 fsmark/8-1SSD-4-8K-24G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 413.11 65% 683.20 fsmark/8-1SSD-4-9B-16G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 222 -68% 70 -27% 161 GEO-MEAN fsmark.time.percent_of_cpu_this_job_got 91 ± 4% 9% 99 7% 97 fsmark/1x-1t-1BRD_48G-4M-40G-NoSync-performance/ivb44 95 3% 98 3% 98 fsmark/1x-1t-1BRD_48G-4M-40G-fsyncBeforeClose-performance/ivb44 214 ± 3% 152% 540 807% 1940 ± 9% fsmark/1x-64t-1BRD_48G-4M-40G-NoSync-performance/ivb44 3938 -7% 3668 -17% 3286 fsmark/1x-64t-1BRD_48G-4M-40G-fsyncBeforeClose-performance/ivb44 253 75% 443 fsmark/8-1SSD-16-9B-48G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 118 80% 213 fsmark/8-1SSD-4-8K-24G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 123 80% 221 fsmark/8-1SSD-4-9B-16G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 15893 -96% 649 46% 23186 GEO-MEAN fsmark.time.minor_page_faults 10532 34% 14137 125% 23697 ± 5% fsmark/1x-64t-1BRD_48G-4M-40G-NoSync-performance/ivb44 17053 14% 19388 9% 18557 fsmark/1x-64t-1BRD_48G-4M-40G-fsyncBeforeClose-performance/ivb44 22352 ± 34% 27% 28346 ± 28% fsmark/8-1SSD-4-8K-24G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 xfs ext4 btrfs ---------------- -------------------------- -------------------------- 30857819 -100% 5089 405% 1.559e+08 GEO-MEAN fsmark.time.file_system_outputs 6400000 ± 50% 25% 8000000 2051% 1.377e+08 fsmark/1x-1t-1BRD_32G-4K-4G-fsyncBeforeClose-1fpd-performance/ivb43 83886080 83886080 85633962 fsmark/1x-1t-1BRD_48G-4M-40G-fsyncBeforeClose-performance/ivb44 50331648 352% 2.277e+08 fsmark/8-1SSD-4-8K-24G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4 33554432 555% 2.199e+08 fsmark/8-1SSD-4-9B-16G-fsyncBeforeClose-16d-256fpd-performance/lkp-hsw-ep4