From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v2 0/3] TPM2.0: Added eventlog support for TPM2.0 Date: Tue, 16 Aug 2016 22:48:53 +0300 Message-ID: <20160816194853.GA26364@intel.com> References: <1470771295-15680-1-git-send-email-nayna@linux.vnet.ibm.com> <20160810113243.GF13929@intel.com> <20160810171900.GA11543@intel.com> <57AC5802.1090109@linux.vnet.ibm.com> <20160811125818.GA9303@intel.com> <57ADC1C0.4030406@linux.vnet.ibm.com> <20160815212612.GC25212@intel.com> <57B36698.7040904@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <57B36698.7040904-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Nayna Cc: David Heller , tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, George Wilson List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Aug 17, 2016 at 12:46:40AM +0530, Nayna wrote: > Hi Jarkko, > > > > On 08/16/2016 02:56 AM, Jarkko Sakkinen wrote: > >On Fri, Aug 12, 2016 at 06:02:00PM +0530, Nayna wrote: > >>>>Jarkko, Please let me know if it doesn't answer your question. > >>> > >>>1. EFI does not pass the log by any means AFAIK before a boot loader > >>> calls ExitBootServices(). > >> > >>So, is current TCPA support only for TPM1.2 ? > > > >TCPA ACPI table is only available for TPM 1.2. > > > >TPM2 ACPI table does not provide a memory ref for the event log. > > > >>#2, TCG Spec http://www.trustedcomputinggroup.org/wp-content/uploads/EFI-Protocol-Specification-rev13-160330final.pdf > >>talks about > >>EFI_TCG2_PROTOCOL.GetEventLog (Section 6.5), what is that supposed to do ? > > > >Direct quote from your reference: > > > >"Boot Service Drivers are terminated when ExitBootServices() is called > >and all memory resources consumed by the Boot Services Drivers are > >released for use in the operating system environment." > > Thanks Jarkko, I understand now what you meant. > > > >>>2. I do not have any system with TPM2 that uses DT. And as I stated > >>> before you didn't have any reference where you derived the DT > >>> node fields. > >> > >>As per Device Tree, so this is the new node introduced in the device tree to > >>support TPM. And the fields are defined maintaining the requirements from > >>ePAPR specification. > > > >What is ePAPR specification? Can you provide a reference? > > PowerPC systems are based on device tree and derive that from ePAPR > specification, link below for ePAPR specification.. > > https://www.power.org/documentation/power-org-standard-for-embedded-power-architecture-platform-requirements-epapr-v1-1-2/ Thanks. I'll check that through when I review the next version. PS. Use subsystem prefix in your next patches (tpm: not TPM2.0:) /Jarkko ------------------------------------------------------------------------------