From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753428AbcHPVLT (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Aug 2016 17:11:19 -0400
Received: from mail.skyhub.de ([78.46.96.112]:35904 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752325AbcHPVLR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Aug 2016 17:11:17 -0400
Date: Tue, 16 Aug 2016 23:01:08 +0200
From: Borislav Petkov <bp@alien8.de>
To: Kees Cook <keescook@chromium.org>
Cc: Brian Gerst <brgerst@gmail.com>, Baoquan He <bhe@redhat.com>,
        Yinghai Lu <yinghai@kernel.org>, Juergen Gross <jgross@suse.com>,
        Thomas Garnier <thgarnie@google.com>,
        Andy Lutomirski <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Alexander Kuleshov <kuleshovmail@gmail.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Stephen Smalley <sds@tycho.nsa.gov>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Joerg Roedel <jroedel@suse.de>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        Mark Salter <msalter@redhat.com>, Borislav Petkov <bp@suse.de>,
        Jonathan Corbet <corbet@lwn.net>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Xiao Guangrong <guangrong.xiao@linux.intel.com>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
        Ingo Molnar <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Toshi Kani <toshi.kani@hpe.com>,
        Alexander Popov <alpopov@ptsecurity.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jan Beulich <JBeulich@suse.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>, Dave Young <dyoung@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dmitry Vyukov <dvyukov@google.com>, Lv Zheng <lv.zheng@intel.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        "linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory
 regions
Message-ID: <20160816210108.GA6332@nazgul.tnic>
References: <1466556426-32664-7-git-send-email-keescook@chromium.org>
 <tip-021182e52fe01c1f7b126f97fd6ba048dc4234fd@git.kernel.org>
 <CAMzpN2h-CV2e1F_8u5GYkwaFkzoERfi9a83DEO7OeKEJB0RYTg@mail.gmail.com>
 <20160814232657.GA10704@x1.redhat.com>
 <CAMzpN2ixxOEonfgDdFRkB8P9Zb6eiFJF4Vx_HRMgWhm-7wK1hg@mail.gmail.com>
 <20160816134205.GB11106@nazgul.tnic>
 <20160816134928.GC11106@nazgul.tnic>
 <20160816155412.GB15004@nazgul.tnic>
 <20160816175008.GA10538@nazgul.tnic>
 <CAGXu5jLC4XzQyaw4C7ohPimmQu-eddixN_TW9HCnGY4ZU_AyRg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAGXu5jLC4XzQyaw4C7ohPimmQu-eddixN_TW9HCnGY4ZU_AyRg@mail.gmail.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 16, 2016 at 12:49:52PM -0700, Kees Cook wrote:
> Am I misreading this?

No you're not.

> Shouldn't it be:
> 
>        cont = container;
> #ifdef CONFIG_RANDOMIZE_MEMORY
>        cont += PAGE_OFFSET - __PAGE_OFFSET_BASE;
> #endif
> 
> (otherwise cont is undefined in the RANDOMIZE_MEMORY=n case?)

Thanks for catching this Kees, I'll send a new version in the morning.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--