From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752916AbcHQNcW (ORCPT ); Wed, 17 Aug 2016 09:32:22 -0400 Received: from mga09.intel.com ([134.134.136.24]:41299 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752554AbcHQNcV (ORCPT ); Wed, 17 Aug 2016 09:32:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,529,1464678000"; d="scan'208";a="1026996271" Date: Wed, 17 Aug 2016 16:32:04 +0300 From: Heikki Krogerus To: Felipe Balbi Cc: Greg KH , Guenter Roeck , Oliver Neukum , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v5 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Message-ID: <20160817133204.GS9927@kuha.fi.intel.com> References: <1471430081-12860-1-git-send-email-heikki.krogerus@linux.intel.com> <1471430081-12860-3-git-send-email-heikki.krogerus@linux.intel.com> <87d1l77e0r.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d1l77e0r.fsf@linux.intel.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2016 at 03:53:24PM +0300, Felipe Balbi wrote: > Heikki Krogerus writes: > > [...] > > > +static struct platform_driver wcove_typec_driver = { > > + .driver = { > > + .name = "bxt_wcove_usbc", > > + }, > > + .probe = wcove_typec_probe, > > + .remove = wcove_typec_remove, > > +}; > > + > > +module_platform_driver(wcove_typec_driver); > > + > > +MODULE_AUTHOR("Intel Corporation"); > > +MODULE_LICENSE("GPL v2"); > > +MODULE_DESCRIPTION("WhiskeyCove PMIC USB Type-C PHY driver"); > > you need to add: > > MODULE_ALIAS("platform:bxt_wcove_usbc"); > > otherwise this won't probe() automagically. I'll fix it. Thanks, -- heikki