From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752941AbcHQPzf (ORCPT ); Wed, 17 Aug 2016 11:55:35 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:59316 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752286AbcHQPzb (ORCPT ); Wed, 17 Aug 2016 11:55:31 -0400 Date: Wed, 17 Aug 2016 17:54:52 +0200 From: Pavel Machek To: Rob Herring Cc: Sebastian Reichel , Tony Lindgren , Mark Rutland , Marcel Holtmann , Greg Kroah-Hartman , Jiri Slaby , Ville Tervo , Filip =?utf-8?Q?Matijevi=C4=87?= , Aaro Koskinen , Pali =?iso-8859-1?Q?Roh=E1r?= , Ivaylo Dimitrov , linux-bluetooth@vger.kernel.org, "linux-serial@vger.kernel.org" , linux-omap , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC 3/7] dt: bindings: Add nokia-bluetooth Message-ID: <20160817155452.GA14957@amd> References: <1471058078-5579-1-git-send-email-sre@kernel.org> <1471058078-5579-4-git-send-email-sre@kernel.org> <20160816135155.GA20948@rob-hp-laptop> <20160816232855.qgempm64zgp36ufd@earth> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > >> > + - reset-gpios: Should specify the gpio for bluetooth reset > >> > + - host-wakeup-gpios: Should specify the gpio for host wakeup > >> > >> Should be interrupt instead? > > > > Yes this is mostly an interrupt, but I need to read the current > > line state. > > When? If the interrupt is level triggered, then you can get the line > state based on whether you get an interrupt or not. If this needs to > be a wakeup source (see the wakeup source binding), then it needs to > be an interrupt. What is wrong with GPIO? It is simply a piece of wire. Yes, we'll configure it to generate an interrupt, or maybe not, but that's software detail, the device tree just should not care.... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [RFC 3/7] dt: bindings: Add nokia-bluetooth Date: Wed, 17 Aug 2016 17:54:52 +0200 Message-ID: <20160817155452.GA14957@amd> References: <1471058078-5579-1-git-send-email-sre@kernel.org> <1471058078-5579-4-git-send-email-sre@kernel.org> <20160816135155.GA20948@rob-hp-laptop> <20160816232855.qgempm64zgp36ufd@earth> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Sebastian Reichel , Tony Lindgren , Mark Rutland , Marcel Holtmann , Greg Kroah-Hartman , Jiri Slaby , Ville Tervo , Filip =?utf-8?Q?Matijevi=C4=87?= , Aaro Koskinen , Pali =?iso-8859-1?Q?Roh=E1r?= , Ivaylo Dimitrov , linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-omap , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi! > >> > + - reset-gpios: Should specify the gpio for bluetooth reset > >> > + - host-wakeup-gpios: Should specify the gpio for host wakeup > >> > >> Should be interrupt instead? > > > > Yes this is mostly an interrupt, but I need to read the current > > line state. > > When? If the interrupt is level triggered, then you can get the line > state based on whether you get an interrupt or not. If this needs to > be a wakeup source (see the wakeup source binding), then it needs to > be an interrupt. What is wrong with GPIO? It is simply a piece of wire. Yes, we'll configure it to generate an interrupt, or maybe not, but that's software detail, the device tree just should not care.... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html