From: Stephen Boyd <sboyd@codeaurora.org>
To: Kees Cook <keescook@chromium.org>
Cc: "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Laura Abbott <labbott@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Daniel Micay <danielmicay@gmail.com>,
Joe Perches <joe@perches.com>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Josh Triplett <josh@joshtriplett.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Dan Williams <dan.j.williams@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, Josef Bacik <jbacik@fb.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Tejun Heo <tj@kernel.org>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Dmitry Vyukov <dvyukov@google.com>,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption
Date: Wed, 17 Aug 2016 13:17:36 -0700 [thread overview]
Message-ID: <20160817201736.GB361@codeaurora.org> (raw)
In-Reply-To: <1471393229-27182-1-git-send-email-keescook@chromium.org>
On 08/16, Kees Cook wrote:
> This adds a CONFIG to trigger BUG()s when the kernel encounters
> unexpected data structure integrity as currently detected with
> CONFIG_DEBUG_LIST.
>
> Specifically list operations have been a target for widening flaws to gain
> "write anywhere" primitives for attackers, so this also consolidates the
> debug checking to avoid code and check duplication (e.g. RCU list debug
> was missing a check that got added to regular list debug). It also stops
> manipulations when corruption is detected, since worsening the corruption
> makes no sense. (Really, everyone should build with CONFIG_DEBUG_LIST
> since the checks are so inexpensive.)
>
> This is mostly a refactoring of similar code from PaX and Grsecurity,
> along with MSM kernel changes by Stephen Boyd.
Which commit in the MSM kernel from me? I wonder if perhaps
you're thinking of a patch from Syed Rameez Mustafa like commit
1c014f321e6d67f47 in the msm-3.4 kernel.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Kees Cook <keescook@chromium.org>
Cc: "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Laura Abbott <labbott@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Daniel Micay <danielmicay@gmail.com>,
Joe Perches <joe@perches.com>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Josh Triplett <josh@joshtriplett.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Dan Williams <dan.j.williams@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, Josef Bacik <jbacik@fb.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Tejun Heo <tj@kernel.org>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Dmitry Vyukov <dvyukov@google.com>,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption
Date: Wed, 17 Aug 2016 13:17:36 -0700 [thread overview]
Message-ID: <20160817201736.GB361@codeaurora.org> (raw)
In-Reply-To: <1471393229-27182-1-git-send-email-keescook@chromium.org>
On 08/16, Kees Cook wrote:
> This adds a CONFIG to trigger BUG()s when the kernel encounters
> unexpected data structure integrity as currently detected with
> CONFIG_DEBUG_LIST.
>
> Specifically list operations have been a target for widening flaws to gain
> "write anywhere" primitives for attackers, so this also consolidates the
> debug checking to avoid code and check duplication (e.g. RCU list debug
> was missing a check that got added to regular list debug). It also stops
> manipulations when corruption is detected, since worsening the corruption
> makes no sense. (Really, everyone should build with CONFIG_DEBUG_LIST
> since the checks are so inexpensive.)
>
> This is mostly a refactoring of similar code from PaX and Grsecurity,
> along with MSM kernel changes by Stephen Boyd.
Which commit in the MSM kernel from me? I wonder if perhaps
you're thinking of a patch from Syed Rameez Mustafa like commit
1c014f321e6d67f47 in the msm-3.4 kernel.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-08-17 20:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 0:20 [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption Kees Cook
2016-08-17 0:20 ` [kernel-hardening] " Kees Cook
2016-08-17 0:20 ` [PATCH v2 1/5] list: Split list_add() debug checking into separate function Kees Cook
2016-08-17 0:20 ` [kernel-hardening] " Kees Cook
2016-08-17 13:16 ` Steven Rostedt
2016-08-17 13:16 ` [kernel-hardening] " Steven Rostedt
2016-08-17 0:20 ` [PATCH v2 2/5] rculist: Consolidate DEBUG_LIST for list_add_rcu() Kees Cook
2016-08-17 0:20 ` [kernel-hardening] " Kees Cook
2016-08-17 0:20 ` [PATCH v2 3/5] list: Split list_del() debug checking into separate function Kees Cook
2016-08-17 0:20 ` [kernel-hardening] " Kees Cook
2016-08-17 0:20 ` [PATCH v2 4/5] bug: Provide toggle for BUG on data corruption Kees Cook
2016-08-17 0:20 ` [kernel-hardening] " Kees Cook
2016-08-17 0:26 ` Joe Perches
2016-08-17 0:26 ` [kernel-hardening] " Joe Perches
2016-08-17 3:39 ` Kees Cook
2016-08-17 3:39 ` [kernel-hardening] " Kees Cook
2016-08-17 13:20 ` Steven Rostedt
2016-08-17 13:20 ` [kernel-hardening] " Steven Rostedt
2016-08-17 0:20 ` [PATCH v2 5/5] lkdtm: Add tests for struct list corruption Kees Cook
2016-08-17 0:20 ` [kernel-hardening] " Kees Cook
2016-08-17 0:55 ` [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption Henrique de Moraes Holschuh
2016-08-17 0:55 ` [kernel-hardening] " Henrique de Moraes Holschuh
2016-08-17 3:37 ` Kees Cook
2016-08-17 3:37 ` [kernel-hardening] " Kees Cook
2016-08-17 20:17 ` Stephen Boyd [this message]
2016-08-17 20:17 ` Stephen Boyd
2016-08-17 21:11 ` Kees Cook
2016-08-17 21:11 ` [kernel-hardening] " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817201736.GB361@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=dan.j.williams@intel.com \
--cc=danielmicay@gmail.com \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbacik@fb.com \
--cc=jiangshanlai@gmail.com \
--cc=joe@perches.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nikolay@cumulusnetworks.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.