From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753474AbcHQVUU (ORCPT ); Wed, 17 Aug 2016 17:20:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56528 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752837AbcHQVUT (ORCPT ); Wed, 17 Aug 2016 17:20:19 -0400 Date: Wed, 17 Aug 2016 16:20:16 -0500 From: Josh Poimboeuf To: Brian Gerst Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , "H. Peter Anvin" , Linus Torvalds , Denys Vlasenko , Andy Lutomirski , Borislav Petkov , Thomas Gleixner Subject: Re: [PATCH v3 0/7] x86: Rewrite switch_to() Message-ID: <20160817212016.dqjcb7nqboalgjck@treble> References: <1471106302-10159-1-git-send-email-brgerst@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1471106302-10159-1-git-send-email-brgerst@gmail.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 17 Aug 2016 21:20:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 13, 2016 at 12:38:15PM -0400, Brian Gerst wrote: > This patch set simplifies the switch_to() code, by moving the stack switch > code out of line into an asm stub before calling __switch_to(). This ends > up being more readable, and using the C calling convention instead of > clobbering all registers improves code generation. It also allows newly > forked processes to construct a special stack frame to seamlessly flow > to ret_from_fork, instead of using a test and branch, or an unbalanced > call/ret. > > Changes from v2: > - Updated comments around kernel threads being uncommon for fork, etc. > - Removed STACK_FRAME_NON_STANDARD annotation from __schedule() per Josh Poimboeuf > - A few minor cleanups added There are a few minor conflicts with my x86 stack dump patch set, but for the most part they should be orthogonal. For the series: Reviewed-by: Josh Poimboeuf -- Josh