All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Anisse Astier <anisse@astier.eu>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Yu C Chen <yu.c.chen@intel.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe
Date: Thu, 18 Aug 2016 16:58:13 +0300	[thread overview]
Message-ID: <20160818135813.GJ30827@lahna.fi.intel.com> (raw)
In-Reply-To: <CALUN=qJ_KEXXD4T11h3Xxjxx9LExBnzevVKGQ1K=XGZn-SS_rg@mail.gmail.com>

On Thu, Aug 18, 2016 at 03:52:57PM +0200, Anisse Astier wrote:
> On Thu, Aug 18, 2016 at 2:13 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Wed, Aug 17, 2016 at 03:42:58PM +0200, Anisse Astier wrote:
> >> pin 25 (GPIO_SUS6) GPIO ctrl0 0xec918201 ctrl1 0x05c00001
> >
> > It is this one (GPIO_SUS6).
> >
> > I wonder if we can relax the driver so that it only masks pins which are
> > not configured to generate interrupts by the BIOS. I quickly tried
> > following on one Braswell machine and it did not generate spurious
> > interrupts.
> >
> > Can you check if this works for you?
> 
> I tried it, your patch is working. It gives the same result as not
> clearing the north community. I receive the ACPI events.

OK, thanks for testing.

I'll make a formal patch and submit it with you CC'd. Let's hope it will
not break anything :)

  reply	other threads:[~2016-08-18 13:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22  7:56 [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Mika Westerberg
2015-06-01  9:23 ` Mika Westerberg
2015-06-02 13:53   ` Linus Walleij
2015-06-02 14:15     ` Mika Westerberg
2015-07-29  8:51       ` João Paulo Rechi Vita
2016-08-16 16:12       ` Anisse Astier
2016-08-17  8:13         ` Mika Westerberg
2016-08-17 13:42           ` Anisse Astier
2016-08-18 12:13             ` Mika Westerberg
2016-08-18 13:52               ` Anisse Astier
2016-08-18 13:58                 ` Mika Westerberg [this message]
2016-09-08 10:13                   ` Phidias Chiang
2016-09-08 10:24                     ` Mika Westerberg
2016-09-08 16:28                       ` Phidias Chiang
2016-09-09  6:18                         ` Mika Westerberg
2016-09-09  8:23                           ` Phidias Chiang
2016-09-09  8:58                             ` Mika Westerberg
2016-09-11  8:05                               ` Mika Westerberg
2016-09-12  6:56                                 ` Phidias Chiang
2016-09-12  9:04                                   ` Mika Westerberg
2016-09-12 13:04                                     ` Phidias Chiang
2016-09-12 13:11                                       ` Mika Westerberg
2016-09-13  9:18                                         ` Linus Walleij
2016-09-13  9:33                                           ` Mika Westerberg
2016-09-13 12:22                                             ` Linus Walleij
2016-09-13 12:52                                               ` Mika Westerberg
2016-09-13 20:57                                                 ` Linus Walleij
2016-09-14  8:26                                                   ` Mika Westerberg
2016-09-14 12:46                                                     ` Linus Walleij
2016-09-14 15:12                                                       ` Mika Westerberg
2016-09-15 12:39                                                         ` Linus Walleij
2016-09-15 15:42                                                           ` Mika Westerberg
2016-09-15 15:52                                                           ` [PATCH 1/2] gpiolib: Add possibility to mask which GPIOs are added to IRQ domain Mika Westerberg
2016-09-15 15:52                                                             ` [PATCH 2/2] pinctrl: cherryview: Do not add all southwest and north GPIOs " Mika Westerberg
2016-09-15 16:07                                                             ` [PATCH 1/2] gpiolib: Add possibility to mask which GPIOs are added " Marc Zyngier
2016-09-15 18:12                                                               ` Mika Westerberg
2016-09-15 18:50                                                                 ` Thomas Gleixner
2016-09-18 11:16                                                             ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160818135813.GJ30827@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=anisse@astier.eu \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.