From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vishal Verma Subject: Re: [PATCH v2 0/8] nvdimm: hotplug support Date: Thu, 18 Aug 2016 12:54:39 -0600 Message-ID: <20160818185438.GA7799@omniknight.lm.intel.com> References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Xiao Guangrong , ehabkost@redhat.com, KVM list , "Michael S. Tsirkin" , Gleb Natapov , mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, Igor Mammedov , Paolo Bonzini , rth@twiddle.net To: Dan Williams Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org On 08/18, Dan Williams wrote: > [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] > > On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong > wrote: > > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > > rx queue siz) on pci branch of Michael's git tree and can be found at: > > https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2 > > > > Changelog in v2: > > Fixed signed integer overflow pointed out by Stefan Hajnoczi > > > > This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug, > > for example, a new nvdimm device can be plugged as follows: > > object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3 > > device_add nvdimm,id=nvdimm3,memdev=mem3 > > > > and unplug it as follows: > > device_del nvdimm3 > > object_del mem3 > > Did you test this against the Linux NFIT hotplug support? We just > found that the Linux driver is not properly registering for ACPI0012 > event notification. Is a notification sent on a 'device_add' event? I've just sent out a patch that should fix this: https://lists.01.org/pipermail/linux-nvdimm/2016-August/006637.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baSTR-0000wl-Rb for qemu-devel@nongnu.org; Thu, 18 Aug 2016 14:55:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1baSTM-0004M9-Hs for qemu-devel@nongnu.org; Thu, 18 Aug 2016 14:55:28 -0400 Received: from mga01.intel.com ([192.55.52.88]:18097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baSTM-0004Lo-CO for qemu-devel@nongnu.org; Thu, 18 Aug 2016 14:55:24 -0400 Date: Thu, 18 Aug 2016 12:54:39 -0600 From: Vishal Verma Message-ID: <20160818185438.GA7799@omniknight.lm.intel.com> References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dan Williams Cc: Xiao Guangrong , Paolo Bonzini , Igor Mammedov , Gleb Natapov , mtosatti@redhat.com, stefanha@redhat.com, "Michael S. Tsirkin" , rth@twiddle.net, ehabkost@redhat.com, KVM list , qemu-devel@nongnu.org On 08/18, Dan Williams wrote: > [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] > > On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong > wrote: > > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > > rx queue siz) on pci branch of Michael's git tree and can be found at: > > https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2 > > > > Changelog in v2: > > Fixed signed integer overflow pointed out by Stefan Hajnoczi > > > > This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug, > > for example, a new nvdimm device can be plugged as follows: > > object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3 > > device_add nvdimm,id=nvdimm3,memdev=mem3 > > > > and unplug it as follows: > > device_del nvdimm3 > > object_del mem3 > > Did you test this against the Linux NFIT hotplug support? We just > found that the Linux driver is not properly registering for ACPI0012 > event notification. Is a notification sent on a 'device_add' event? I've just sent out a patch that should fix this: https://lists.01.org/pipermail/linux-nvdimm/2016-August/006637.html