From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B51CC1A1E08 for ; Fri, 19 Aug 2016 01:17:41 -0700 (PDT) Date: Fri, 19 Aug 2016 10:17:38 +0200 From: Johannes Thumshirn Subject: Re: [PATCH v2] libnvdimm: Fix nvdimm_probe error on NVDIMM-N Message-ID: <20160819081738.ayh45ci4x3f7ykue@c203.arch.suse.de> References: <1471374520-3331-1-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1471374520-3331-1-git-send-email-toshi.kani@hpe.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Toshi Kani Cc: linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org List-ID: On Tue, Aug 16, 2016 at 01:08:40PM -0600, Toshi Kani wrote: > 'ndctl list --buses --dimms' does not list any NVDIMM-Ns since > they are considered as idle. ndctl checks if any driver is > attached to nmem device. nvdimm_probe() always fails in > nvdimm_init_nsarea() since NVDIMM-Ns do not implement optinal > ND_CMD_GET_CONFIG_DATA command. > = > Change nvdimm_probe() to accept the case that the CONFIG_DATA > command is not implemented for NVDIMM-Ns. The driver attaches > without ndd, which keeps it no-op to the device. > = > Reported-by: Brian Boylston > Signed-off-by: Toshi Kani > Cc: Dan Williams Tested-by: Johannes Thumshirn Acked-by: Johannes Thumshirn -- = Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton HRB 21284 (AG N=FCrnberg) Key fingerprint =3D EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755246AbcHSIRo (ORCPT ); Fri, 19 Aug 2016 04:17:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:57434 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754947AbcHSIRl (ORCPT ); Fri, 19 Aug 2016 04:17:41 -0400 Date: Fri, 19 Aug 2016 10:17:38 +0200 From: Johannes Thumshirn To: Toshi Kani Cc: dan.j.williams@intel.com, linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org Subject: Re: [PATCH v2] libnvdimm: Fix nvdimm_probe error on NVDIMM-N Message-ID: <20160819081738.ayh45ci4x3f7ykue@c203.arch.suse.de> References: <1471374520-3331-1-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1471374520-3331-1-git-send-email-toshi.kani@hpe.com> User-Agent: Mutt/1.6.2-neo (2016-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2016 at 01:08:40PM -0600, Toshi Kani wrote: > 'ndctl list --buses --dimms' does not list any NVDIMM-Ns since > they are considered as idle. ndctl checks if any driver is > attached to nmem device. nvdimm_probe() always fails in > nvdimm_init_nsarea() since NVDIMM-Ns do not implement optinal > ND_CMD_GET_CONFIG_DATA command. > > Change nvdimm_probe() to accept the case that the CONFIG_DATA > command is not implemented for NVDIMM-Ns. The driver attaches > without ndd, which keeps it no-op to the device. > > Reported-by: Brian Boylston > Signed-off-by: Toshi Kani > Cc: Dan Williams Tested-by: Johannes Thumshirn Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850