From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755160AbcHSRqV (ORCPT ); Fri, 19 Aug 2016 13:46:21 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:13183 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754362AbcHSRqT (ORCPT ); Fri, 19 Aug 2016 13:46:19 -0400 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com Date: Fri, 19 Aug 2016 10:46:20 -0700 From: "Paul E. McKenney" To: Rik van Riel Cc: kernel-hardening@lists.openwall.com, Kees Cook , Laura Abbott , Steven Rostedt , Daniel Micay , Joe Perches , Stephen Boyd , Syed Rameez Mustafa , Arnd Bergmann , Greg Kroah-Hartman , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , "Aneesh Kumar K.V" , "Kirill A. Shutemov" , Michael Ellerman , Andrew Morton , Dan Williams , Jan Kara , Thomas Gleixner , Josef Bacik , Ingo Molnar , Tejun Heo , Andrey Ryabinin , Nikolay Aleksandrov , Dmitry Vyukov , linux-kernel@vger.kernel.org Subject: Re: [kernel-hardening] [PATCH v3 0/5] bug: Provide toggle for BUG on data corruption Reply-To: paulmck@linux.vnet.ibm.com References: <1471470132-29499-1-git-send-email-keescook@chromium.org> <1471575198.32433.75.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471575198.32433.75.camel@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081917-0020-0000-0000-00000997C589 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005616; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000183; SDB=6.00746962; UDB=6.00352234; IPR=6.00519485; BA=6.00004671; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012395; XFM=3.00000011; UTC=2016-08-19 17:46:17 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081917-0021-0000-0000-000054B81633 Message-Id: <20160819174620.GG3482@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-19_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608190222 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 18, 2016 at 10:53:18PM -0400, Rik van Riel wrote: > On Thu, 2016-08-18 at 13:57 -0700, Paul E. McKenney wrote: > > On Thu, Aug 18, 2016 at 01:42:55PM -0400, Rik van Riel wrote: > > > On Wed, 2016-08-17 at 14:42 -0700, Kees Cook wrote: > > > > This adds CONFIG_BUG_ON_DATA_CORRUPTION to trigger BUG()s when > > > > the > > > > kernel > > > > encounters unexpected data structure integrity as currently > > > > detected > > > > with CONFIG_DEBUG_LIST. > > > >=20 > > > > Specifically list operations have been a target for widening > > > > flaws to > > > > gain > > > > "write anywhere" primitives for attackers, so this also > > > > consolidates > > > > the > > > > debug checking to avoid code and check duplication (e.g. RCU list > > > > debug > > > > was missing a check that got added to regular list debug). It > > > > also > > > > stops > > > > manipulations when corruption is detected, since worsening the > > > > corruption > > > > makes no sense. (Really, everyone should build with > > > > CONFIG_DEBUG_LIST > > > > since the checks are so inexpensive.) > > > >=20 > > > > This is mostly a refactoring of similar code from PaX and > > > > Grsecurity, > > > > along with MSM kernel changes by Syed Rameez Mustafa. > > > >=20 > > > > Along with the patches is a new lkdtm test to validate that > > > > setting > > > > CONFIG_DEBUG_LIST actually does what is desired. > > >=20 > > > Series looks good to me, too. > >=20 > > Reviewed-by?=C2=A0=C2=A0Acked-by?=C2=A0=C2=A0Ephemeral accolades?=C2=A0= > =C2=A0;-) > > Acked-by: Rik van Riel > > works, but I saw you already committed the series to > your tree, and was not sure you would add more reviews :) Well, there is at least one more rebase for topic branches. ;-) Thanx, Paul