Hi Icenowy, On Mon, Aug 01, 2016 at 11:13:50PM +0800, Icenowy Zheng wrote: > Signed-off-by: Icenowy Zheng > --- > Changes in v2: > - Rebased on Hans de Goede's patchset. > > Documentation/devicetree/bindings/mmc/sunxi-mmc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt > index 904ff9f..55cdd80 100644 > --- a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt > +++ b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt > @@ -13,6 +13,7 @@ Required properties: > * "allwinner,sun5i-a13-mmc" > * "allwinner,sun7i-a20-mmc" > * "allwinner,sun9i-a80-mmc" > + * "allwinner,sun50i-a64-mmc" > - reg : mmc controller base registers > - clocks : a list with 4 phandle + clock specifier pairs > - clock-names : must contain "ahb", "mmc", "output" and "sample" You need to document that the output and sample clocks are not mandatory in the A64 case. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com