From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755964AbcHVSJt (ORCPT ); Mon, 22 Aug 2016 14:09:49 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35938 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754748AbcHVSJr (ORCPT ); Mon, 22 Aug 2016 14:09:47 -0400 Date: Mon, 22 Aug 2016 19:09:32 +0100 From: Mark Brown To: Rask Ingemann Lambertsen Cc: Chen-Yu Tsai , Mark Rutland , devicetree@vger.kernel.org, Liam Girdwood , linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Rob Herring , Maxime Ripard , Lee Jones , linux-arm-kernel@lists.infradead.org Message-ID: <20160822180932.GW22076@sirena.org.uk> References: <20160821021125.1521-1-wens@csie.org> <20160821021125.1521-4-wens@csie.org> <20160822162907.GO22076@sirena.org.uk> <20160822175205.h76hurjaopnosymc@vip.cybercity.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NO4xtVTk6ycZDAf4" Content-Disposition: inline In-Reply-To: <20160822175205.h76hurjaopnosymc@vip.cybercity.dk> X-Cookie: Satire is what closes in New Haven. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NO4xtVTk6ycZDAf4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 22, 2016 at 07:52:05PM +0200, Rask Ingemann Lambertsen wrote: > On Mon, Aug 22, 2016 at 05:29:07PM +0100, Mark Brown wrote: > > This seems like you have buggy constraints, constraints which allow > > voltages that can't physically be satisfied don't make obvious sense. > No, it's for cases like this (see the cubietruck4 or a80-optimus dts > patches): > reg_bldo4: bldo4 { > regulator-min-microvolt = <1080000>; > regulator-max-microvolt = <1320000>; > regulator-name = "vcc12-hsic"; > }; > The regulator can do 1100000 uV, 1200000 uV and 1300000 uV, all of which > are within the constraints, so obviously the constraints can be satisfied, > yet the regulator core fails do so with a message like this: Sure, but the constraints also say that you can do 1.32V which the system is not physically capable of delivering. That's not a good sign for the constraints, it suggests that at least the capabilities of the regulator have not been taken into consideration when setting up the constraints. --NO4xtVTk6ycZDAf4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXuz/bAAoJECTWi3JdVIfQDzcH/0nx+52RhyCVL9xr//FY5iDh mSyxk+FVH2LJiTh1TpUFCIvTJlU/AaLJ1L+gHgNNu2qj4t929b2HTLwU1W0T8fSG GDEIIg8R0Ra5H7U3MdyVidmUKkl2l8xcW4OR2pBhwRLf0FdQJPqAZ1xCyWaXzI5c zLIaUtMapnPCswR8PwmbqylJrDOojdNCltEknGnP2CU17lYvKzrybLSMCeBMid5n lF3tr6i3MeEdvWiDY957CIn4+slRaIdqPv61FZRdBlgT+LHEJ7+SQ6MIT79SHPAF kDl5N0EMr5m+dwiUa0A7tm2tCgGCJuxbiKeD0llsGq+W8958gosIH7kd+bkxv1Q= =Pm1W -----END PGP SIGNATURE----- --NO4xtVTk6ycZDAf4-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints Date: Mon, 22 Aug 2016 19:09:32 +0100 Message-ID: <20160822180932.GW22076@sirena.org.uk> References: <20160821021125.1521-1-wens@csie.org> <20160821021125.1521-4-wens@csie.org> <20160822162907.GO22076@sirena.org.uk> <20160822175205.h76hurjaopnosymc@vip.cybercity.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NO4xtVTk6ycZDAf4" Return-path: Content-Disposition: inline In-Reply-To: <20160822175205.h76hurjaopnosymc-1EA3ORoCGBhoJ7GROcy7lA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rask Ingemann Lambertsen Cc: Chen-Yu Tsai , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liam Girdwood , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Rob Herring , Maxime Ripard , Lee Jones , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org --NO4xtVTk6ycZDAf4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 22, 2016 at 07:52:05PM +0200, Rask Ingemann Lambertsen wrote: > On Mon, Aug 22, 2016 at 05:29:07PM +0100, Mark Brown wrote: > > This seems like you have buggy constraints, constraints which allow > > voltages that can't physically be satisfied don't make obvious sense. > No, it's for cases like this (see the cubietruck4 or a80-optimus dts > patches): > reg_bldo4: bldo4 { > regulator-min-microvolt = <1080000>; > regulator-max-microvolt = <1320000>; > regulator-name = "vcc12-hsic"; > }; > The regulator can do 1100000 uV, 1200000 uV and 1300000 uV, all of which > are within the constraints, so obviously the constraints can be satisfied, > yet the regulator core fails do so with a message like this: Sure, but the constraints also say that you can do 1.32V which the system is not physically capable of delivering. That's not a good sign for the constraints, it suggests that at least the capabilities of the regulator have not been taken into consideration when setting up the constraints. --NO4xtVTk6ycZDAf4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXuz/bAAoJECTWi3JdVIfQDzcH/0nx+52RhyCVL9xr//FY5iDh mSyxk+FVH2LJiTh1TpUFCIvTJlU/AaLJ1L+gHgNNu2qj4t929b2HTLwU1W0T8fSG GDEIIg8R0Ra5H7U3MdyVidmUKkl2l8xcW4OR2pBhwRLf0FdQJPqAZ1xCyWaXzI5c zLIaUtMapnPCswR8PwmbqylJrDOojdNCltEknGnP2CU17lYvKzrybLSMCeBMid5n lF3tr6i3MeEdvWiDY957CIn4+slRaIdqPv61FZRdBlgT+LHEJ7+SQ6MIT79SHPAF kDl5N0EMr5m+dwiUa0A7tm2tCgGCJuxbiKeD0llsGq+W8958gosIH7kd+bkxv1Q= =Pm1W -----END PGP SIGNATURE----- --NO4xtVTk6ycZDAf4-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Mon, 22 Aug 2016 19:09:32 +0100 Subject: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints In-Reply-To: <20160822175205.h76hurjaopnosymc@vip.cybercity.dk> References: <20160821021125.1521-1-wens@csie.org> <20160821021125.1521-4-wens@csie.org> <20160822162907.GO22076@sirena.org.uk> <20160822175205.h76hurjaopnosymc@vip.cybercity.dk> Message-ID: <20160822180932.GW22076@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Aug 22, 2016 at 07:52:05PM +0200, Rask Ingemann Lambertsen wrote: > On Mon, Aug 22, 2016 at 05:29:07PM +0100, Mark Brown wrote: > > This seems like you have buggy constraints, constraints which allow > > voltages that can't physically be satisfied don't make obvious sense. > No, it's for cases like this (see the cubietruck4 or a80-optimus dts > patches): > reg_bldo4: bldo4 { > regulator-min-microvolt = <1080000>; > regulator-max-microvolt = <1320000>; > regulator-name = "vcc12-hsic"; > }; > The regulator can do 1100000 uV, 1200000 uV and 1300000 uV, all of which > are within the constraints, so obviously the constraints can be satisfied, > yet the regulator core fails do so with a message like this: Sure, but the constraints also say that you can do 1.32V which the system is not physically capable of delivering. That's not a good sign for the constraints, it suggests that at least the capabilities of the regulator have not been taken into consideration when setting up the constraints. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: