All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: labbott@redhat.com, samanthakumar@google.com, willemb@google.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH v2 net] udp: fix poll() issue with zero sized packets
Date: Tue, 23 Aug 2016 16:39:41 -0700 (PDT)	[thread overview]
Message-ID: <20160823.163941.1551130952096100509.davem@davemloft.net> (raw)
In-Reply-To: <1471985973.14381.54.camel@edumazet-glaptop3.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 23 Aug 2016 13:59:33 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> Laura tracked poll() [and friends] regression caused by commit
> e6afc8ace6dd ("udp: remove headers from UDP packets before queueing")
> 
> udp_poll() needs to know if there is a valid packet in receive queue,
> even if its payload length is 0.
> 
> Change first_packet_length() to return an signed int, and use -1
> as the indication of an empty queue.
> 
> Fixes: e6afc8ace6dd ("udp: remove headers from UDP packets before queueing")
> Reported-by: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Tested-by: Laura Abbott <labbott@redhat.com>
> ---
> v2: fix the comment/doc (Willem)

Applied and queued up for -stable, thanks.

  reply	other threads:[~2016-08-23 23:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23 17:53 [REGRESSION] Select hang with zero sized UDP packets Laura Abbott
2016-08-23 18:25 ` David Miller
2016-08-23 19:03   ` Eric Dumazet
2016-08-23 20:06     ` Laura Abbott
2016-08-23 20:42       ` Eric Dumazet
2016-08-23 20:53       ` [PATCH net] udp: fix poll() issue with zero sized packets Eric Dumazet
2016-08-23 20:56         ` Eric Dumazet
2016-08-23 20:59         ` [PATCH v2 " Eric Dumazet
2016-08-23 23:39           ` David Miller [this message]
2016-08-24  8:22   ` [REGRESSION] Select hang with zero sized UDP packets Dan Akunis
2016-08-24 13:02     ` Eric Dumazet
2016-08-24 13:42     ` One Thousand Gnomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160823.163941.1551130952096100509.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=labbott@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=samanthakumar@google.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.