From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757473AbcHWKEj (ORCPT ); Tue, 23 Aug 2016 06:04:39 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:36600 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753656AbcHWKDG (ORCPT ); Tue, 23 Aug 2016 06:03:06 -0400 Date: Tue, 23 Aug 2016 11:02:01 +0100 From: Russell King - ARM Linux To: Mikko Rapeli Cc: linux-kernel@vger.kernel.org, David Vrabel , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v05 54/72] include/uapi/xen/privcmd.h: fix compilation in userspace Message-ID: <20160823100201.GG1041@n2100.armlinux.org.uk> References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-55-git-send-email-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471890809-4383-55-git-send-email-mikko.rapeli@iki.fi> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 22, 2016 at 08:33:11PM +0200, Mikko Rapeli wrote: > xen/interface/xen.h is not exported from kernel headers so remove the > dependency and provide needed defines for domid_t and xen_pfn_t if they > are not already defined by some other e.g. Xen specific headers. I'm confused. How did we end up with a 64-bit PFN number on ARM? It's insane - especially as the kernel uses "unsigned long" almost everywhere for PFNs - we can't have physical addresses more than 44 bits (32 bit pfn + 4k page size). > Suggested by Andrew Cooper on lkml message > <5569F9C9.8000607@citrix.com>. > > The ifdef for ARM is ugly but did not find better solutions for it. #ifdef __arm__ maybe? Even if not, the unsightly parens are not necessary. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Tue, 23 Aug 2016 11:02:01 +0100 Subject: [PATCH v05 54/72] include/uapi/xen/privcmd.h: fix compilation in userspace In-Reply-To: <1471890809-4383-55-git-send-email-mikko.rapeli@iki.fi> References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-55-git-send-email-mikko.rapeli@iki.fi> Message-ID: <20160823100201.GG1041@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Aug 22, 2016 at 08:33:11PM +0200, Mikko Rapeli wrote: > xen/interface/xen.h is not exported from kernel headers so remove the > dependency and provide needed defines for domid_t and xen_pfn_t if they > are not already defined by some other e.g. Xen specific headers. I'm confused. How did we end up with a 64-bit PFN number on ARM? It's insane - especially as the kernel uses "unsigned long" almost everywhere for PFNs - we can't have physical addresses more than 44 bits (32 bit pfn + 4k page size). > Suggested by Andrew Cooper on lkml message > <5569F9C9.8000607@citrix.com>. > > The ifdef for ARM is ugly but did not find better solutions for it. #ifdef __arm__ maybe? Even if not, the unsightly parens are not necessary. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v05 54/72] include/uapi/xen/privcmd.h: fix compilation in userspace Date: Tue, 23 Aug 2016 11:02:01 +0100 Message-ID: <20160823100201.GG1041@n2100.armlinux.org.uk> References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-55-git-send-email-mikko.rapeli@iki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bc8XS-0001UU-5d for xen-devel@lists.xenproject.org; Tue, 23 Aug 2016 10:02:34 +0000 Content-Disposition: inline In-Reply-To: <1471890809-4383-55-git-send-email-mikko.rapeli@iki.fi> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Mikko Rapeli Cc: Juergen Gross , Stefano Stabellini , linux-kernel@vger.kernel.org, David Vrabel , xen-devel@lists.xenproject.org, Boris Ostrovsky , linux-arm-kernel@lists.infradead.org List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBBdWcgMjIsIDIwMTYgYXQgMDg6MzM6MTFQTSArMDIwMCwgTWlra28gUmFwZWxpIHdy b3RlOgo+IHhlbi9pbnRlcmZhY2UveGVuLmggaXMgbm90IGV4cG9ydGVkIGZyb20ga2VybmVsIGhl YWRlcnMgc28gcmVtb3ZlIHRoZQo+IGRlcGVuZGVuY3kgYW5kIHByb3ZpZGUgbmVlZGVkIGRlZmlu ZXMgZm9yIGRvbWlkX3QgYW5kIHhlbl9wZm5fdCBpZiB0aGV5Cj4gYXJlIG5vdCBhbHJlYWR5IGRl ZmluZWQgYnkgc29tZSBvdGhlciBlLmcuIFhlbiBzcGVjaWZpYyBoZWFkZXJzLgoKSSdtIGNvbmZ1 c2VkLiAgSG93IGRpZCB3ZSBlbmQgdXAgd2l0aCBhIDY0LWJpdCBQRk4gbnVtYmVyIG9uIEFSTT8g IEl0J3MKaW5zYW5lIC0gZXNwZWNpYWxseSBhcyB0aGUga2VybmVsIHVzZXMgInVuc2lnbmVkIGxv bmciIGFsbW9zdCBldmVyeXdoZXJlCmZvciBQRk5zIC0gd2UgY2FuJ3QgaGF2ZSBwaHlzaWNhbCBh ZGRyZXNzZXMgbW9yZSB0aGFuIDQ0IGJpdHMgKDMyIGJpdApwZm4gKyA0ayBwYWdlIHNpemUpLgoK PiBTdWdnZXN0ZWQgYnkgQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4g b24gbGttbCBtZXNzYWdlCj4gPDU1NjlGOUM5LjgwMDA2MDdAY2l0cml4LmNvbT4uCj4gCj4gVGhl IGlmZGVmIGZvciBBUk0gaXMgdWdseSBidXQgZGlkIG5vdCBmaW5kIGJldHRlciBzb2x1dGlvbnMg Zm9yIGl0LgoKI2lmZGVmIF9fYXJtX18KCm1heWJlPyAgRXZlbiBpZiBub3QsIHRoZSB1bnNpZ2h0 bHkgcGFyZW5zIGFyZSBub3QgbmVjZXNzYXJ5LgoKLS0gClJNSydzIFBhdGNoIHN5c3RlbTogaHR0 cDovL3d3dy5hcm1saW51eC5vcmcudWsvZGV2ZWxvcGVyL3BhdGNoZXMvCkZUVEMgYnJvYWRiYW5k IGZvciAwLjhtaWxlIGxpbmU6IGN1cnJlbnRseSBhdCA5LjZNYnBzIGRvd24gNDAwa2JwcyB1cAph Y2NvcmRpbmcgdG8gc3BlZWR0ZXN0Lm5ldC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3Rz Lnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=