From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:43534 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbcHWLnr (ORCPT ); Tue, 23 Aug 2016 07:43:47 -0400 Date: Tue, 23 Aug 2016 13:38:30 +0200 From: Cyril Hrubis To: Jeff Layton Cc: Florian Weimer , Mike Frysinger , "Michael Kerrisk (man-pages)" , libc-alpha@sourceware.org, linux-fsdevel@vger.kernel.org, Carlos O'Donell , Yuriy Kolerov Subject: Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64 Message-ID: <20160823113830.GB4962@rei.suse.cz> References: <1471461304.3196.101.camel@redhat.com> <1471464343.3196.125.camel@redhat.com> <20160817203746.GF21655@vapier.lan> <1471467478.3196.143.camel@redhat.com> <20160817213522.GG21655@vapier.lan> <1471470526.3196.153.camel@redhat.com> <8e1a972a-7966-139b-9d75-6d3a847a1be8@redhat.com> <20160823110343.GA4962@rei.suse.cz> <1471952179.13027.3.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471952179.13027.3.camel@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi! > To be clear, that approach was NAK'ed by Christoph (and I think that's > a good thing, actually -- one more nail in the non-LFS coffin). I think > what we want merged into glibc is this patch that I sent late on > Thursday: > > [glibc PATCHv2] fcntl: don't define OFD lock constants for 32-bit builds with small file offsets > > We'll also need your patch to the fcntl(2) manpage as well, but that's > a separate problem. Hmm, the patch for man-pages should be updated as well. We need somethign as: ... This lock type is Linux-specific, and available since Linux 3.15. On 32bit platform _FILE_OFFSET_BITS must defined to 64 (before including any header files) to make these locks available. ... Michael should I send updated patch or will you take care of this? -- Cyril Hrubis chrubis@suse.cz