All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: sunxi: depend on ARCH_SUNXI
@ 2016-08-23 17:17 ` Peter Robinson
  0 siblings, 0 replies; 12+ messages in thread
From: Peter Robinson @ 2016-08-23 17:17 UTC (permalink / raw)
  To: maxime.ripard, broonie, lgirdwood, wens, alsa-devel, linux-arm-kernel
  Cc: Peter Robinson

Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
these if the appropriate SoC they're embedded in isn't enabled.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 sound/soc/sunxi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
index 2a954bd..dd23682 100644
--- a/sound/soc/sunxi/Kconfig
+++ b/sound/soc/sunxi/Kconfig
@@ -1,4 +1,5 @@
 menu "Allwinner SoC Audio support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 
 config SND_SUN4I_CODEC
 	tristate "Allwinner A10 Codec Support"
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] ASoC: sunxi: depend on ARCH_SUNXI
@ 2016-08-23 17:17 ` Peter Robinson
  0 siblings, 0 replies; 12+ messages in thread
From: Peter Robinson @ 2016-08-23 17:17 UTC (permalink / raw)
  To: linux-arm-kernel

Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
these if the appropriate SoC they're embedded in isn't enabled.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 sound/soc/sunxi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
index 2a954bd..dd23682 100644
--- a/sound/soc/sunxi/Kconfig
+++ b/sound/soc/sunxi/Kconfig
@@ -1,4 +1,5 @@
 menu "Allwinner SoC Audio support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 
 config SND_SUN4I_CODEC
 	tristate "Allwinner A10 Codec Support"
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: sunxi: depend on ARCH_SUNXI
  2016-08-22 14:49   ` Arnd Bergmann
@ 2016-08-23  8:34     ` Peter Robinson
  -1 siblings, 0 replies; 12+ messages in thread
From: Peter Robinson @ 2016-08-23  8:34 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: alsa-devel, lgirdwood, wens, broonie, maxime.ripard, linux-arm-kernel

On Mon, Aug 22, 2016 at 3:49 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday, August 22, 2016 1:12:42 PM CEST Peter Robinson wrote:
>> Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
>> these if the appropriate SoC they're embedded in isn't enabled.
>>
>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>> ---
>>  sound/soc/sunxi/Kconfig | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
>> index 2a954bd..a2b62dc5 100644
>> --- a/sound/soc/sunxi/Kconfig
>> +++ b/sound/soc/sunxi/Kconfig
>> @@ -2,6 +2,7 @@ menu "Allwinner SoC Audio support"
>>
>>  config SND_SUN4I_CODEC
>>         tristate "Allwinner A10 Codec Support"
>> +       depends on ARCH_SUNXI || COMPILE_TEST
>>         select SND_SOC_GENERIC_DMAENGINE_PCM
>>         select REGMAP_MMIO
>>
>
> Makes sense, though I think it's nicer to add the dependency to the entire
> menu, so we hide that as well, and don't have to add the line to future
> entries:

Makes sense, will do a v2 shortly.

P

> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
> index 2a954bd01fd8..dd2368297fd3 100644
> --- a/sound/soc/sunxi/Kconfig
> +++ b/sound/soc/sunxi/Kconfig
> @@ -1,4 +1,5 @@
>  menu "Allwinner SoC Audio support"
> +       depends on ARCH_SUNXI || COMPILE_TEST
>
>  config SND_SUN4I_CODEC
>         tristate "Allwinner A10 Codec Support"
>
> Either way
> Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH] ASoC: sunxi: depend on ARCH_SUNXI
@ 2016-08-23  8:34     ` Peter Robinson
  0 siblings, 0 replies; 12+ messages in thread
From: Peter Robinson @ 2016-08-23  8:34 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Aug 22, 2016 at 3:49 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday, August 22, 2016 1:12:42 PM CEST Peter Robinson wrote:
>> Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
>> these if the appropriate SoC they're embedded in isn't enabled.
>>
>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>> ---
>>  sound/soc/sunxi/Kconfig | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
>> index 2a954bd..a2b62dc5 100644
>> --- a/sound/soc/sunxi/Kconfig
>> +++ b/sound/soc/sunxi/Kconfig
>> @@ -2,6 +2,7 @@ menu "Allwinner SoC Audio support"
>>
>>  config SND_SUN4I_CODEC
>>         tristate "Allwinner A10 Codec Support"
>> +       depends on ARCH_SUNXI || COMPILE_TEST
>>         select SND_SOC_GENERIC_DMAENGINE_PCM
>>         select REGMAP_MMIO
>>
>
> Makes sense, though I think it's nicer to add the dependency to the entire
> menu, so we hide that as well, and don't have to add the line to future
> entries:

Makes sense, will do a v2 shortly.

P

> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
> index 2a954bd01fd8..dd2368297fd3 100644
> --- a/sound/soc/sunxi/Kconfig
> +++ b/sound/soc/sunxi/Kconfig
> @@ -1,4 +1,5 @@
>  menu "Allwinner SoC Audio support"
> +       depends on ARCH_SUNXI || COMPILE_TEST
>
>  config SND_SUN4I_CODEC
>         tristate "Allwinner A10 Codec Support"
>
> Either way
> Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: sunxi: depend on ARCH_SUNXI
  2016-08-22 14:49   ` Arnd Bergmann
@ 2016-08-22 17:41     ` Mark Brown
  -1 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2016-08-22 17:41 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: alsa-devel, lgirdwood, wens, Peter Robinson, maxime.ripard,
	linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 251 bytes --]

On Mon, Aug 22, 2016 at 04:49:11PM +0200, Arnd Bergmann wrote:

> Makes sense, though I think it's nicer to add the dependency to the entire
> menu, so we hide that as well, and don't have to add the line to future
> entries:

Yes, that seems better.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH] ASoC: sunxi: depend on ARCH_SUNXI
@ 2016-08-22 17:41     ` Mark Brown
  0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2016-08-22 17:41 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Aug 22, 2016 at 04:49:11PM +0200, Arnd Bergmann wrote:

> Makes sense, though I think it's nicer to add the dependency to the entire
> menu, so we hide that as well, and don't have to add the line to future
> entries:

Yes, that seems better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160822/ba863400/attachment-0001.sig>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: sunxi: depend on ARCH_SUNXI
  2016-08-22 12:12 ` Peter Robinson
@ 2016-08-22 14:49   ` Arnd Bergmann
  -1 siblings, 0 replies; 12+ messages in thread
From: Arnd Bergmann @ 2016-08-22 14:49 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: alsa-devel, lgirdwood, wens, broonie, Peter Robinson, maxime.ripard

On Monday, August 22, 2016 1:12:42 PM CEST Peter Robinson wrote:
> Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
> these if the appropriate SoC they're embedded in isn't enabled.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  sound/soc/sunxi/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
> index 2a954bd..a2b62dc5 100644
> --- a/sound/soc/sunxi/Kconfig
> +++ b/sound/soc/sunxi/Kconfig
> @@ -2,6 +2,7 @@ menu "Allwinner SoC Audio support"
>  
>  config SND_SUN4I_CODEC
>         tristate "Allwinner A10 Codec Support"
> +       depends on ARCH_SUNXI || COMPILE_TEST
>         select SND_SOC_GENERIC_DMAENGINE_PCM
>         select REGMAP_MMIO
> 

Makes sense, though I think it's nicer to add the dependency to the entire
menu, so we hide that as well, and don't have to add the line to future
entries:

diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
index 2a954bd01fd8..dd2368297fd3 100644
--- a/sound/soc/sunxi/Kconfig
+++ b/sound/soc/sunxi/Kconfig
@@ -1,4 +1,5 @@
 menu "Allwinner SoC Audio support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 
 config SND_SUN4I_CODEC
 	tristate "Allwinner A10 Codec Support"

Either way
Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] ASoC: sunxi: depend on ARCH_SUNXI
@ 2016-08-22 14:49   ` Arnd Bergmann
  0 siblings, 0 replies; 12+ messages in thread
From: Arnd Bergmann @ 2016-08-22 14:49 UTC (permalink / raw)
  To: linux-arm-kernel

On Monday, August 22, 2016 1:12:42 PM CEST Peter Robinson wrote:
> Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
> these if the appropriate SoC they're embedded in isn't enabled.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  sound/soc/sunxi/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
> index 2a954bd..a2b62dc5 100644
> --- a/sound/soc/sunxi/Kconfig
> +++ b/sound/soc/sunxi/Kconfig
> @@ -2,6 +2,7 @@ menu "Allwinner SoC Audio support"
>  
>  config SND_SUN4I_CODEC
>         tristate "Allwinner A10 Codec Support"
> +       depends on ARCH_SUNXI || COMPILE_TEST
>         select SND_SOC_GENERIC_DMAENGINE_PCM
>         select REGMAP_MMIO
> 

Makes sense, though I think it's nicer to add the dependency to the entire
menu, so we hide that as well, and don't have to add the line to future
entries:

diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
index 2a954bd01fd8..dd2368297fd3 100644
--- a/sound/soc/sunxi/Kconfig
+++ b/sound/soc/sunxi/Kconfig
@@ -1,4 +1,5 @@
 menu "Allwinner SoC Audio support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 
 config SND_SUN4I_CODEC
 	tristate "Allwinner A10 Codec Support"

Either way
Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: sunxi: depend on ARCH_SUNXI
  2016-08-22 12:12 ` Peter Robinson
@ 2016-08-22 14:04   ` Maxime Ripard
  -1 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2016-08-22 14:04 UTC (permalink / raw)
  To: Peter Robinson; +Cc: linux-arm-kernel, wens, broonie, lgirdwood, alsa-devel


[-- Attachment #1.1: Type: text/plain, Size: 459 bytes --]

Hi,

On Mon, Aug 22, 2016 at 01:12:42PM +0100, Peter Robinson wrote:
> Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
> these if the appropriate SoC they're embedded in isn't enabled.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH] ASoC: sunxi: depend on ARCH_SUNXI
@ 2016-08-22 14:04   ` Maxime Ripard
  0 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2016-08-22 14:04 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Mon, Aug 22, 2016 at 01:12:42PM +0100, Peter Robinson wrote:
> Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
> these if the appropriate SoC they're embedded in isn't enabled.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160822/e8aa6d30/attachment.sig>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH] ASoC: sunxi: depend on ARCH_SUNXI
@ 2016-08-22 12:12 ` Peter Robinson
  0 siblings, 0 replies; 12+ messages in thread
From: Peter Robinson @ 2016-08-22 12:12 UTC (permalink / raw)
  To: maxime.ripard, broonie, lgirdwood, wens, alsa-devel, linux-arm-kernel
  Cc: Peter Robinson

Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
these if the appropriate SoC they're embedded in isn't enabled.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 sound/soc/sunxi/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
index 2a954bd..a2b62dc5 100644
--- a/sound/soc/sunxi/Kconfig
+++ b/sound/soc/sunxi/Kconfig
@@ -2,6 +2,7 @@ menu "Allwinner SoC Audio support"
 
 config SND_SUN4I_CODEC
 	tristate "Allwinner A10 Codec Support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select REGMAP_MMIO
 	help
@@ -10,6 +11,7 @@ config SND_SUN4I_CODEC
 
 config SND_SUN4I_I2S
 	tristate "Allwinner A10 I2S Support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select REGMAP_MMIO
 	help
@@ -19,7 +21,7 @@ config SND_SUN4I_I2S
 
 config SND_SUN4I_SPDIF
 	tristate "Allwinner A10 SPDIF Support"
-	depends on OF
+	depends on OF && (ARCH_SUNXI || COMPILE_TEST)
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select REGMAP_MMIO
 	help
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] ASoC: sunxi: depend on ARCH_SUNXI
@ 2016-08-22 12:12 ` Peter Robinson
  0 siblings, 0 replies; 12+ messages in thread
From: Peter Robinson @ 2016-08-22 12:12 UTC (permalink / raw)
  To: linux-arm-kernel

Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
these if the appropriate SoC they're embedded in isn't enabled.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 sound/soc/sunxi/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
index 2a954bd..a2b62dc5 100644
--- a/sound/soc/sunxi/Kconfig
+++ b/sound/soc/sunxi/Kconfig
@@ -2,6 +2,7 @@ menu "Allwinner SoC Audio support"
 
 config SND_SUN4I_CODEC
 	tristate "Allwinner A10 Codec Support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select REGMAP_MMIO
 	help
@@ -10,6 +11,7 @@ config SND_SUN4I_CODEC
 
 config SND_SUN4I_I2S
 	tristate "Allwinner A10 I2S Support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select REGMAP_MMIO
 	help
@@ -19,7 +21,7 @@ config SND_SUN4I_I2S
 
 config SND_SUN4I_SPDIF
 	tristate "Allwinner A10 SPDIF Support"
-	depends on OF
+	depends on OF && (ARCH_SUNXI || COMPILE_TEST)
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select REGMAP_MMIO
 	help
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-08-23 17:17 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-23 17:17 [PATCH] ASoC: sunxi: depend on ARCH_SUNXI Peter Robinson
2016-08-23 17:17 ` Peter Robinson
  -- strict thread matches above, loose matches on Subject: below --
2016-08-22 12:12 Peter Robinson
2016-08-22 12:12 ` Peter Robinson
2016-08-22 14:04 ` Maxime Ripard
2016-08-22 14:04   ` Maxime Ripard
2016-08-22 14:49 ` Arnd Bergmann
2016-08-22 14:49   ` Arnd Bergmann
2016-08-22 17:41   ` Mark Brown
2016-08-22 17:41     ` Mark Brown
2016-08-23  8:34   ` Peter Robinson
2016-08-23  8:34     ` Peter Robinson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.