From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756705AbcHXQ6X (ORCPT ); Wed, 24 Aug 2016 12:58:23 -0400 Received: from mail-he1eur01on0099.outbound.protection.outlook.com ([104.47.0.99]:30848 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755884AbcHXQ6V (ORCPT ); Wed, 24 Aug 2016 12:58:21 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=VDavydov@virtuozzo.com; Date: Wed, 24 Aug 2016 12:18:39 +0300 From: Vladimir Davydov To: Arnd Bergmann CC: Johannes Weiner , Michal Hocko , Andrew Morton , Tejun Heo , "Mel Gorman" , , , Subject: Re: [PATCH] mm: memcontrol: avoid unused function warning Message-ID: <20160824091839.GE1863@esperanza> References: <20160824082301.632345-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160824082301.632345-1-arnd@arndb.de> X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM5PR0701CA0009.eurprd07.prod.outlook.com (10.168.161.19) To HE1PR0801MB1866.eurprd08.prod.outlook.com (10.168.94.9) X-MS-Office365-Filtering-Correlation-Id: 0ace262f-8406-411c-28b2-08d3cbffa5c2 X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1866;2:eM9jA8AbHfUSdrgff5M5ynXgHhuMYXpPHJr+JnCU/sHdTZfR6L2dsuXfzMOYRhXKe+neWHlDvn2yAzyIx8YZ30hh0RDL1igdxPOArQy7BlRTCw4yoFAcGS6DDz+eq0muVgdQAjIfAAIY/IYhB0FcRARKN13oIh03JBa3hbyMpKvFkoUEEsHl1GSFOp56vGhR;3:E+FoxC7tEintt3YOM06evYV7T+bVFnz0xsgWd4vrDsIqMvlR1hXLoWmxVsWJyRroA211yIJXK/51SAdQbnwXSQWSUnTmtz9yI979D5ESvGpDjKWVGRYmAA9gkBGMD9Di X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1866; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1866;25:eBsTpH3lz8vt6F5aCABDsY+4SLRSyzsVc9RdDHogtfBZVb1tNkHl28mXp6YWZk5UI8hvpJHUO/YxIWPBnqJAsmwcD8RcI06AfVqtwECPRPhcsVgQ+wvB5QpE1QNZv2DF6c3I/Ftp048sYjq/D5JdrQrGu162g/RSZIvev7H2LAS3a81LWc8TRZz1aEpdwfz8MmabeF33YJFn89NTUTmFl+dZHJZEr/wP0ga7MnCeqUPtuhbPgSSMqUGHuw/7I/IZiFGQ7ct7iSy56I4428PpuU0YaDYph1Tzduyq0CxI7moD4fnUXcaYaeocfIiSkvQ8FYT6CYmFz5N5qYh7o1BKx6qo3lcMJD/HjAqumtNtWqYcUHnfTvnO96Yi3zNGm7uLtBzxqWsFMYe9aXIy7RCRpuvHNkvRuuy5RIFjB3CP+LTrlZnxOgo2HXYHrpVIKNlZD/4mwCXfisiRQfqT78QHBp13BqjnNU+DLTk9g+RT6H5yldJsuQ9Wy2P7++LlTLLvRWon0/Y9l+QPfv6EG8OciURQo0BrfuZRZFqvYrMYyMt+PaFjkHo3205msUR1CGfV+T4uT0W7VP6+I3gq+7NyJ3ZngSAG+WwDiNJ6MnXGUsPlKrkl81mb5EGKTJnYgpDTfWaVpV//C5yFBSefBa4wIW7m9k5+pVNBLav3yATCqc/5jp8aw4qoyX1Iuhlt1oMbHJU+zPj3GM2vExPigtYiwg==;31:IyU/GGLzmV3iT9cgbucrXsHj1jf1zQYR7Tc84T8XuHuBa/bpB0Jxt6qzcnVbr913j82THafvLOF13gxypgxqlh2eUXK4JXiRxf0Da6y/57YX/UjtBBEn3P4KBs62nRJPC7RJ1yAnZyRC0nK/RSN+dI/6GRAtc55POaT4UG3Xr/ZgkN1pSAl8gGmRvoWc7FjitJDuIf7r6BtR0zD7BLrrTeDOAM64suQrUaVWBIa5ZPg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6042046)(6043046);SRVR:HE1PR0801MB1866;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1866; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1866;4:ME4WmDc3itMkIT4VBOHy4iWb3TROlejhCiQyLraeTnJpbeirnaEX7d7VLOx8SUCG74qYORaumNC8rRNGKubF5xkm+Q5P8kTfdvUVaPOK15ASTK22wPDcjcjUmz9BL5FiHjGXJ+U3Sd6BSC24v9NJjyDqYx4ijcrCFH5EXiY7Bqla8aoukfehDUPMnIURiGLyLjq8VFmNtwiZFf9/SIfiK+JoU1YrtMWRTdtxRasd/ozXXJrrBJAYpOvUfjuXYFP3QZksD1bmmc55z6IfezGMD5NMLw1DI9Vdc07+d7D4ZLasEu5UkMYr9jddsg/v1VXD+VZru8i+y2rT8GbXfR50LiDgaltOEsgP87h7gu7d3c3/i7+KpvXf6yjmY6Yxqq3Kq2DbA0cmsAbRSS1I51a+IXnTnxjCizE5mmJEoBnqKSA= X-Forefront-PRVS: 0044C17179 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(199003)(24454002)(66066001)(2906002)(86362001)(68736007)(6116002)(7736002)(1076002)(9686002)(19580395003)(23726003)(7846002)(33656002)(3846002)(2950100001)(92566002)(81156014)(189998001)(5660300001)(42186005)(586003)(105586002)(305945005)(19580405001)(97736004)(101416001)(47776003)(97756001)(46406003)(76176999)(8676002)(33716001)(80792005)(77096005)(4326007)(50466002)(50986999)(110136002)(54356999)(106356001)(81166006);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB1866;H:esperanza;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0801MB1866;23:ku6R8xwKDMJdcpJ51eKdT05o88QG35gEBY9hJRt?= =?us-ascii?Q?u+by7y5UGEcX/VCXsojjDNG5vwF19US456Ei+bQAQESSligACQPpXxnNUGUN?= =?us-ascii?Q?G/eV3nwaiyW9VVtincTrGkmhCDQn61heB5H8I55mYNVcmL6HZdRajQiz+nOR?= =?us-ascii?Q?hFtTMmDbYNvFuOwYOS9Qms13DjRVqPWFMwLe0RPTlmXhAphO1oDszTb1CWuN?= =?us-ascii?Q?YihTCIF3J/c2zXQMwygEoGbvkl5QgkW3vEH7793or0YxPxbveE1zs4M7pICe?= =?us-ascii?Q?bYVnNSsvdRCFWVS3c2GVUYT/MFPZi4jP8g+8fvkXcNgFnsvBQAb9yHO/TPKD?= =?us-ascii?Q?s5cz8NtP8m1ahQ00QiCVyiKYz0e62BOkdxm4H7jF6Sq66W4SRx3Go0SI2jNk?= =?us-ascii?Q?/bte3P3S5PyHQ7xpVozlX3PL3z6GUrHAEYYLUgR9ScedRAE+hqW6ed0oJSl+?= =?us-ascii?Q?VtmDKhSCZmdGqNhtwFWx7unbf7niMhcGfyP+JruFsiyWX9JAtOvZNaGO9eLm?= =?us-ascii?Q?RFrkSYpP/PUjxtGZzA44J2gEMPviL68qhSfXdxJQRipFS+ArP52bpv5shDGT?= =?us-ascii?Q?THIwWfUHpovb8kgcu+tTKZjOr9wEUTXe5Nse/IjwZN3+ke5igf0xjA2L3lkb?= =?us-ascii?Q?LBGxsNGvRgnWhshesyVZmvnerk20oNgpH8AuKEdIZMaEikGVGSnRsFob72tw?= =?us-ascii?Q?ksM3YWoF+Z5NibV4dGYLp0bvA20Q/44tXbBshWCZ1BgRhBLH5Am4jeWy8EDR?= =?us-ascii?Q?cCrfphUfH/9/0pO0VXJiX0Zk82neo/9+sayrGn7Ua7fuz5y85lCiG4dRtPB0?= =?us-ascii?Q?do2wjhdRvavkvUH5Y3IZBl1kBEgkUTUgCjjyCZDwXQ6+ipIT/9f1m4Q6PRGe?= =?us-ascii?Q?XquufLSkKVJg/wi+e0JYj6UyiFlSkIK+UV31UyJRiyQnpjA88GbZTa3BDIuS?= =?us-ascii?Q?iWQiFv5rNzt1f+Ue6ocBjH7qkDEOEr70RESH3FlkHxYZFXHkvVSAb8+QQzxg?= =?us-ascii?Q?NUpLIGYJtA5SrZ6rrgUY3DoKPMQO/PBnJKhEYfc7vcs0rHtsbO6f53bGNpC8?= =?us-ascii?Q?KFEvQSSi3E+UfDbowOSaVRD0A5bCh3/7Gg3L8R4z8sdXfYg0gk4T8WqXuRk4?= =?us-ascii?Q?+POUUzg7D6EGm2zyAUh1Ueu1Ewfjh2X6h?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1866;6:1hNa6u3bTQ0ESGm/qgMyMg5mCHZ3HnnYVJqalDnLuFDXPuchiOslY6BZa7GdSS4ic2lq+13+2LVow6R7d1AiS1bNXCcIwbTbxYpeqNv3BYCjRpUu1lGO7W99zHPl5HXIt6y43mpmr0olGxYhxUrlDisNpLAy4jPekqRpWupcZ9937lpCUWQBBZf2OoK0EleavqopruvoBwMXmOMD9aYTuUCxR9u/Lv0NyGn/SExwABcSI8th9L1YqpUCR2YxCZoJ0NSRY/c+5VgXl2NUcBI6OAij4PaJeEFc561ex4hqnJoC4beJexkYPdSwTSs9NGjW;5:pvrOpVLQ//rQwEQOwnXqRLLe5QRgnmJ0egmFyVxMgKi8psfOflPg6gxZWnIjny4oMKOwznEgu3s/vC06jJELoQM67a0wVJYU+5OGKTee6UyUlEFFTiCU9oYiaROs/AKU4097tp3AiZR7xhcAJW/xVA==;24:Gp6jd/rZxWZ+ZYxWNSsD8+Sp9joF/6rrQCyEqQkvsel71zifXo2wsCyF7UglNPhQbGuGfzVZJ724/n8LmO3VfFXjZbgHd6Z/fxHF59BzM2M=;7:LGzqNLdM3dyV+HpWYy26viGRWzz3sKd51mdkxXUVn0ewGTWlzv4LBKfRZeiNawWyVdQaj/4JHbY7yIinqzuPEgj6N3eGTf1z0IfVqFV/qHZgalEHfjYH/0W0zx3wr+LtHjY+aG5mH3hQzgZV8om7C6xeSZE/SaXWox9KTsOtrma7iERqOEM79yRnpeose9TEv5bszy7aXKQi8T7TyMz/ktcaAIkDo2lZET+bYu9cUB4zFi9SUA0mJ3ayLhAkoExX SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1866;20:QKGvDmb8tQyt73MncsWhC9ZbDaJyFdL1ilV4jKZCP1S31ybAuRvuTlc8Mr85bLueMexUrWmh2AaT51vSX/CA91zz83HUS1LqGlmKFqghoyGavA4gobzjOLHY1nwvYziZ6qUIsasNq6DM2ygY6IVCG4hB/GHU174ckRFNRFnMTnk= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2016 09:18:43.8438 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1866 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2016 at 10:22:43AM +0200, Arnd Bergmann wrote: > A bugfix in v4.8-rc2 introduced a harmless warning when CONFIG_MEMCG_SWAP > is disabled but CONFIG_MEMCG is enabled: > > mm/memcontrol.c:4085:27: error: 'mem_cgroup_id_get_online' defined but not used [-Werror=unused-function] > static struct mem_cgroup *mem_cgroup_id_get_online(struct mem_cgroup *memcg) > > This adds an extra #ifdef that matches the one around the caller to > avoid the warning. > > Signed-off-by: Arnd Bergmann > Fixes: 1f47b61fb407 ("mm: memcontrol: fix swap counter leak on swapout from offline cgroup") Acked-by: Vladimir Davydov From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Davydov Subject: Re: [PATCH] mm: memcontrol: avoid unused function warning Date: Wed, 24 Aug 2016 12:18:39 +0300 Message-ID: <20160824091839.GE1863@esperanza> References: <20160824082301.632345-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YZFtCDc5uHc0lbbXATHP+nPy95TworpFYPQALLpBYxE=; b=VS2ONv4/kttm1X/ywBASD696w+/L2NGsrGpUWO51QRhSl5JHeSUtM+unNt6/DPLD4j/BD1EucYKiQ8O+HPADHVTsjwvRyTY8WiOcAbPN/nzJaerX1Wer1eH7USuF2AvcYKoWjwTzFvolhGb8ecaPIdsxu19yPZjCFmiU1u7VknM= Content-Disposition: inline In-Reply-To: <20160824082301.632345-1-arnd@arndb.de> Sender: owner-linux-mm@kvack.org List-ID: Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: Johannes Weiner , Michal Hocko , Andrew Morton , Tejun Heo , Mel Gorman , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Wed, Aug 24, 2016 at 10:22:43AM +0200, Arnd Bergmann wrote: > A bugfix in v4.8-rc2 introduced a harmless warning when CONFIG_MEMCG_SWAP > is disabled but CONFIG_MEMCG is enabled: > > mm/memcontrol.c:4085:27: error: 'mem_cgroup_id_get_online' defined but not used [-Werror=unused-function] > static struct mem_cgroup *mem_cgroup_id_get_online(struct mem_cgroup *memcg) > > This adds an extra #ifdef that matches the one around the caller to > avoid the warning. > > Signed-off-by: Arnd Bergmann > Fixes: 1f47b61fb407 ("mm: memcontrol: fix swap counter leak on swapout from offline cgroup") Acked-by: Vladimir Davydov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org