From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2 0/6] various vmxnet3 fixes and enhancement
Date: Wed, 24 Aug 2016 12:17:24 -0700
Message-ID: <20160824121724.6806219f@xeon-e3>
References: <1471049909-18117-5-git-send-email-yongwang@vmware.com>
 <1471997140-46527-1-git-send-email-yongwang@vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <thomas.monjalon@6wind.com>, <dev@dpdk.org>, <gyang@vmware.com>,
 <diproiettod@vmware.com>
To: Yong Wang <yongwang@vmware.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 4B85458D6
 for <dev@dpdk.org>; Wed, 24 Aug 2016 21:17:12 +0200 (CEST)
Received: by mail-pf0-f182.google.com with SMTP id y134so9601831pfg.0
 for <dev@dpdk.org>; Wed, 24 Aug 2016 12:17:12 -0700 (PDT)
In-Reply-To: <1471997140-46527-1-git-send-email-yongwang@vmware.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 23 Aug 2016 17:05:34 -0700
Yong Wang <yongwang@vmware.com> wrote:

> v2:
> * updated vmxnet3 feature doc.
> * updated vmxnet3 guide to remove stale information.
> 
> v1: This patchset includes a few bug fixes and some enhancement.
> 
> * Fixed a bug with dev_configure memzone size;
> * Enhanced error checks during device start.
>   * the driver will now report error if the rx queue number is
>     not a power of two, instead of waiting for the activation
>     to fail.
>   * Instead of returning -1 (which is interpreted as -EPERM) on
>     device activation failure, -EINVAL is returned now.
> * Enabled LRO if requested.
> 
> Yong Wang (6):
>   net/vmxnet3: improve error checks and return values
>   net/vmxnet3: coding style changes
>   net/vmxnet3: reallocate shared memzone on re-config
>   net/vmxnet3: update feature doc
>   net/vmxnet3: update nic doc
>   net/vmxnet3: enable lro
> 
>  doc/guides/nics/features/vmxnet3.ini |  22 ++++++
>  doc/guides/nics/vmxnet3.rst          |  12 +---
>  drivers/net/vmxnet3/vmxnet3_ethdev.c | 125 +++++++++++++++++++++--------------
>  drivers/net/vmxnet3/vmxnet3_ethdev.h |  32 +++++----
>  drivers/net/vmxnet3/vmxnet3_ring.h   |  22 +++---
>  drivers/net/vmxnet3/vmxnet3_rxtx.c   |  59 +++++++++--------
>  6 files changed, 158 insertions(+), 114 deletions(-)
> 

These all look good to me.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>