From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] configs: ti_omap4_common: Include TWL6030 power and I2C support in SPL
Date: Wed, 24 Aug 2016 11:22:11 -0400 [thread overview]
Message-ID: <20160824152211.GB10464@bill-the-cat> (raw)
In-Reply-To: <20160824144042.29354-1-contact@paulk.fr>
On Wed, Aug 24, 2016 at 04:40:41PM +0200, Paul Kocialkowski wrote:
> This includes the TWL6030 power driver in SPL, to allow powering up MMC
> devices. This is especially relevant when the bootrom didn't power any
> MMC device yet but U-Boot is to be loaded from MMC (e.g. after setting
> boot mode from the SYS_BOOT pins in peripheral boot).
>
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
> include/configs/ti_omap4_common.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/include/configs/ti_omap4_common.h b/include/configs/ti_omap4_common.h
> index 5fad3c1..7e08887 100644
> --- a/include/configs/ti_omap4_common.h
> +++ b/include/configs/ti_omap4_common.h
> @@ -65,9 +65,7 @@
> #define CONFIG_CONS_INDEX 3
>
> /* TWL6030 */
> -#ifndef CONFIG_SPL_BUILD
> #define CONFIG_TWL6030_POWER 1
> -#endif
>
> /* USB */
> #define CONFIG_USB_MUSB_UDC 1
> @@ -162,11 +160,4 @@
> #define CONFIG_SPL_NAND_AM33XX_BCH /* ELM support */
> #endif
>
> -#ifdef CONFIG_SPL_BUILD
> -/* No need for i2c in SPL mode as we will use SRI2C for PMIC access on OMAP4 */
> -#undef CONFIG_SYS_I2C
> -#undef CONFIG_SYS_I2C_OMAP24XX
> -#undef CONFIG_SPL_I2C_SUPPORT
> -#endif
> -
> #endif /* __CONFIG_TI_OMAP4_COMMON_H */
If nothing calls these functions in SPL they should be gc'd away and we
won't get any size increase. So in that case:
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160824/b4115f72/attachment.sig>
prev parent reply other threads:[~2016-08-24 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 14:40 [U-Boot] [PATCH 1/2] configs: ti_omap4_common: Include TWL6030 power and I2C support in SPL Paul Kocialkowski
2016-08-24 14:40 ` [U-Boot] [PATCH 2/2] panda: Initialize MMC power from TWL6030 " Paul Kocialkowski
2016-08-24 15:24 ` Tom Rini
2016-08-24 17:57 ` Paul Kocialkowski
2016-08-24 15:22 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160824152211.GB10464@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.