From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcaT8-00067A-Io for qemu-devel@nongnu.org; Wed, 24 Aug 2016 11:51:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bcaT3-0003S3-He for qemu-devel@nongnu.org; Wed, 24 Aug 2016 11:51:57 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcaT3-0003Rc-7t for qemu-devel@nongnu.org; Wed, 24 Aug 2016 11:51:53 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7OFj5We040508 for ; Wed, 24 Aug 2016 11:51:52 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 250kvvkwpj-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 24 Aug 2016 11:51:51 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Aug 2016 16:51:49 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 506362190046 for ; Wed, 24 Aug 2016 16:51:10 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7OFpk3u14876842 for ; Wed, 24 Aug 2016 15:51:46 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u7OFpkvD021348 for ; Wed, 24 Aug 2016 11:51:46 -0400 Date: Wed, 24 Aug 2016 17:51:44 +0200 From: Cornelia Huck In-Reply-To: <20160824154205.GF2032@work-vm> References: <1472046153-22123-1-git-send-email-dgilbert@redhat.com> <1472046153-22123-5-git-send-email-dgilbert@redhat.com> <20160824172911.4bf037c8.cornelia.huck@de.ibm.com> <20160824154205.GF2032@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20160824175144.72b292b5.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [RFC 4/6] virtio/migration: Add VMStateDescription to VirtioDeviceClass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, mst@redhat.com, amit.shah@redhat.com, quintela@redhat.com, duanj@linux.vnet.ibm.com On Wed, 24 Aug 2016 16:42:05 +0100 "Dr. David Alan Gilbert" wrote: > * Cornelia Huck (cornelia.huck@de.ibm.com) wrote: > > On Wed, 24 Aug 2016 14:42:31 +0100 > > "Dr. David Alan Gilbert (git)" wrote: > > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > > > index d2490c1..fd386ac 100644 > > > --- a/include/hw/virtio/virtio.h > > > +++ b/include/hw/virtio/virtio.h > > > @@ -124,8 +124,10 @@ typedef struct VirtioDeviceClass { > > > * must mask in frontend instead. > > > */ > > > void (*guest_notifier_mask)(VirtIODevice *vdev, int n, bool mask); > > > + /* Saving and loading of a device; use *either* save/load OR vmsd */ > > > > Should we try to enforce this in some way? Then virtio_{save,load} can > > call either/or instead of fallthrough which may have unintended > > consequences... > > I was thinking of doing that; but my intention is to kill off the save/load > methods ASAP. Fair enough, but doing a check for "did you by accident supply both?" might be helpful during development.