From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758103AbcHZAQ7 (ORCPT ); Thu, 25 Aug 2016 20:16:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42654 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757942AbcHZAQy (ORCPT ); Thu, 25 Aug 2016 20:16:54 -0400 Date: Thu, 25 Aug 2016 16:54:40 -0700 (PDT) Message-Id: <20160825.165440.1378074913181996224.davem@redhat.com> To: xander.huff@ni.com Cc: f.fainelli@gmail.com, sergei.shtylyov@cogentembedded.com, netdev@vger.kernel.org, brad.mouring@ni.com, linux-kernel@vger.kernel.org, nathan.sullivan@ni.com Subject: Re: [PATCH v2] Revert "phy: IRQ cannot be shared" From: David Miller In-Reply-To: <1472075273-16257-1-git-send-email-xander.huff@ni.com> References: <1472075273-16257-1-git-send-email-xander.huff@ni.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 25 Aug 2016 23:54:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xander Huff Date: Wed, 24 Aug 2016 16:47:53 -0500 > This reverts: > commit 33c133cc7598 ("phy: IRQ cannot be shared") > > On hardware with multiple PHY devices hooked up to the same IRQ line, allow > them to share it. > > Sergei Shtylyov says: > "I'm not sure now what was the reason I concluded that the IRQ sharing > was impossible... most probably I thought that the kernel IRQ handling > code exited the loop over the IRQ actions once IRQ_HANDLED was returned > -- which is obviously not so in reality..." > > Signed-off-by: Xander Huff > Signed-off-by: Nathan Sullivan > --- > Note: this reverted code fails "CHECK: Alignment should match open > parentesis" That's fine, we can fix up the indentation later. Applied and queued up for -stable, thanks.