All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@redhat.com>
To: xander.huff@ni.com
Cc: nicolas.ferre@atmel.com, netdev@vger.kernel.org,
	nathan.sullivan@ni.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: macb: Increase DMA TX buffer size
Date: Thu, 25 Aug 2016 16:59:06 -0700 (PDT)	[thread overview]
Message-ID: <20160825.165906.1864272195425576421.davem@redhat.com> (raw)
In-Reply-To: <1472077539-18033-1-git-send-email-xander.huff@ni.com>

From: Xander Huff <xander.huff@ni.com>
Date: Wed, 24 Aug 2016 17:25:39 -0500

> From: Nathan Sullivan <nathan.sullivan@ni.com>
> 
> In recent testing with the RT patchset, we have seen cases where the
> transmit ring can fill even with up to 200 txbds in the ring. Increase the
> size of the DMA TX ring to avoid overruns.
> 
> Signed-off-by: Xander Huff <xander.huff@ni.com>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>

This is really a short term solution.

While a larger TX ring may help RT, it's wasteful to have a ring that
large on non-RT.  Both uses are valid.

Therefore what really needs to happen is to make this driver support
changing the RX and TX ring sizes at runtime via ethtool just like
pretty much every other driver.

THanks.

      reply	other threads:[~2016-08-26  0:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 18:25 [PATCH] net: macb: Increase DMA buffer size Xander Huff
2016-08-24 19:17 ` Nicolas Ferre
2016-08-24 22:25   ` [PATCH v2] net: macb: Increase DMA TX " Xander Huff
2016-08-25 23:59     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160825.165906.1864272195425576421.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathan.sullivan@ni.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=xander.huff@ni.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.