From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org,
drm-intel-fixes@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Restore lost "Initialized i915" welcome message
Date: Thu, 25 Aug 2016 09:51:05 +0200 [thread overview]
Message-ID: <20160825075105.GO10980@phenom.ffwll.local> (raw)
In-Reply-To: <20160825072314.17402-1-chris@chris-wilson.co.uk>
On Thu, Aug 25, 2016 at 08:23:14AM +0100, Chris Wilson wrote:
> A side effect of removing the midlayer from driver loading was the loss
> of a useful message announcing to userspace that i915 had successfully
> started, e.g.:
>
> [drm] Initialized i915 1.6.0 20160425 for 0000:00:02.0 on minor 0
>
> Reported-by: Timo Aaltonen <tjaalton@ubuntu.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Fixes: 8f460e2c78f2 ("drm/i915: Demidlayer driver loading")
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: drm-intel-fixes@lists.freedesktop.org
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 6db1869e2c97..01757369d2d4 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1263,6 +1263,11 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent)
>
> intel_runtime_pm_enable(dev_priv);
>
> + /* Everything is in place, we can now relax! */
> + DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
> + driver.name, driver.major, driver.minor, driver.patchlevel,
> + driver.date, pci_name(pdev), dev_priv->drm.primary->index);
> +
> intel_runtime_pm_put(dev_priv);
>
> return 0;
> --
> 2.9.3
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-25 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 7:23 [PATCH] drm/i915: Restore lost "Initialized i915" welcome message Chris Wilson
2016-08-25 7:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-08-25 7:51 ` Daniel Vetter [this message]
2016-08-25 8:32 ` [PATCH] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825075105.GO10980@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=drm-intel-fixes@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.