From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 4/7] libxcmd: fix mount option parsing to find rt/log devices
Date: Thu, 25 Aug 2016 02:12:12 -0700 [thread overview]
Message-ID: <20160825091212.GD5685@infradead.org> (raw)
In-Reply-To: <147200548998.15538.11330546457799095768.stgit@birch.djwong.org>
On Tue, Aug 23, 2016 at 07:24:50PM -0700, Darrick J. Wong wrote:
> It turns out that glibc's hasmntopt implementation returns NULL
> if the opt parameter ends with an equals ('='). Therefore, we
> cannot directly search for the option 'rtdev='; we must instead
> have hasmntopt look for 'rtdev' and look for the trailing equals
> sign ourselves. This fixes xfs_info's reporting of external
> log and realtime device paths, and xfs_scrub will need it for
> data block scrubbing of realtime extents.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-25 9:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 2:24 [PATCH 0/7] xfsprogs: reverse mapping fixes Darrick J. Wong
2016-08-24 2:24 ` [PATCH 1/7] xfs: don't perform lookups on zero-height btrees Darrick J. Wong
2016-08-25 9:11 ` Christoph Hellwig
2016-08-24 2:24 ` [PATCH 2/7] xfs: fix some key handling problems in _btree_simple_query_range Darrick J. Wong
2016-08-25 9:11 ` Christoph Hellwig
2016-08-24 2:24 ` [PATCH 3/7] xfs: simple btree query range should look right if LE lookup fails Darrick J. Wong
2016-08-25 9:11 ` Christoph Hellwig
2016-08-24 2:24 ` [PATCH 4/7] libxcmd: fix mount option parsing to find rt/log devices Darrick J. Wong
2016-08-25 9:12 ` Christoph Hellwig [this message]
2016-08-24 2:24 ` [PATCH 5/7] misc: fix Coverity errors Darrick J. Wong
2016-08-25 9:14 ` Christoph Hellwig
2016-08-25 16:30 ` Darrick J. Wong
2016-08-25 21:02 ` [PATCH v2 " Darrick J. Wong
2016-08-24 2:25 ` [PATCH 6/7] misc: fix libxfs api violations Darrick J. Wong
2016-08-24 2:25 ` [PATCH 7/7] xfs_repair: fix naming problems in repair/rmap.c Darrick J. Wong
2016-08-25 21:03 ` [PATCH 0/7] xfsprogs: reverse mapping fixes Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825091212.GD5685@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.