From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758058AbcHYN3g (ORCPT ); Thu, 25 Aug 2016 09:29:36 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:57953 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753140AbcHYN3e (ORCPT ); Thu, 25 Aug 2016 09:29:34 -0400 Date: Thu, 25 Aug 2016 15:04:27 +0200 From: Peter Zijlstra To: Hari Bathini Cc: ast@fb.com, lkml , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, sargun@sargun.me, Aravinda Prasad , "Naveen N. Rao" , Ananth N Mavinakayanahalli , daniel@iogearbox.net Subject: Re: [PATCH 2/2] perf tool: add container identifier entry related changes Message-ID: <20160825130427.GG10138@twins.programming.kicks-ass.net> References: <147212627442.20120.6106492652250934757.stgit@hbathini.in.ibm.com> <147212628343.20120.374300104434639788.stgit@hbathini.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <147212628343.20120.374300104434639788.stgit@hbathini.in.ibm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2016 at 05:28:03PM +0530, Hari Bathini wrote: > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index d9b80ef..d35fbd3 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -929,6 +929,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, > if (opts->sample_transaction) > perf_evsel__set_sample_bit(evsel, TRANSACTION); > > + perf_evsel__set_sample_bit(evsel, CID); > + > if (opts->running_time) { > evsel->attr.read_format |= > PERF_FORMAT_TOTAL_TIME_ENABLED | Does this mean its enabled by default? Why? By growing the default sample to include everything under the sun we make profiling slower for everyone.