Re: [PATCH] IB/{core,hw}: Add constant for node_desc

From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] IB/{core,hw}: Add constant for node_desc
Date: Thu, 25 Aug 2016 19:56:08 +0300	[thread overview]
Message-ID: <20160825165608.GB3311@yuval-lap.uk.oracle.com> (raw)
In-Reply-To: <20160825164705.GA31542-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

On Thu, Aug 25, 2016 at 10:47:05AM -0600, Jason Gunthorpe wrote:
> On Thu, Aug 25, 2016 at 01:53:06AM -0700, Yuval Shaia wrote:
> 
> > -	memcpy(dev->ibdev.node_desc, IWCH_NODE_DESC, sizeof(IWCH_NODE_DESC));
> > +	memcpy(dev->ibdev.node_desc, IWCH_NODE_DESC, IB_DEVICE_NODE_DESC_MAX);
> 
> That is not OK. Nor are any of the similar ones.
> 
> Copies random kernel memory at the end of IWCH_NODE_DESC.

Oops.
Will post v1 in the next few minutes.

> 
> > -		memcpy(device->node_desc, device_modify->node_desc, 64);
> > +		memcpy(device->node_desc, device_modify->node_desc,
> > +		       IB_DEVICE_NODE_DESC_MAX);
> 
> And this and similar would be nicer as:
> 
> > +		memcpy(device->node_desc, device_modify->node_desc,
> >                      sizeof(device_modify->node_desc))
> 
> Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html