From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754459AbcHYS1G (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 Aug 2016 14:27:06 -0400
Received: from emh04.mail.saunalahti.fi ([62.142.5.110]:57321 "EHLO
        emh04.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752215AbcHYS1F (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 Aug 2016 14:27:05 -0400
Date: Thu, 25 Aug 2016 21:24:53 +0300
From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: "Steven J. Hill" <Steven.Hill@cavium.com>
Cc: David Daney <ddaney@caviumnetworks.com>,
        Jon Hunter <jonathanh@nvidia.com>, Rob Herring <robh@kernel.org>,
        devicetree@vger.kernel.org, linux-mips@linux-mips.org,
        linux-kernel@vger.kernel.org,
        Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON
Message-ID: <20160825182453.GF12169@raspberrypi.musicnaut.iki.fi>
References: <20160823203605.GA12169@raspberrypi.musicnaut.iki.fi>
 <57BDCE58.20200@cavium.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <57BDCE58.20200@cavium.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Wed, Aug 24, 2016 at 11:42:00AM -0500, Steven J. Hill wrote:
> It is actually two patches that cause the breakage. The other is:
> 
>    commit e55aeb6ba4e8cc3549bff1e75ea1d029324bce21
>    of/irq: Mark interrupt controllers as populated before initialisation
> 
> I needed to revert both of these in order to get MMC working on our 71xx and
> 78xx boards. For our MMC, I got error messages from the MMC core of "Invalid
> POWER GPIO" until I applied the second patch. I will have a fix worthy of
> upstreaming today which will be posted today.

The below change works for me...

diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
index 5a9b87b..5fd57c2 100644
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -1618,6 +1618,7 @@ static int __init octeon_irq_init_gpio(
 		pr_warn("Cannot allocate memory for GPIO irq_domain.\n");
 		return -ENOMEM;
 	}
+	of_node_clear_flag(gpio_node, OF_POPULATED);
 
 	return 0;
 }

A.