All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] package/uboot-tols: fix dependency of comment about FIT support
@ 2016-08-25 21:55 Peter Korsgaard
  2016-08-26  8:55 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2016-08-25 21:55 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=791e35f222da58e815a657d07b620635b78a80e8
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

When commit 031130a4 added the dependency on shared libs for FIT support
in uboot-tools, the dependency of the comment was added exactly as the
dependency of the symbol.

That means the comment is shown when FIT support is possible, and hidden
when it is not, while we want it the other way around...

Fix the dependency.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/uboot-tools/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/uboot-tools/Config.in b/package/uboot-tools/Config.in
index df61fda..f55614b 100644
--- a/package/uboot-tools/Config.in
+++ b/package/uboot-tools/Config.in
@@ -22,7 +22,7 @@ config BR2_PACKAGE_UBOOT_TOOLS_FIT_SUPPORT
 	  pass the address of the blob to the "bootm" command.
 
 comment "u-boot tools FIT support needs a toolchain w/ dynamic library"
-	depends on !BR2_STATIC_LIBS
+	depends on BR2_STATIC_LIBS
 
 if BR2_PACKAGE_UBOOT_TOOLS_FIT_SUPPORT
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [git commit] package/uboot-tols: fix dependency of comment about FIT support
  2016-08-25 21:55 [Buildroot] [git commit] package/uboot-tols: fix dependency of comment about FIT support Peter Korsgaard
@ 2016-08-26  8:55 ` Thomas Petazzoni
  2016-08-26  9:06   ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2016-08-26  8:55 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 25 Aug 2016 23:55:35 +0200, Peter Korsgaard wrote:
> commit: https://git.buildroot.net/buildroot/commit/?id=791e35f222da58e815a657d07b620635b78a80e8
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> When commit 031130a4 added the dependency on shared libs for FIT support
> in uboot-tools, the dependency of the comment was added exactly as the
> dependency of the symbol.
> 
> That means the comment is shown when FIT support is possible, and hidden
> when it is not, while we want it the other way around...
> 
> Fix the dependency.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

You forgot to fix the commit title, even though the typo was noticed
by Fabio and acknowledged by Yann.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [git commit] package/uboot-tols: fix dependency of comment about FIT support
  2016-08-26  8:55 ` Thomas Petazzoni
@ 2016-08-26  9:06   ` Peter Korsgaard
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2016-08-26  9:06 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 >> Fix the dependency.
 >> 
 >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 >> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 >> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

 > You forgot to fix the commit title, even though the typo was noticed
 > by Fabio and acknowledged by Yann.

Gaah, I must have been tired. I looked, but couldn't see the typo (I do
now).

-- 
Venlig hilsen,
Peter Korsgaard 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-08-26  9:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-25 21:55 [Buildroot] [git commit] package/uboot-tols: fix dependency of comment about FIT support Peter Korsgaard
2016-08-26  8:55 ` Thomas Petazzoni
2016-08-26  9:06   ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.