From: souvikdey33 <sodey@sonusnet.com>
To: <nhorman@tuxdriver.com>, <dev@dpdk.org>
Cc: souvikdey33 <sodey@sonusnet.com>
Subject: [PATCH v2] tools: fix issue with virtio interfaces
Date: Thu, 25 Aug 2016 23:59:56 -0400 [thread overview]
Message-ID: <20160826035956.17580-1-sodey@sonusnet.com> (raw)
In-Reply-To: <20160825022546.96468-1-sodey@sonusnet.com>
This change is required to have the interface name for virtio interfaces.
When we execute the status command the for virtio inerfaces we get
Sample output without the change:
0000:00:04.0 'Virtio network device' if= drv=virtio-pci unused=virtio_pci,igb_uio
Though for other drivers this works.
Sample output with the change:
0000:00:04.0 'Virtio network device' if=eth0 drv=virtio-pci unused=virtio_pci,igb_uio
souvikdey33 (1):
Signed-off-by: Souvik Dey <sodey@sonusnet.com>
Fixes: 3da038604009 ("Signed-off-by: Souvik Dey <sodey@sonusnet.com>")
tools/dpdk-devbind.py | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
--
>From 3da0386040092fcd54ee333ceff8c427a36c6b45 Mon Sep 17 00:00:00 2001
From: souvikdey33 <sodey@sonusnet.com>
Date: Thu, 25 Aug 2016 23:31:28 -0400
Subject: [PATCH v2] Signed-off-by: Souvik Dey <sodey@sonusnet.com>
When we execute the status command the for virtio inerfaces the interface name is not shown.
Sample output without the change.
0000:00:04.0 'Virtio network device' if= drv=virtio-pci unused=virtio_pci,igb_uio
Though for other this works.
---
tools/dpdk-devbind.py | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/tools/dpdk-devbind.py b/tools/dpdk-devbind.py
index 9829e25..c0b46ee 100755
--- a/tools/dpdk-devbind.py
+++ b/tools/dpdk-devbind.py
@@ -36,7 +36,6 @@ import sys
import os
import getopt
import subprocess
-import commands
from os.path import exists, abspath, dirname, basename
@@ -224,14 +223,18 @@ def get_pci_device_details(dev_id):
device[name] = value
# check for a unix interface name
sys_path = "/sys/bus/pci/devices/%s/net/" % dev_id
- #The path for virtio devices are different. Get the correct path.
- virtio = "/sys/bus/pci/devices/%s/" % dev_id
- cmd = " ls %s | grep 'virt' " %virtio
- virtio = commands.getoutput(cmd)
- virtio_sys_path = "/sys/bus/pci/devices/%s/%s/net/" % (dev_id,virtio)
+ # the path for virtio devices are different, so get the correct path
+ virtio = "/sys/bus/pci/devices/%s/" % dev_id
+ ls = subprocess.Popen(['ls', virtio], stdout=subprocess.PIPE)
+ grep = subprocess.Popen('grep virt'.split(), stdin=ls.stdout,
+ stdout=subprocess.PIPE)
+ ls.stdout.close()
+ virtio = grep.communicate()[0].rstrip()
+ ls.wait()
+ virtio_sys_path = "/sys/bus/pci/devices/%s/%s/net/" % (dev_id, virtio)
if exists(sys_path):
device["Interface"] = ",".join(os.listdir(sys_path))
- elif exists(virt_path):
+ elif exists(virtio_sys_path):
device["Interface"] = ",".join(os.listdir(virtio_sys_path))
else:
device["Interface"] = ""
--
2.9.3.windows.1
next prev parent reply other threads:[~2016-08-26 4:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 2:25 [PATCH v1] dpdk-devbind.py: Virtio interface issue souvikdey33
2016-08-25 9:51 ` Mcnamara, John
2016-08-25 10:19 ` Thomas Monjalon
2016-08-25 10:27 ` Mcnamara, John
2016-08-26 0:37 ` Stephen Hemminger
2016-08-26 3:59 ` souvikdey33 [this message]
2016-08-26 5:50 ` [PATCH v2] tools: fix issue with virtio interfaces souvikdey33
2016-08-26 11:35 ` [PATCH v3] " souvikdey33
2016-10-04 9:59 ` Thomas Monjalon
2016-08-26 15:55 ` [PATCH v1] dpdk-devbind.py: Virtio interface issue Stephen Hemminger
2016-08-27 0:20 ` Dey, Souvik
2016-08-29 15:09 ` Mussar, Gary
2016-08-29 23:16 ` Dey, Souvik
2016-08-29 23:33 ` Stephen Hemminger
2016-08-30 12:56 ` Neil Horman
2016-08-30 13:12 ` Mussar, Gary
2016-09-01 10:59 ` Mcnamara, John
2016-09-01 22:08 ` Dey, Souvik
2016-09-02 12:57 ` Mussar, Gary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160826035956.17580-1-sodey@sonusnet.com \
--to=sodey@sonusnet.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.