All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Weinehall <tao@kernel.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Fix intel_display_crc_init for !DEBUGFS
Date: Fri, 26 Aug 2016 14:19:35 +0200	[thread overview]
Message-ID: <20160826121934.GE7651@suiko.acc.umu.se> (raw)
In-Reply-To: <1472116022-17598-1-git-send-email-maarten.lankhorst@linux.intel.com>

On Thu, Aug 25, 2016 at 11:07:01AM +0200, Maarten Lankhorst wrote:
> The mentioned commit changes intel_display_crc_init to take a dev_priv,
> but forgets to change the stub.

Doh!

> 
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Fixes: 36cdd0138b7f ("drm/i915: debugfs spring cleaning")
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Reported-and-by: Kim Lidström <kim@dxtr.im>

Reviewed-by: David Weinehall <david.weinehall@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_drv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index ff96b7a69e6c..cf4d6a760b04 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -3522,7 +3522,7 @@ static inline int i915_debugfs_register(struct drm_i915_private *dev_priv) {retu
>  static inline void i915_debugfs_unregister(struct drm_i915_private *dev_priv) {}
>  static inline int i915_debugfs_connector_add(struct drm_connector *connector)
>  { return 0; }
> -static inline void intel_display_crc_init(struct drm_device *dev) {}
> +static inline void intel_display_crc_init(struct drm_i915_private *dev_priv) {}
>  #endif
>  
>  /* i915_gpu_error.c */
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2016-08-26 12:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25  9:07 [PATCH 1/2] drm/i915: Fix intel_display_crc_init for !DEBUGFS Maarten Lankhorst
2016-08-25  9:07 ` [PATCH 2/2] drm/i915: Add missing parameter to intel_dp_set_drrs_state documentation Maarten Lankhorst
2016-08-25  9:49   ` Chris Wilson
2016-08-25 11:29     ` Maarten Lankhorst
2016-08-25  9:47 ` [PATCH 1/2] drm/i915: Fix intel_display_crc_init for !DEBUGFS Chris Wilson
2016-08-25 10:21 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
2016-08-26 12:19 ` David Weinehall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160826121934.GE7651@suiko.acc.umu.se \
    --to=tao@kernel.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.