From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932356AbcH1HAx (ORCPT ); Sun, 28 Aug 2016 03:00:53 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:39293 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932249AbcH1HAw (ORCPT ); Sun, 28 Aug 2016 03:00:52 -0400 Date: Sun, 28 Aug 2016 10:00:49 +0300 From: Mikko Rapeli To: Sebastian Reichel Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v05 06/72] include/uapi/linux/hsi/cs-protocol.h: include linux/time.h Message-ID: <20160828070049.GA2831@lakka.kapsi.fi> References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-7-git-send-email-mikko.rapeli@iki.fi> <20160822205218.og5dgniufbuktlnq@earth> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160822205218.og5dgniufbuktlnq@earth> X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mikko.rapeli@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 22, 2016 at 10:52:20PM +0200, Sebastian Reichel wrote: > Hi, > > On Mon, Aug 22, 2016 at 08:32:23PM +0200, Mikko Rapeli wrote: > > Fixes userspace compilation errors due to missing timespec definition. > > > > Signed-off-by: Mikko Rapeli > > --- > > include/uapi/linux/hsi/cs-protocol.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/uapi/linux/hsi/cs-protocol.h b/include/uapi/linux/hsi/cs-protocol.h > > index f153d6e..c8d9f08 100644 > > --- a/include/uapi/linux/hsi/cs-protocol.h > > +++ b/include/uapi/linux/hsi/cs-protocol.h > > @@ -26,6 +26,7 @@ > > > > #include > > #include > > +#include > > > > /* chardev parameters */ > > #define CS_DEV_FILE_NAME "/dev/cmt_speech" > > As far as I can see there header file does not use timespec since > I removed it roughly a year ago. Yes, your patch 5023a5ca8e144846ec0646554336000abb11e04f fixes also uapi compilation errors. This patch from me is not needed and even wrong for the API. -Mikko