From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Tue, 30 Aug 2016 11:01:48 +0100 From: Lee Jones Subject: Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes Message-ID: <20160830100148.GO1661@dell> References: <1472223413-7254-1-git-send-email-peter.griffin@linaro.org> <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, vinod.koul@intel.com, patrice.chotard@st.com, dan.j.williams@intel.com, airlied@linux.ie, kraxel@redhat.com, ohad@wizery.com, bjorn.andersson@linaro.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-remoteproc@vger.kernel.org, Arnaud Pouliquen List-ID: On Fri, 26 Aug 2016, Peter Griffin wrote: > This patch adds the DT node for the uniperif reader > IP block found on STiH407 family silicon. > > Signed-off-by: Arnaud Pouliquen > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > index d263c96..bdddf2c 100644 > --- a/arch/arm/boot/dts/stih407-family.dtsi > +++ b/arch/arm/boot/dts/stih407-family.dtsi > @@ -956,5 +956,31 @@ > st,version = <5>; > st,mode = "SPDIF"; > }; > + > + sti_uni_reader0: sti-uni-reader@0 { > + compatible = "st,sti-uni-reader"; > + status = "disabled"; I find it's normally nicer to place the status of the node at the bottom, separated by a '\n'. There isn't a functional difference admittedly, but it would be my preference, since it's not describing the device per se. > + #sound-dai-cells = <0>; > + st,syscfg = <&syscfg_core>; > + reg = <0x8D83000 0x158>; We usually use lower-case for the address. Since this has a 'reg' property, the '0' in the node name does not look appropriate. > + interrupts = ; > + dmas = <&fdma0 5 0 1>; > + dma-names = "rx"; > + dai-name = "Uni Reader #0 (PCM IN)"; Oooo, not seen something like this before. If it does not already have one, it would require a DT Ack. > + st,version = <3>; This will likely need a DT Ack too. We usually encode this sort of information in the compatible string. > + }; > + > + sti_uni_reader1: sti-uni-reader@1 { > + compatible = "st,sti-uni-reader"; > + status = "disabled"; > + #sound-dai-cells = <0>; > + st,syscfg = <&syscfg_core>; > + reg = <0x8D84000 0x158>; > + interrupts = ; > + dmas = <&fdma0 6 0 1>; > + dma-names = "rx"; > + dai-name = "Uni Reader #1 (HDMI RX)"; > + st,version = <3>; > + }; All as above. > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes Date: Tue, 30 Aug 2016 11:01:48 +0100 Message-ID: <20160830100148.GO1661@dell> References: <1472223413-7254-1-git-send-email-peter.griffin@linaro.org> <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Griffin Cc: ohad@wizery.com, devicetree@vger.kernel.org, kernel@stlinux.com, vinod.koul@intel.com, Arnaud Pouliquen , linux-remoteproc@vger.kernel.org, patrice.chotard@st.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kraxel@redhat.com, dmaengine@vger.kernel.org, dan.j.williams@intel.com, bjorn.andersson@linaro.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gRnJpLCAyNiBBdWcgMjAxNiwgUGV0ZXIgR3JpZmZpbiB3cm90ZToKCj4gVGhpcyBwYXRjaCBh ZGRzIHRoZSBEVCBub2RlIGZvciB0aGUgdW5pcGVyaWYgcmVhZGVyCj4gSVAgYmxvY2sgZm91bmQg b24gU1RpSDQwNyBmYW1pbHkgc2lsaWNvbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBcm5hdWQgUG91 bGlxdWVuIDxhcm5hdWQucG91bGlxdWVuQHN0LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBQZXRlciBH cmlmZmluIDxwZXRlci5ncmlmZmluQGxpbmFyby5vcmc+Cj4gLS0tCj4gIGFyY2gvYXJtL2Jvb3Qv ZHRzL3N0aWg0MDctZmFtaWx5LmR0c2kgfCAyNiArKysrKysrKysrKysrKysrKysrKysrKysrKwo+ ICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNo L2FybS9ib290L2R0cy9zdGloNDA3LWZhbWlseS5kdHNpIGIvYXJjaC9hcm0vYm9vdC9kdHMvc3Rp aDQwNy1mYW1pbHkuZHRzaQo+IGluZGV4IGQyNjNjOTYuLmJkZGRmMmMgMTAwNjQ0Cj4gLS0tIGEv YXJjaC9hcm0vYm9vdC9kdHMvc3RpaDQwNy1mYW1pbHkuZHRzaQo+ICsrKyBiL2FyY2gvYXJtL2Jv b3QvZHRzL3N0aWg0MDctZmFtaWx5LmR0c2kKPiBAQCAtOTU2LDUgKzk1NiwzMSBAQAo+ICAJCQlz dCx2ZXJzaW9uID0gPDU+Owo+ICAJCQlzdCxtb2RlID0gIlNQRElGIjsKPiAgCQl9Owo+ICsKPiAr CQlzdGlfdW5pX3JlYWRlcjA6IHN0aS11bmktcmVhZGVyQDAgewo+ICsJCQljb21wYXRpYmxlID0g InN0LHN0aS11bmktcmVhZGVyIjsKPiArCQkJc3RhdHVzID0gImRpc2FibGVkIjsKCkkgZmluZCBp dCdzIG5vcm1hbGx5IG5pY2VyIHRvIHBsYWNlIHRoZSBzdGF0dXMgb2YgdGhlIG5vZGUgYXQgdGhl CmJvdHRvbSwgc2VwYXJhdGVkIGJ5IGEgJ1xuJy4gIFRoZXJlIGlzbid0IGEgZnVuY3Rpb25hbCBk aWZmZXJlbmNlCmFkbWl0dGVkbHksIGJ1dCBpdCB3b3VsZCBiZSBteSBwcmVmZXJlbmNlLCBzaW5j ZSBpdCdzIG5vdCBkZXNjcmliaW5nCnRoZSBkZXZpY2UgcGVyIHNlLgoKPiArCQkJI3NvdW5kLWRh aS1jZWxscyA9IDwwPjsKPiArCQkJc3Qsc3lzY2ZnID0gPCZzeXNjZmdfY29yZT47Cj4gKwkJCXJl ZyA9IDwweDhEODMwMDAgMHgxNTg+OwoKV2UgdXN1YWxseSB1c2UgbG93ZXItY2FzZSBmb3IgdGhl IGFkZHJlc3MuCgpTaW5jZSB0aGlzIGhhcyBhICdyZWcnIHByb3BlcnR5LCB0aGUgJzAnIGluIHRo ZSBub2RlIG5hbWUgZG9lcyBub3QKbG9vayBhcHByb3ByaWF0ZS4KCj4gKwkJCWludGVycnVwdHMg PSA8R0lDX1NQSSA4NyBJUlFfVFlQRV9OT05FPjsKPiArCQkJZG1hcyA9IDwmZmRtYTAgNSAwIDE+ Owo+ICsJCQlkbWEtbmFtZXMgPSAicngiOwo+ICsJCQlkYWktbmFtZSA9ICJVbmkgUmVhZGVyICMw IChQQ00gSU4pIjsKCk9vb28sIG5vdCBzZWVuIHNvbWV0aGluZyBsaWtlIHRoaXMgYmVmb3JlLgoK SWYgaXQgZG9lcyBub3QgYWxyZWFkeSBoYXZlIG9uZSwgaXQgd291bGQgcmVxdWlyZSBhIERUIEFj ay4KCj4gKwkJCXN0LHZlcnNpb24gPSA8Mz47CgpUaGlzIHdpbGwgbGlrZWx5IG5lZWQgYSBEVCBB Y2sgdG9vLiAgV2UgdXN1YWxseSBlbmNvZGUgdGhpcyBzb3J0IG9mCmluZm9ybWF0aW9uIGluIHRo ZSBjb21wYXRpYmxlIHN0cmluZy4KCj4gKwkJfTsKPiArCj4gKwkJc3RpX3VuaV9yZWFkZXIxOiBz dGktdW5pLXJlYWRlckAxIHsKPiArCQkJY29tcGF0aWJsZSA9ICJzdCxzdGktdW5pLXJlYWRlciI7 Cj4gKwkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwkJCSNzb3VuZC1kYWktY2VsbHMgPSA8MD47 Cj4gKwkJCXN0LHN5c2NmZyA9IDwmc3lzY2ZnX2NvcmU+Owo+ICsJCQlyZWcgPSA8MHg4RDg0MDAw IDB4MTU4PjsKPiArCQkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDg4IElSUV9UWVBFX05PTkU+Owo+ ICsJCQlkbWFzID0gPCZmZG1hMCA2IDAgMT47Cj4gKwkJCWRtYS1uYW1lcyA9ICJyeCI7Cj4gKwkJ CWRhaS1uYW1lID0gIlVuaSBSZWFkZXIgIzEgKEhETUkgUlgpIjsKPiArCQkJc3QsdmVyc2lvbiA9 IDwzPjsKPiArCQl9OwoKQWxsIGFzIGFib3ZlLgoKPiAgCX07Cj4gIH07CgotLSAKTGVlIEpvbmVz CkxpbmFybyBTVE1pY3JvZWxlY3Ryb25pY3MgTGFuZGluZyBUZWFtIExlYWQKTGluYXJvLm9yZyDi lIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vi b29rIHwgVHdpdHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 30 Aug 2016 11:01:48 +0100 Subject: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes In-Reply-To: <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> References: <1472223413-7254-1-git-send-email-peter.griffin@linaro.org> <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> Message-ID: <20160830100148.GO1661@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 26 Aug 2016, Peter Griffin wrote: > This patch adds the DT node for the uniperif reader > IP block found on STiH407 family silicon. > > Signed-off-by: Arnaud Pouliquen > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > index d263c96..bdddf2c 100644 > --- a/arch/arm/boot/dts/stih407-family.dtsi > +++ b/arch/arm/boot/dts/stih407-family.dtsi > @@ -956,5 +956,31 @@ > st,version = <5>; > st,mode = "SPDIF"; > }; > + > + sti_uni_reader0: sti-uni-reader at 0 { > + compatible = "st,sti-uni-reader"; > + status = "disabled"; I find it's normally nicer to place the status of the node at the bottom, separated by a '\n'. There isn't a functional difference admittedly, but it would be my preference, since it's not describing the device per se. > + #sound-dai-cells = <0>; > + st,syscfg = <&syscfg_core>; > + reg = <0x8D83000 0x158>; We usually use lower-case for the address. Since this has a 'reg' property, the '0' in the node name does not look appropriate. > + interrupts = ; > + dmas = <&fdma0 5 0 1>; > + dma-names = "rx"; > + dai-name = "Uni Reader #0 (PCM IN)"; Oooo, not seen something like this before. If it does not already have one, it would require a DT Ack. > + st,version = <3>; This will likely need a DT Ack too. We usually encode this sort of information in the compatible string. > + }; > + > + sti_uni_reader1: sti-uni-reader at 1 { > + compatible = "st,sti-uni-reader"; > + status = "disabled"; > + #sound-dai-cells = <0>; > + st,syscfg = <&syscfg_core>; > + reg = <0x8D84000 0x158>; > + interrupts = ; > + dmas = <&fdma0 6 0 1>; > + dma-names = "rx"; > + dai-name = "Uni Reader #1 (HDMI RX)"; > + st,version = <3>; > + }; All as above. > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog