All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Griffin <peter.griffin@linaro.org>
To: Jean-Christophe Trotin <jean-christophe.trotin@st.com>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>,
	Yannick Fertre <yannick.fertre@st.com>,
	kernel@stlinux.com,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>
Subject: Re: [STLinux Kernel] [PATCH v5 0/3] support of v4l2 encoder for STMicroelectronics SOC
Date: Tue, 30 Aug 2016 11:23:42 +0100	[thread overview]
Message-ID: <20160830102342.GA19583@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <1472476868-10322-1-git-send-email-jean-christophe.trotin@st.com>

Hi Jean-Christophe,

On Mon, 29 Aug 2016, Jean-Christophe Trotin wrote:

> version 5:
> - Compilation problem with 4.8-rc1 corrected: unsigned long used for dma_attrs
> - The video bitrate (V4L2_CID_MPEG_VIDEO_BITRATE) and the CPB size (V4L2_CID_MPEG_VIDEO_H264_CPB_SIZE) were respectively considered in kbps and kb, while the V4L2 API specifies them in bps and kB. This is corrected and the code is now aligned with the V4L2 specification
> - If the encoder close function (enc->close) has not been called through hva_stop_streaming (e.g. application is killed), it's called at the encoder instance release (hva_release)
> - hva-v4l2.c: DEFAULT_* renamed HVA_DEFAULT_*
> - hva-v4l2.c: few log messages modified
> - typos corrected
> - V4L2 compliance successfully passed with this version (see report below)
> 

Looks like you forgot to add my: -

 Acked-by: Peter Griffin <peter.griffin@linaro.org>

regards,

Peter.

  parent reply	other threads:[~2016-08-30 10:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29 13:21 [PATCH v5 0/3] support of v4l2 encoder for STMicroelectronics SOC Jean-Christophe Trotin
2016-08-29 13:21 ` [PATCH v5 1/3] Documentation: DT: add bindings for ST HVA Jean-Christophe Trotin
2016-08-29 13:21 ` [PATCH v5 2/3] st-hva: multi-format video encoder V4L2 driver Jean-Christophe Trotin
2016-09-01  3:32   ` kbuild test robot
2016-09-05  8:24   ` Hans Verkuil
2016-09-05 11:47     ` Jean Christophe TROTIN
2016-09-05 12:02       ` Hans Verkuil
2016-08-29 13:21 ` [PATCH v5 3/3] st-hva: add H.264 video encoding support Jean-Christophe Trotin
2016-08-30 10:23 ` Peter Griffin [this message]
2016-08-30 12:39   ` [STLinux Kernel] [PATCH v5 0/3] support of v4l2 encoder for STMicroelectronics SOC Jean Christophe TROTIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160830102342.GA19583@griffinp-ThinkPad-X1-Carbon-2nd \
    --to=peter.griffin@linaro.org \
    --cc=benjamin.gaignard@linaro.org \
    --cc=hverkuil@xs4all.nl \
    --cc=jean-christophe.trotin@st.com \
    --cc=kernel@stlinux.com \
    --cc=linux-media@vger.kernel.org \
    --cc=yannick.fertre@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.