From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757886AbcH3KqC (ORCPT ); Tue, 30 Aug 2016 06:46:02 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:35807 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757470AbcH3KqA (ORCPT ); Tue, 30 Aug 2016 06:46:00 -0400 Date: Tue, 30 Aug 2016 11:47:43 +0100 From: Lee Jones To: Mika Westerberg Cc: Brian Norris , linux-mtd@lists.infradead.org, David Woodhouse , Peter Tyser , key.seong.lim@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/3] spi-nor: Add support for Intel SPI serial flash controller Message-ID: <20160830104743.GD10121@dell> References: <1471245044-12767-1-git-send-email-mika.westerberg@linux.intel.com> <20160829071125.GX1812@lahna.fi.intel.com> <20160830091330.GH1661@dell> <20160830092803.GH1709@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160830092803.GH1709@lahna.fi.intel.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Aug 2016, Mika Westerberg wrote: > On Tue, Aug 30, 2016 at 10:13:30AM +0100, Lee Jones wrote: > > On Mon, 29 Aug 2016, Mika Westerberg wrote: > > > > > On Mon, Aug 15, 2016 at 10:10:41AM +0300, Mika Westerberg wrote: > > > > Hi, > > > > > > > > This is third version of the series. Previous versions can be found: > > > > > > > > v2: http://lists.infradead.org/pipermail/linux-mtd/2016-June/068277.html > > > > v1: https://lkml.org/lkml/2016/6/14/269 > > > > > > > > This series adds support for the Intel SPI serial flash controller found on > > > > many recent Intel CPUs including Baytrail and Braswell. This driver makes > > > > it possible to access the BIOS and other platform data which is stored on > > > > the SPI serial flash. It is also possible to upgrade the BIOS using this > > > > driver if it has not been protected by special hardware bits. > > > > > > > > The patch [1/3] includes documentation how to upgrade BIOS on MinnowBoard > > > > MAX. > > > > > > > > Since poking the SPI serial flash can brick the machine, this driver can > > > > only be enabled when CONFIG_EXPERT=y and even then it will remain read-only > > > > unless instructed othwerwise by module parameter. > > > > > > > > Lee can you ACK/NACK the MFD parts so that we can merge the whole series > > > > through the MTD tree? > > > > Why does it need to go into the MTD tree? What are the *build* > > dependencies? > > The first patch adds include/linux/platform_data/intel-spi.h which is > needed by the second patch to fill in the platform data structure. That's reasonable. I'm happy for the set to be routed via MTD. I do require a tagged immutable branch (with only these patches on) to pull from though. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog