All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: devicetree@vger.kernel.org, kernel@stlinux.com,
	vinod.koul@intel.com, linux-remoteproc@vger.kernel.org,
	patrice.chotard@st.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	Peter Griffin <peter.griffin@linaro.org>,
	airlied@linux.ie, dmaengine@vger.kernel.org,
	dan.j.williams@intel.com,
	virtualization@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 01/18] remoteproc: st_slim_rproc: add a slimcore rproc driver
Date: Tue, 30 Aug 2016 09:54:09 -0700	[thread overview]
Message-ID: <20160830165409.GM15161__7954.84760678864$1472621495$gmane$org@tuxbot> (raw)
In-Reply-To: <20160830123453.GG10121@dell>

On Tue 30 Aug 05:34 PDT 2016, Lee Jones wrote:

Thanks for your review Lee.

> On Fri, 26 Aug 2016, Peter Griffin wrote:
[..]
> > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> > index 1a8bf76a..06765e0 100644
> > --- a/drivers/remoteproc/Kconfig
> > +++ b/drivers/remoteproc/Kconfig
> > @@ -100,4 +100,12 @@ config ST_REMOTEPROC
> >  	  processor framework.
> >  	  This can be either built-in or a loadable module.
> >  
> > +config ST_SLIM_REMOTEPROC
> > +	tristate "ST Slim remoteproc support"
> > +	select REMOTEPROC
> > +	help
> > +	  Say y here to support firmware loading on IP based around
> > +	  the Slim core.
> > +	  If unsure say N.

Saw one more thing when browsing through...

As this piece of code doesn't do anything on its own and is going to be
selected by the "function driver" I don't think this should be
user-selectable.

Regards,
Bjorn

  parent reply	other threads:[~2016-08-30 16:54 UTC|newest]

Thread overview: 160+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 14:56 [PATCH v8 00/18] Add support for FDMA DMA controller and slim core rproc found on STi chipsets Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 01/18] remoteproc: st_slim_rproc: add a slimcore rproc driver Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30 12:34   ` Lee Jones
2016-08-30 12:34   ` Lee Jones
2016-08-30 12:34     ` Lee Jones
2016-08-30 12:34     ` Lee Jones
2016-08-30 15:44     ` Peter Griffin
2016-08-30 15:44     ` Peter Griffin
2016-08-30 15:44       ` Peter Griffin
2016-08-30 15:44       ` Peter Griffin
2016-08-31 11:24       ` Lee Jones
2016-08-31 11:24       ` Lee Jones
2016-08-31 11:24         ` Lee Jones
2016-08-31 11:24         ` Lee Jones
2016-08-30 16:54     ` Bjorn Andersson [this message]
2016-08-30 16:54     ` Bjorn Andersson
2016-08-30 16:54       ` Bjorn Andersson
2016-08-30 16:54       ` Bjorn Andersson
2016-08-31 11:11       ` Peter Griffin
2016-08-31 11:11         ` Peter Griffin
2016-08-31 11:11         ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 02/18] MAINTAINERS: Add st slim core rproc driver to STi section Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30 10:27   ` Lee Jones
2016-08-30 10:27   ` Lee Jones
2016-08-30 10:27     ` Lee Jones
2016-08-30 10:27     ` Lee Jones
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 04/18] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 05/18] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30 16:30   ` Vinod Koul
2016-08-30 16:30     ` Vinod Koul
2016-09-01 10:06     ` Peter Griffin
2016-09-01 10:06       ` Peter Griffin
2016-09-01 10:06       ` Peter Griffin
2016-09-01 10:06     ` Peter Griffin
2016-08-30 16:30   ` Vinod Koul
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 06/18] ARM: STi: DT: STiH407: Add FDMA driver dt nodes Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30 10:26   ` Lee Jones
2016-08-30 10:26     ` Lee Jones
2016-08-30 10:26     ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 07/18] MAINTAINERS: Add FDMA driver files to STi section Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 08/18] ARM: multi_v7_defconfig: Enable STi FDMA driver Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 09/18] ARM: multi_v7_defconfig: Enable STi and simple-card drivers Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30 10:25   ` Lee Jones
2016-08-30 10:25     ` Lee Jones
2016-08-30 10:25     ` Lee Jones
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 10/18] ARM: DT: STiH407: Add i2s_out pinctrl configuration Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30 10:24   ` Lee Jones
2016-08-30 10:24     ` Lee Jones
2016-08-30 10:24     ` Lee Jones
2016-08-30 10:24   ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 11/18] ARM: DT: STiH407: Add i2s_in " Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30 10:23   ` Lee Jones
2016-08-30 10:23     ` Lee Jones
2016-08-30 10:23     ` Lee Jones
2016-08-30 10:23   ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 12/18] ARM: DT: STiH407: Add spdif_out pinctrl config Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30 10:22   ` Lee Jones
2016-08-30 10:22   ` Lee Jones
2016-08-30 10:22     ` Lee Jones
2016-08-30 10:22     ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 13/18] ARM: STi: DT: STiH407: Add sti-sasg-codec dt node Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30 10:03   ` Lee Jones
2016-08-30 10:03     ` Lee Jones
2016-08-30 10:03     ` Lee Jones
2016-08-30 10:03   ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 14/18] ARM: STi: DT: STiH407: Add uniperif player dt nodes Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30 10:02   ` Lee Jones
2016-08-30 10:02   ` Lee Jones
2016-08-30 10:02     ` Lee Jones
2016-08-30 10:02     ` Lee Jones
2016-08-30 10:03     ` Lee Jones
2016-08-30 10:03     ` Lee Jones
2016-08-30 10:03       ` Lee Jones
2016-08-30 10:03       ` Lee Jones
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader " Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30 10:01   ` Lee Jones
2016-08-30 10:01   ` Lee Jones
2016-08-30 10:01     ` Lee Jones
2016-08-30 10:01     ` Lee Jones
2016-08-30 14:21     ` Peter Griffin
2016-08-30 14:21       ` Peter Griffin
2016-08-30 14:21       ` Peter Griffin
2016-08-31 11:28       ` Lee Jones
2016-08-31 11:28         ` Lee Jones
2016-08-31 11:28         ` Lee Jones
2016-09-05 12:20         ` Arnaud Pouliquen
2016-09-05 12:20         ` Arnaud Pouliquen
2016-09-05 12:20           ` Arnaud Pouliquen
2016-09-05 12:20           ` Arnaud Pouliquen
2016-09-05 12:20           ` Arnaud Pouliquen
2016-09-05 15:42           ` Lee Jones
2016-09-05 15:42           ` Lee Jones
2016-09-05 15:42             ` Lee Jones
2016-09-05 15:42             ` Lee Jones
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 16/18] ARM: DT: STi: stihxxx-b2120: Add DT nodes for STi audio card Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30  9:56   ` Lee Jones
2016-08-30  9:56   ` Lee Jones
2016-08-30  9:56     ` Lee Jones
2016-08-30  9:56     ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 17/18] drm/virtio: kconfig: Fix recursive dependency Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30  9:55   ` Lee Jones
2016-08-30  9:55   ` Lee Jones
2016-08-30  9:55     ` Lee Jones
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 18/18] drm/virtio: kconfig: Fixup white space Peter Griffin
2016-08-26 14:56 ` Peter Griffin
2016-08-26 14:56   ` Peter Griffin
2016-08-30  9:54   ` Lee Jones
2016-08-30  9:54     ` Lee Jones
2016-08-30  9:54     ` Lee Jones
2016-08-30  9:57     ` Lee Jones
2016-08-30  9:57       ` Lee Jones
2016-08-30  9:57       ` Lee Jones
2016-08-30  9:57     ` Lee Jones
2016-08-30  9:54   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20160830165409.GM15161__7954.84760678864$1472621495$gmane$org@tuxbot' \
    --to=bjorn.andersson@linaro.org \
    --cc=airlied@linux.ie \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@stlinux.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=patrice.chotard@st.com \
    --cc=peter.griffin@linaro.org \
    --cc=vinod.koul@intel.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.