From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Wed, 31 Aug 2016 12:28:19 +0100 From: Lee Jones Subject: Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes Message-ID: <20160831112819.GJ27357@dell> References: <1472223413-7254-1-git-send-email-peter.griffin@linaro.org> <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> <20160830100148.GO1661@dell> <20160830142112.GA22514@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160830142112.GA22514@griffinp-ThinkPad-X1-Carbon-2nd> To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, vinod.koul@intel.com, patrice.chotard@st.com, dan.j.williams@intel.com, airlied@linux.ie, kraxel@redhat.com, ohad@wizery.com, bjorn.andersson@linaro.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-remoteproc@vger.kernel.org, Arnaud Pouliquen List-ID: On Tue, 30 Aug 2016, Peter Griffin wrote: > Thanks for reviewing and your very valuable feedback. > On Tue, 30 Aug 2016, Lee Jones wrote: > > On Fri, 26 Aug 2016, Peter Griffin wrote: > > > > > This patch adds the DT node for the uniperif reader > > > IP block found on STiH407 family silicon. > > > > > > Signed-off-by: Arnaud Pouliquen > > > Signed-off-by: Peter Griffin > > > --- > > > arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ > > > 1 file changed, 26 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > > > index d263c96..bdddf2c 100644 > > > --- a/arch/arm/boot/dts/stih407-family.dtsi > > > +++ b/arch/arm/boot/dts/stih407-family.dtsi > > > @@ -956,5 +956,31 @@ > > > st,version = <5>; > > > st,mode = "SPDIF"; > > > }; > > > + > > > + sti_uni_reader0: sti-uni-reader@0 { > > > + compatible = "st,sti-uni-reader"; > > > + status = "disabled"; > > > > I find it's normally nicer to place the status of the node at the > > bottom, separated by a '\n'. > > Ok I'll add a superflous '\n' in the next version. Everyone loves a smart arse! In this case I believe the '\n' to be a functional separator and not superfluous at all. > > > + dai-name = "Uni Reader #0 (PCM IN)"; > > > > Oooo, not seen something like this before. > > > > If it does not already have one, it would require a DT Ack. > > No idea, the driver got merged 1 year ago. > > Arnaud did you get a DT ack when you merged this driver & binding? > > > > > + st,version = <3>; > > > > This will likely need a DT Ack too. We usually encode this sort of > > information in the compatible string. > > See 05c1b4480e86a871b18030d6f3d532dc0ecdf38c Well Rob's the boss. We certainly never used to take 'device ID' or 'version' attributes. I guess something must have changed. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes Date: Wed, 31 Aug 2016 12:28:19 +0100 Message-ID: <20160831112819.GJ27357@dell> References: <1472223413-7254-1-git-send-email-peter.griffin@linaro.org> <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> <20160830100148.GO1661@dell> <20160830142112.GA22514@griffinp-ThinkPad-X1-Carbon-2nd> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160830142112.GA22514@griffinp-ThinkPad-X1-Carbon-2nd> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Peter Griffin Cc: devicetree@vger.kernel.org, kernel@stlinux.com, vinod.koul@intel.com, Arnaud Pouliquen , linux-remoteproc@vger.kernel.org, patrice.chotard@st.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@linux.ie, dmaengine@vger.kernel.org, dan.j.williams@intel.com, bjorn.andersson@linaro.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gVHVlLCAzMCBBdWcgMjAxNiwgUGV0ZXIgR3JpZmZpbiB3cm90ZToKPiBUaGFua3MgZm9yIHJl dmlld2luZyBhbmQgeW91ciB2ZXJ5IHZhbHVhYmxlIGZlZWRiYWNrLgo+IE9uIFR1ZSwgMzAgQXVn IDIwMTYsIExlZSBKb25lcyB3cm90ZToKPiA+IE9uIEZyaSwgMjYgQXVnIDIwMTYsIFBldGVyIEdy aWZmaW4gd3JvdGU6Cj4gPiAKPiA+ID4gVGhpcyBwYXRjaCBhZGRzIHRoZSBEVCBub2RlIGZvciB0 aGUgdW5pcGVyaWYgcmVhZGVyCj4gPiA+IElQIGJsb2NrIGZvdW5kIG9uIFNUaUg0MDcgZmFtaWx5 IHNpbGljb24uCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBBcm5hdWQgUG91bGlxdWVuIDxh cm5hdWQucG91bGlxdWVuQHN0LmNvbT4KPiA+ID4gU2lnbmVkLW9mZi1ieTogUGV0ZXIgR3JpZmZp biA8cGV0ZXIuZ3JpZmZpbkBsaW5hcm8ub3JnPgo+ID4gPiAtLS0KPiA+ID4gIGFyY2gvYXJtL2Jv b3QvZHRzL3N0aWg0MDctZmFtaWx5LmR0c2kgfCAyNiArKysrKysrKysrKysrKysrKysrKysrKysr Kwo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKykKPiA+ID4gCj4gPiA+IGRp ZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9zdGloNDA3LWZhbWlseS5kdHNpIGIvYXJjaC9h cm0vYm9vdC9kdHMvc3RpaDQwNy1mYW1pbHkuZHRzaQo+ID4gPiBpbmRleCBkMjYzYzk2Li5iZGRk ZjJjIDEwMDY0NAo+ID4gPiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9zdGloNDA3LWZhbWlseS5k dHNpCj4gPiA+ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL3N0aWg0MDctZmFtaWx5LmR0c2kKPiA+ ID4gQEAgLTk1Niw1ICs5NTYsMzEgQEAKPiA+ID4gIAkJCXN0LHZlcnNpb24gPSA8NT47Cj4gPiA+ ICAJCQlzdCxtb2RlID0gIlNQRElGIjsKPiA+ID4gIAkJfTsKPiA+ID4gKwo+ID4gPiArCQlzdGlf dW5pX3JlYWRlcjA6IHN0aS11bmktcmVhZGVyQDAgewo+ID4gPiArCQkJY29tcGF0aWJsZSA9ICJz dCxzdGktdW5pLXJlYWRlciI7Cj4gPiA+ICsJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ID4gCj4g PiBJIGZpbmQgaXQncyBub3JtYWxseSBuaWNlciB0byBwbGFjZSB0aGUgc3RhdHVzIG9mIHRoZSBu b2RlIGF0IHRoZQo+ID4gYm90dG9tLCBzZXBhcmF0ZWQgYnkgYSAnXG4nLgo+IAo+IE9rIEknbGwg YWRkIGEgc3VwZXJmbG91cyAnXG4nIGluIHRoZSBuZXh0IHZlcnNpb24uCgpFdmVyeW9uZSBsb3Zl cyBhIHNtYXJ0IGFyc2UhCgpJbiB0aGlzIGNhc2UgSSBiZWxpZXZlIHRoZSAnXG4nIHRvIGJlIGEg ZnVuY3Rpb25hbCBzZXBhcmF0b3IgYW5kIG5vdApzdXBlcmZsdW91cyBhdCBhbGwuCgo+ID4gPiAr CQkJZGFpLW5hbWUgPSAiVW5pIFJlYWRlciAjMCAoUENNIElOKSI7Cj4gPiAKPiA+IE9vb28sIG5v dCBzZWVuIHNvbWV0aGluZyBsaWtlIHRoaXMgYmVmb3JlLgo+ID4gCj4gPiBJZiBpdCBkb2VzIG5v dCBhbHJlYWR5IGhhdmUgb25lLCBpdCB3b3VsZCByZXF1aXJlIGEgRFQgQWNrLgo+IAo+IE5vIGlk ZWEsIHRoZSBkcml2ZXIgZ290IG1lcmdlZCAxIHllYXIgYWdvLgo+IAo+IEFybmF1ZCBkaWQgeW91 IGdldCBhIERUIGFjayB3aGVuIHlvdSBtZXJnZWQgdGhpcyBkcml2ZXIgJiBiaW5kaW5nPwo+ID4g Cj4gPiA+ICsJCQlzdCx2ZXJzaW9uID0gPDM+Owo+ID4gCj4gPiBUaGlzIHdpbGwgbGlrZWx5IG5l ZWQgYSBEVCBBY2sgdG9vLiAgV2UgdXN1YWxseSBlbmNvZGUgdGhpcyBzb3J0IG9mCj4gPiBpbmZv cm1hdGlvbiBpbiB0aGUgY29tcGF0aWJsZSBzdHJpbmcuCj4gCj4gU2VlIDA1YzFiNDQ4MGU4NmE4 NzFiMTgwMzBkNmYzZDUzMmRjMGVjZGYzOGMKCldlbGwgUm9iJ3MgdGhlIGJvc3MuICBXZSBjZXJ0 YWlubHkgbmV2ZXIgdXNlZCB0byB0YWtlICdkZXZpY2UgSUQnIG9yCid2ZXJzaW9uJyBhdHRyaWJ1 dGVzLiAgSSBndWVzcyBzb21ldGhpbmcgbXVzdCBoYXZlIGNoYW5nZWQuCgotLSAKTGVlIEpvbmVz CkxpbmFybyBTVE1pY3JvZWxlY3Ryb25pY3MgTGFuZGluZyBUZWFtIExlYWQKTGluYXJvLm9yZyDi lIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vi b29rIHwgVHdpdHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxp c3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Wed, 31 Aug 2016 12:28:19 +0100 Subject: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes In-Reply-To: <20160830142112.GA22514@griffinp-ThinkPad-X1-Carbon-2nd> References: <1472223413-7254-1-git-send-email-peter.griffin@linaro.org> <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> <20160830100148.GO1661@dell> <20160830142112.GA22514@griffinp-ThinkPad-X1-Carbon-2nd> Message-ID: <20160831112819.GJ27357@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 30 Aug 2016, Peter Griffin wrote: > Thanks for reviewing and your very valuable feedback. > On Tue, 30 Aug 2016, Lee Jones wrote: > > On Fri, 26 Aug 2016, Peter Griffin wrote: > > > > > This patch adds the DT node for the uniperif reader > > > IP block found on STiH407 family silicon. > > > > > > Signed-off-by: Arnaud Pouliquen > > > Signed-off-by: Peter Griffin > > > --- > > > arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ > > > 1 file changed, 26 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > > > index d263c96..bdddf2c 100644 > > > --- a/arch/arm/boot/dts/stih407-family.dtsi > > > +++ b/arch/arm/boot/dts/stih407-family.dtsi > > > @@ -956,5 +956,31 @@ > > > st,version = <5>; > > > st,mode = "SPDIF"; > > > }; > > > + > > > + sti_uni_reader0: sti-uni-reader at 0 { > > > + compatible = "st,sti-uni-reader"; > > > + status = "disabled"; > > > > I find it's normally nicer to place the status of the node at the > > bottom, separated by a '\n'. > > Ok I'll add a superflous '\n' in the next version. Everyone loves a smart arse! In this case I believe the '\n' to be a functional separator and not superfluous at all. > > > + dai-name = "Uni Reader #0 (PCM IN)"; > > > > Oooo, not seen something like this before. > > > > If it does not already have one, it would require a DT Ack. > > No idea, the driver got merged 1 year ago. > > Arnaud did you get a DT ack when you merged this driver & binding? > > > > > + st,version = <3>; > > > > This will likely need a DT Ack too. We usually encode this sort of > > information in the compatible string. > > See 05c1b4480e86a871b18030d6f3d532dc0ecdf38c Well Rob's the boss. We certainly never used to take 'device ID' or 'version' attributes. I guess something must have changed. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog