From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936072AbcHaQmC (ORCPT ); Wed, 31 Aug 2016 12:42:02 -0400 Received: from down.free-electrons.com ([37.187.137.238]:42124 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754012AbcHaQl7 (ORCPT ); Wed, 31 Aug 2016 12:41:59 -0400 Date: Wed, 31 Aug 2016 18:41:56 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: David Airlie , dri-devel , linux-arm-kernel , linux-kernel Subject: Re: [PATCH] drm/sun4i: Clear encoder->bridge if a bridge is not found Message-ID: <20160831164156.GL14379@lukather> References: <20160830122223.21377-1-wens@csie.org> <20160830125622.GF18605@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oJAv8lSwuaQsYd0G" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --oJAv8lSwuaQsYd0G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 31, 2016 at 07:09:23PM +0800, Chen-Yu Tsai wrote: > >>> sun4i_tcon_channel_disable(tcon, 0); > >>> > >>> - if (!IS_ERR(encoder->bridge)) > >>> - drm_bridge_disable(encoder->bridge); > >>> + drm_bridge_disable(encoder->bridge); > >> > >> I'd rather keep those changes, it makes it obvious that it's something > >> optionnal, that can be set to NULL. > > > > OK. >=20 > What about having a comment instead? Saves an extra branch condition, > while still showing that it's optional. I'm not sure we have to worry about an extra branch condition, but yeah, that works for me. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --oJAv8lSwuaQsYd0G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXxwjUAAoJEBx+YmzsjxAgJjwQAMI+NnyQK6Ex/0gRN338HswK ufNjD2PiOJ8X5Ssv7XZOceicszy53GeAWxke/4TDXNPFk3dNHk/KOL/z7VaXAVWQ mJAYBw3cqo3V2lVC8p+Cbinb0DsT9ELnMAc1GhhTk+1FaO+/6rgHqOGlmOvIl5wO JthBxXQLCamSDpn97D5zEDVy8A1yb6i8nmpAXfXTAAJUVcZU2jB7M209pzaEbyTX tFEDHhhuvwQBftDnf4uvZTb4b/kbnyoNow/kmY1IbFF8ifO5NNdg6z8Bs4MyWPIH Vxb+E2bZnObhTdqo9esS+lm6cpnDxuLZox4UkPO/bUCaIrgzP3GWVWcKyG3DhYjF M+3nWrUUreRnTIXIC1RBiKJFesyv8GeKP55fzxXk1JwDULjaXEBW9lVvAm43eU/G 5RmC/SjgEC6siiBwUZjMJgTyLiA+2a9Wqn4acRYhdNnTwOuCOfTy9XU1tAs20VB0 tEVJiHfY0n14wAl+frhwdznzZrXb65ssHKXjylnIWoSNCFfeaqevSFzEmtLeyuW8 z5gSoQL0ELhQl9n57tSqvG1fuZqkV0gDoBdu/20vHI1vKxWK5mCgXm6vTCAdCSP+ A6UH3diIuiRk288rCornzs4/ilStK0QD9C+JKrXdDnfiFF68HeQOvLsnnXJ+1o/u aeMcNAARtBjIGHCHh8wU =jtkb -----END PGP SIGNATURE----- --oJAv8lSwuaQsYd0G-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Wed, 31 Aug 2016 18:41:56 +0200 Subject: [PATCH] drm/sun4i: Clear encoder->bridge if a bridge is not found In-Reply-To: References: <20160830122223.21377-1-wens@csie.org> <20160830125622.GF18605@lukather> Message-ID: <20160831164156.GL14379@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Aug 31, 2016 at 07:09:23PM +0800, Chen-Yu Tsai wrote: > >>> sun4i_tcon_channel_disable(tcon, 0); > >>> > >>> - if (!IS_ERR(encoder->bridge)) > >>> - drm_bridge_disable(encoder->bridge); > >>> + drm_bridge_disable(encoder->bridge); > >> > >> I'd rather keep those changes, it makes it obvious that it's something > >> optionnal, that can be set to NULL. > > > > OK. > > What about having a comment instead? Saves an extra branch condition, > while still showing that it's optional. I'm not sure we have to worry about an extra branch condition, but yeah, that works for me. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] drm/sun4i: Clear encoder->bridge if a bridge is not found Date: Wed, 31 Aug 2016 18:41:56 +0200 Message-ID: <20160831164156.GL14379@lukather> References: <20160830122223.21377-1-wens@csie.org> <20160830125622.GF18605@lukather> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1538607180==" Return-path: Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by gabe.freedesktop.org (Postfix) with ESMTP id 346AE6E1CE for ; Wed, 31 Aug 2016 16:41:58 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chen-Yu Tsai Cc: linux-arm-kernel , dri-devel , linux-kernel List-Id: dri-devel@lists.freedesktop.org --===============1538607180== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oJAv8lSwuaQsYd0G" Content-Disposition: inline --oJAv8lSwuaQsYd0G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 31, 2016 at 07:09:23PM +0800, Chen-Yu Tsai wrote: > >>> sun4i_tcon_channel_disable(tcon, 0); > >>> > >>> - if (!IS_ERR(encoder->bridge)) > >>> - drm_bridge_disable(encoder->bridge); > >>> + drm_bridge_disable(encoder->bridge); > >> > >> I'd rather keep those changes, it makes it obvious that it's something > >> optionnal, that can be set to NULL. > > > > OK. >=20 > What about having a comment instead? Saves an extra branch condition, > while still showing that it's optional. I'm not sure we have to worry about an extra branch condition, but yeah, that works for me. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --oJAv8lSwuaQsYd0G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXxwjUAAoJEBx+YmzsjxAgJjwQAMI+NnyQK6Ex/0gRN338HswK ufNjD2PiOJ8X5Ssv7XZOceicszy53GeAWxke/4TDXNPFk3dNHk/KOL/z7VaXAVWQ mJAYBw3cqo3V2lVC8p+Cbinb0DsT9ELnMAc1GhhTk+1FaO+/6rgHqOGlmOvIl5wO JthBxXQLCamSDpn97D5zEDVy8A1yb6i8nmpAXfXTAAJUVcZU2jB7M209pzaEbyTX tFEDHhhuvwQBftDnf4uvZTb4b/kbnyoNow/kmY1IbFF8ifO5NNdg6z8Bs4MyWPIH Vxb+E2bZnObhTdqo9esS+lm6cpnDxuLZox4UkPO/bUCaIrgzP3GWVWcKyG3DhYjF M+3nWrUUreRnTIXIC1RBiKJFesyv8GeKP55fzxXk1JwDULjaXEBW9lVvAm43eU/G 5RmC/SjgEC6siiBwUZjMJgTyLiA+2a9Wqn4acRYhdNnTwOuCOfTy9XU1tAs20VB0 tEVJiHfY0n14wAl+frhwdznzZrXb65ssHKXjylnIWoSNCFfeaqevSFzEmtLeyuW8 z5gSoQL0ELhQl9n57tSqvG1fuZqkV0gDoBdu/20vHI1vKxWK5mCgXm6vTCAdCSP+ A6UH3diIuiRk288rCornzs4/ilStK0QD9C+JKrXdDnfiFF68HeQOvLsnnXJ+1o/u aeMcNAARtBjIGHCHh8wU =jtkb -----END PGP SIGNATURE----- --oJAv8lSwuaQsYd0G-- --===============1538607180== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1538607180==--