From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753012AbcIAHPB (ORCPT ); Thu, 1 Sep 2016 03:15:01 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:35931 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbcIAHO5 (ORCPT ); Thu, 1 Sep 2016 03:14:57 -0400 Date: Thu, 1 Sep 2016 15:14:52 +0800 From: Simon Guo To: David Rientjes Cc: linux-mm@kvack.org, Alexey Klimov , Andrew Morton , Eric B Munson , Geert Uytterhoeven , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Mel Gorman , Michal Hocko , Shuah Khan , Thierry Reding , Vlastimil Babka Subject: Re: [PATCH 4/4] selftests/vm: add test for mlock() when areas are intersected. Message-ID: <20160901071354.GA3306@simonLocalRHEL7.x64> References: <1472554781-9835-1-git-send-email-wei.guo.simon@gmail.com> <1472554781-9835-5-git-send-email-wei.guo.simon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, On Wed, Aug 31, 2016 at 04:14:14PM -0700, David Rientjes wrote: > On Tue, 30 Aug 2016, wei.guo.simon@gmail.com wrote: > > > From: Simon Guo > > > > This patch adds mlock() test for multiple invocation on > > the same address area, and verify it doesn't mess the > > rlimit mlock limitation. > > > > Thanks for expanding mlock testing. I'm wondering if you are interested > in more elaborate testing that doesn't only check what you are fixing, > such as mlock(p + x, 40k) where x is < 20k? > > Would you also be willing to make sure that the rlimit is actually > enforced when it's expected to? I'd like to do so. Let me think more for the comprehensive testing. If you have any other test cases in mind, please let me know. Thanks, - Simon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f198.google.com (mail-yb0-f198.google.com [209.85.213.198]) by kanga.kvack.org (Postfix) with ESMTP id 844D482F64 for ; Thu, 1 Sep 2016 03:14:57 -0400 (EDT) Received: by mail-yb0-f198.google.com with SMTP id 18so35387630ybc.3 for ; Thu, 01 Sep 2016 00:14:57 -0700 (PDT) Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com. [2607:f8b0:400e:c03::22a]) by mx.google.com with ESMTPS id j29si4202656pfk.53.2016.09.01.00.14.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Sep 2016 00:14:56 -0700 (PDT) Received: by mail-pa0-x22a.google.com with SMTP id hb8so26981862pac.2 for ; Thu, 01 Sep 2016 00:14:56 -0700 (PDT) Date: Thu, 1 Sep 2016 15:14:52 +0800 From: Simon Guo Subject: Re: [PATCH 4/4] selftests/vm: add test for mlock() when areas are intersected. Message-ID: <20160901071354.GA3306@simonLocalRHEL7.x64> References: <1472554781-9835-1-git-send-email-wei.guo.simon@gmail.com> <1472554781-9835-5-git-send-email-wei.guo.simon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: linux-mm@kvack.org, Alexey Klimov , Andrew Morton , Eric B Munson , Geert Uytterhoeven , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Mel Gorman , Michal Hocko , Shuah Khan , Thierry Reding , Vlastimil Babka Hi David, On Wed, Aug 31, 2016 at 04:14:14PM -0700, David Rientjes wrote: > On Tue, 30 Aug 2016, wei.guo.simon@gmail.com wrote: > > > From: Simon Guo > > > > This patch adds mlock() test for multiple invocation on > > the same address area, and verify it doesn't mess the > > rlimit mlock limitation. > > > > Thanks for expanding mlock testing. I'm wondering if you are interested > in more elaborate testing that doesn't only check what you are fixing, > such as mlock(p + x, 40k) where x is < 20k? > > Would you also be willing to make sure that the rlimit is actually > enforced when it's expected to? I'd like to do so. Let me think more for the comprehensive testing. If you have any other test cases in mind, please let me know. Thanks, - Simon -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org