From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfT87-0001u6-PD for qemu-devel@nongnu.org; Thu, 01 Sep 2016 10:38:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfT85-0002mF-SD for qemu-devel@nongnu.org; Thu, 01 Sep 2016 10:38:10 -0400 Date: Thu, 1 Sep 2016 16:37:57 +0200 From: Kevin Wolf Message-ID: <20160901143757.GD6355@noname.redhat.com> References: <20160829171021.4902-1-pbutsykin@virtuozzo.com> <20160829171021.4902-4-pbutsykin@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160829171021.4902-4-pbutsykin@virtuozzo.com> Subject: Re: [Qemu-devel] [PATCH RFC v2 03/22] util/rbtree: add rbtree from linux kernel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Butsykin Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, den@openvz.org, jsnow@redhat.com, eblake@redhat.com, famz@redhat.com Am 29.08.2016 um 19:10 hat Pavel Butsykin geschrieben: > Why don't we use rbtree from glib? We need pointer to the parent node. > For optimal implementation storing of cached chunks in the rbtree > need to get next and previous nodes and content of parent node > is very useful for effective implementation of these functions. In this > implementation of rbtree (unlike rbtree of glib) the node contains a pointer > to parent node. Moreover, this rbtree allows more flexibility to > work with an algorithm because to use rbtrees you'll have to implement > your own insert and search cores. This will avoid us to use callbacks and > to drop drammatically performances. > > Signed-off-by: Pavel Butsykin General note (only having looked at the diffstat): We need to make sure that new files that this series adds are covered by MAINTAINERS entries. Kevin