From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Hadar Hen Zion <hadarh@dev.mellanox.co.il>
Cc: Hadar Hen Zion <hadarh@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>, Jiri Pirko <jiri@mellanox.com>,
Jiri Benc <jbenc@redhat.com>, Jamal Hadi Salim <jhs@mojatatu.com>,
Tom Herbert <tom@herbertland.com>,
Eric Dumazet <edumazet@google.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Amir Vadai <amirva@mellanox.com>, Amir Vadai <amir@vadai.me>
Subject: Re: [PATCH net-next V4 4/4] net/sched: Introduce act_tunnel_key
Date: Thu, 1 Sep 2016 16:58:18 +0300 [thread overview]
Message-ID: <20160901165818.3dc6db4c@halley> (raw)
In-Reply-To: <CAJL1qvG54C5V-GzRqOKVhXjL7d1OUj5GuQvyx2vsKpQDdf_0Xg@mail.gmail.com>
On Thu, 1 Sep 2016 14:59:28 +0300 Hadar Hen Zion <hadarh@dev.mellanox.co.il> wrote:
> > Seems we need to call tcf_hash_release regardless 'ovr':
> > In case (!exist), we've created a new hash few lines above.
> > Therefore in failure, don't we need a tcf_hash_release()?
> > Am I missing something?
>
> You are right, "if (ovr)" line should be removed.
Looking at it again, seems the right condition should be (pls verify):
if (ret == ACT_P_CREATED)
tcf_hash_release(*a, bind);
Thanks,
Shmulik
next prev parent reply other threads:[~2016-09-01 13:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 12:46 [PATCH net-next V4 0/4] net/sched: ip tunnel metadata set/release/classify by using TC Hadar Hen Zion
2016-08-31 12:46 ` [PATCH net-next V4 1/4] net/ip_tunnels: Introduce tunnel_id_to_key32() and key32_to_tunnel_id() Hadar Hen Zion
2016-08-31 15:04 ` Jiri Pirko
2016-08-31 12:46 ` [PATCH net-next V4 2/4] net/dst: Utility functions to build dst_metadata without supplying an skb Hadar Hen Zion
2016-08-31 15:07 ` Jiri Pirko
2016-08-31 17:11 ` Shmulik Ladkani
2016-08-31 12:46 ` [PATCH net-next V4 3/4] net/sched: cls_flower: Classify packet in ip tunnels Hadar Hen Zion
2016-08-31 15:12 ` Jiri Pirko
2016-08-31 12:46 ` [PATCH net-next V4 4/4] net/sched: Introduce act_tunnel_key Hadar Hen Zion
2016-08-31 15:39 ` Jiri Pirko
2016-08-31 17:44 ` Shmulik Ladkani
2016-09-01 11:59 ` Hadar Hen Zion
2016-09-01 13:58 ` Shmulik Ladkani [this message]
2016-08-31 18:39 ` Eric Dumazet
2016-09-01 9:28 ` Hadar Hen Zion
2016-09-01 13:16 ` Eric Dumazet
2016-09-01 13:46 ` Hadar Hen Zion
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901165818.3dc6db4c@halley \
--to=shmulik.ladkani@gmail.com \
--cc=amir@vadai.me \
--cc=amirva@mellanox.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hadarh@dev.mellanox.co.il \
--cc=hadarh@mellanox.com \
--cc=jbenc@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=tom@herbertland.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.